Skip to contentSkip to conversation

bcache: check all uuid elements when start flash only volumes

PATCH In review Coly Li 2 participants 3 messages Feb 26, 2018 – Feb 27, 2018

Subsystems (2)
lore
Share & tools
lore

Coly Li

author
#0 lore raw

PATCH 1/1 bcache: check all uuid elements when start flash only volumes

Commit 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used") adds c->devices_max_used to reduce iteration of c->uuids elements, this value is updated in bcache_device_attach().

But for flash only volume, when calling flash_devs_run(), the function bcache_device_attach() is not called yet and c->devices_max_used is not updated. The unexpected result is, the flash only volume won't be run by flash_devs_run().

This patch fixes the issue by iterate all c->uuids elements in flash_devs_run(). c->devices_max_used will be updated properly when bcache_device_attach() gets called.

Fixes 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used")
Cc Michael Lyle <[email protected]>
---
 drivers/md/bcache/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/bcache/super.c +1 -1
index 312895788036..4d1d8dfb2d2a 100644
@@ -1274,7 +1274,7 @@ static int flash_devs_run(struct cache_set *c)
 	struct uuid_entry *u;
 
 	for (u = c->uuids;
-	     u < c->uuids + c->devices_max_used && !ret;
+	     u < c->uuids + c->nr_uuids && !ret;
 	     u++)
 		if (UUID_FLASH_ONLY(u))
 			ret = flash_dev_run(c, u);
Signature · 1 line
2.16.1
author
#1 lore raw
Quoted 27 lines · Coly Li

Commit 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used") adds c->devices_max_used to reduce iteration of c->uuids elements, this value is updated in bcache_device_attach().

But for flash only volume, when calling flash_devs_run(), the function bcache_device_attach() is not called yet and c->devices_max_used is not updated. The unexpected result is, the flash only volume won't be run by flash_devs_run().

This patch fixes the issue by iterate all c->uuids elements in flash_devs_run(). c->devices_max_used will be updated properly when bcache_device_attach() gets called.

Fixes 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used")
Cc Michael Lyle <[email protected]>
---
 drivers/md/bcache/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/bcache/super.c +0 -0
index 312895788036..4d1d8dfb2d2a 100644

drivers/md/bcache/super.c static int flash_devs_run(struct cache_set *c) · line 1280

Quoted 8 lines
drivers/md/bcache/super.c +1 -1
@@ -1274,7 +1274,7 @@ static int flash_devs_run(struct cache_set *c)
 	struct uuid_entry *u;
 
 	for (u = c->uuids;
-	     u < c->uuids + c->devices_max_used && !ret;
+	     u < c->uuids + c->nr_uuids && !ret;
 	     u++)
 		if (UUID_FLASH_ONLY(u))
 			ret = flash_dev_run(c, u);

Hi Jens and Michael,

Could you please have a look and pick this fix into 4.16 ? Commit 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used") is just merged in 4.16-rc1, so I don't CC stable for this fix.

And I still need a peer code reviewer on this patch, any Reviewed-by is welcome.

Thanks to Junhui Tang for reporting this issue today.

Coly Li

Reviewed-by
#2 lore raw

I have this and the other fix in the queue for testing tomorrow and will pass along a changeset to Jens if all looks good. Thanks!

Mike

Quoted 56 lines · Coly Li
Quoted 27 lines · Coly Li

Commit 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used") adds c->devices_max_used to reduce iteration of c->uuids elements, this value is updated in bcache_device_attach().

But for flash only volume, when calling flash_devs_run(), the function bcache_device_attach() is not called yet and c->devices_max_used is not updated. The unexpected result is, the flash only volume won't be run by flash_devs_run().

This patch fixes the issue by iterate all c->uuids elements in flash_devs_run(). c->devices_max_used will be updated properly when bcache_device_attach() gets called.

Fixes 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used")
Cc Michael Lyle <[email protected]>
---
 drivers/md/bcache/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/bcache/super.c +0 -0
index 312895788036..4d1d8dfb2d2a 100644

drivers/md/bcache/super.c static int flash_devs_run(struct cache_set *c) · line 1280

Quoted 8 lines
drivers/md/bcache/super.c +1 -1
@@ -1274,7 +1274,7 @@ static int flash_devs_run(struct cache_set *c)
 	struct uuid_entry *u;
 
 	for (u = c->uuids;
-	     u < c->uuids + c->devices_max_used && !ret;
+	     u < c->uuids + c->nr_uuids && !ret;
 	     u++)
 		if (UUID_FLASH_ONLY(u))
 			ret = flash_dev_run(c, u);

Hi Jens and Michael,

Could you please have a look and pick this fix into 4.16 ? Commit 2831231d4c3f ("bcache: reduce cache_set devices iteration by devices_max_used") is just merged in 4.16-rc1, so I don't CC stable for this fix.

And I still need a peer code reviewer on this patch, any Reviewed-by is welcome.

Thanks to Junhui Tang for reporting this issue today.

Coly Li

--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html