bnxt_en: Remove mis-applied code from bnxt_cfg_ntp_filters()
Michael Chan
maintainerPATCH 1/1 bnxt_en: Remove mis-applied code from bnxt_cfg_ntp_filters()
The 2 lines to check for the BNXT_HWRM_PF_UNLOAD_SP_EVENT bit was mis-applied to bnxt_cfg_ntp_filters() and should have been applied to bnxt_sp_task().
Fixes 19241368443f ("bnxt_en: Send PF driver unload notification to all VFs.")
Reviewed-by Andy Gospodarek <[email protected]>
Signed-off-by Michael Chan <[email protected]>
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +2 -2
@@ -12093,6 +12093,8 @@ static void bnxt_sp_task(struct work_struct *work)bnxt_cfg_ntp_filters (bp);if (test_and_clear_bit (BNXT_HWRM_EXEC_FWD_REQ_SP_EVENT , &bp->sp_event))bnxt_hwrm_exec_fwd_req (bp); +if (test_and_clear_bit (BNXT_HWRM_PF_UNLOAD_SP_EVENT , &bp->sp_event)) +netdev_info (bp->dev,"Receive PF driver unload event!\n" );if (test_and_clear_bit (BNXT_PERIODIC_STATS_SP_EVENT , &bp->sp_event)) {bnxt_hwrm_port_qstats (bp,0 );bnxt_hwrm_port_qstats_ext (bp,0 );
@@ -13093,8 +13095,6 @@ static void bnxt_cfg_ntp_filters(struct bnxt *bp) } } } -if (test_and_clear_bit (BNXT_HWRM_PF_UNLOAD_SP_EVENT , &bp->sp_event)) -netdev_info (bp->dev,"Receive PF driver unload event!\n" ); }#else
Signature · 1 line
2.30.1
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 9 lines · On Wed, 3 Jan 2024 16:59:24 -0800 you wrote:
The 2 lines to check for the
BNXT_HWRM_PF_UNLOAD_SP_EVENTbit was mis-applied tobnxt_cfg_ntp_filters()and should have been applied tobnxt_sp_task().Fixes 19241368443f ("bnxt_en: Send PF driver unload notification to all VFs.")Reviewed-by Andy Gospodarek <[email protected]>Signed-off-by Michael Chan <[email protected]>[...]
Here is the summary with links:
- [net] bnxt_en: Remove mis-applied code from bnxt_cfg_ntp_filters()
https://git.kernel.org/netdev/net/c/e009b2efb7a8
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html