mlxbf_gige: Enable the GigE port in mlxbf_gige_open
Subsystems (2)
PATCH v4 1/1 mlxbf_gige: Enable the GigE port in mlxbf_gige_open
At the moment, the GigE port is enabled in the mlxbf_gige_probe function. If the mlxbf_gige_open is not executed, this could cause pause frames to increase in the case where there is high backgroud traffic. This results in clogging the port.
So move enabling the OOB port to mlxbf_gige_open.
---v3->v4:
- rebase
- Fork this patch from bundle of unrelated bug fixes.
- update the subject format
.../ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c +6 -6
@@ -130,9 +130,15 @@ static int mlxbf_gige_open(struct net_device *netdev) {struct mlxbf_gige *priv =netdev_priv (netdev);struct phy_device *phydev = netdev->phydev; +u64 control;u64 int_en;int err; +/* Perform general init of GigE block */ + control =readq (priv->base +MLXBF_GIGE_CONTROL ); + control |=MLXBF_GIGE_CONTROL_PORT_EN ; +writeq (control, priv->base +MLXBF_GIGE_CONTROL ); + err =mlxbf_gige_request_irqs (priv);if (err)return err;
@@ -365,7 +371,6 @@ static int mlxbf_gige_probe(struct platform_device *pdev)void __iomem *plu_base;void __iomem *base;int addr, phy_irq; -u64 control;int err; base =devm_platform_ioremap_resource (pdev,MLXBF_GIGE_RES_MAC );
@@ -380,11 +385,6 @@ static int mlxbf_gige_probe(struct platform_device *pdev)if (IS_ERR (plu_base))return PTR_ERR (plu_base); -/* Perform general init of GigE block */ - control =readq (base +MLXBF_GIGE_CONTROL ); - control |=MLXBF_GIGE_CONTROL_PORT_EN ; -writeq (control, base +MLXBF_GIGE_CONTROL ); - netdev =devm_alloc_etherdev (&pdev->dev,sizeof (*priv));if (!netdev)return -ENOMEM ;
Signature · 1 line
2.30.1
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 6 lines · On Fri, 5 Jan 2024 11:00:14 -0500 you wrote:
At the moment, the GigE port is enabled in the
mlxbf_gige_probefunction. If themlxbf_gige_openis not executed, this could cause pause frames to increase in the case where there is high backgroud traffic. This results in clogging the port.
So move enabling the OOB port tomlxbf_gige_open.
Quoted 6 lines
Fixes f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")Reviewed-by David Thompson <[email protected]>Signed-off-by Asmaa Mnebhi <[email protected]>Reviewed-by Florian Fainelli <[email protected]>[...]
Here is the summary with links:
- [net,v4] mlxbf_gige: Enable the GigE port in mlxbf_gige_open
https://git.kernel.org/netdev/net/c/a460f4a68451
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html