Skip to contentSkip to conversation

ARM: davinci: always select CONFIG_CPU_ARM926T

PATCH Applied Arnd Bergmann 3 participants 3 messages Jan 8, 2024 – Jan 9, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: davinci: always select CONFIG_CPU_ARM926T

From: Arnd Bergmann <[email protected]>

The select was lost by accident during the multiplatform conversion. Any davinci-only

arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
(.text+0x168): undefined reference to `arm926_flush_kern_cache_all'

Fixes f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")

---
I ran into this today for the first time after five years of randconfig testing with the bug in place, so it is clearly very hard to hit.

It's an obvious fix, so I'm applying it to the soc/arm branch directly for this week's pull requests.

 arch/arm/mach-davinci/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-davinci/Kconfig +1 -0
index 1c8bf56982e5..2a8a9fe46586 100644
@@ -4,6 +4,7 @@ menuconfig ARCH_DAVINCI
 	bool "TI DaVinci"
 	depends on ARCH_MULTI_V5
 	depends on CPU_LITTLE_ENDIAN
+	select CPU_ARM926T
 	select DAVINCI_TIMER
 	select ZONE_DMA
 	select PM_GENERIC_DOMAINS if PM
Signature · 1 line
2.39.2
Acked-by on v1 1/1
#1 lore raw
Quoted 35 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The select was lost by accident during the multiplatform conversion. Any davinci-only

arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
(.text+0x168): undefined reference to `arm926_flush_kern_cache_all'

Fixes f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")

---
I ran into this today for the first time after five years of randconfig testing with the bug in place, so it is clearly very hard to hit.

It's an obvious fix, so I'm applying it to the soc/arm branch directly for this week's pull requests.

 arch/arm/mach-davinci/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-davinci/Kconfig +1 -1
index 1c8bf56982e5..2a8a9fe46586 100644
@@ -4,6 +4,7 @@ menuconfig ARCH_DAVINCI
        bool "TI DaVinci"
        depends on ARCH_MULTI_V5
        depends on CPU_LITTLE_ENDIAN
+       select CPU_ARM926T
        select DAVINCI_TIMER
        select ZONE_DMA
        select PM_GENERIC_DOMAINS if PM
--
Quoted 2 lines

2.39.2

#2 lore raw
In reply to Arnd Bergmann
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:

Quoted 9 lines · On Mon, 8 Jan 2024 12:00:36 +0100 you wrote:

From: Arnd Bergmann <[email protected]>

The select was lost by accident during the multiplatform conversion. Any davinci-only

arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
(.text+0x168): undefined reference to `arm926_flush_kern_cache_all'

[...]

Here is the summary with links:
- ARM: davinci: always select CONFIG_CPU_ARM926T

    https://git.kernel.org/soc/soc/c/40974ee421b4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html