Skip to contentSkip to conversation

arm: imx: imx8m: Enable the SError exception

PATCH In review Ye Li 4 participants 6 messages Jan 12, 2024 – Feb 2, 2024

Subsystems (3)
lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH 1/1 arm: imx: imx8m: Enable the SError exception

To work with commit 2f3c920(imx8m: workaround ROM serror), we need to enable the SError exception and install vector in SPL.

---
 arch/arm/mach-imx/imx8m/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/imx8m/Kconfig +3 -0
index 67da198..88ef732 100644
@@ -11,14 +11,17 @@ config IMX8MQ
 	bool
 	select IMX8M
 	select CLK_IMX8MQ
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MM
 	bool
 	select IMX8M
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MN
 	bool
 	select IMX8M
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MP
 	bool
Signature · 1 line
2.7.4
#3 lore raw

Hi Ye Li,

I can confirm that our i.MX8MNano LPD4 EVK with field return fuse blown can boot to u-boot prompt after applying your patch.

Thank you for your support.

Best regards,
Thomas

-----Ursprüngliche Nachricht-----
Von: Fabio Estevam <[email protected]>
Gesendet: Freitag, 12. Januar 2024 19:01
An: Ye Li <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Thomas Schaefer <[email protected]>
Betreff: Re: [PATCH] arm: imx: imx8m: Enable the SError exception

Hi Ye Li,

Quoted 6 lines · Ye Li

To work with commit 2f3c920(imx8m: workaround ROM serror), we need to enable the SError exception and install vector in SPL.

This causes an image increase that makes SPL to not fit into the internal SRAM on some boards:

https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/769422

reviewer
#4 lore raw
In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

Hi Ye Li,

Quoted 4 lines · Ye Li

To work with commit 2f3c920(imx8m: workaround ROM serror), we need to enable the SError exception and install vector in SPL.

Quoted 7 lines
Quoted 2 lines

This causes an image increase that makes SPL to not fit into the internal SRAM on some boards:

https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/769422

To fix this problem, what if we enable LTO for all imx8m platforms?

arch/arm/mach-imx/imx8m/Kconfig +1 -0
index b1937198402f..6617a631b4d6 100644
@@ -7,19 +7,23 @@ config IMX8M
        select HAS_CAAM
        select ROM_UNIFIED_SECTIONS
        select ARMV8_CRYPTO
+       select LTO
 
 config IMX8MQ
 

What do you think?

#5 lore raw
In reply to Ye Li
Quoted 33 lines · Ye Li

To work with commit 2f3c920(imx8m: workaround ROM serror), we need to enable the SError exception and install vector in SPL.

---
 arch/arm/mach-imx/imx8m/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/imx8m/Kconfig +3 -1
index 67da198..88ef732 100644
@@ -11,14 +11,17 @@ config IMX8MQ
        bool
        select IMX8M
        select CLK_IMX8MQ
+       select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MM
        bool
        select IMX8M
+       select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MN
        bool
        select IMX8M
+       select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MP
        bool
--
Quoted 2 lines

2.7.4

Would this not also work for 8MP? If that's the case, should the section of ARMV8_SPL_EXCEPTION_VECTORS fall under "config IMX8M" for simplicity?

adam