riscv: remove unneeded #include <asm-generic/export.h>
PATCH 1/1 riscv: remove unneeded #include <asm-generic/export.h>
Commit 62694797f56b ("use linux/export.h rather than asm-generic/export.h") replaced deprecated <asm-generic/export.h> inclusions.
Commit c2a658d41924 ("riscv: lib: vectorize copy_to_user/copy_from_user") introduced a new instance of #include <asm-generic/export.h>.
arch/riscv/lib/uaccess_vector.S does not use EXPORT_SYMBOL, hence this include directive is unneeded.
---
I CC'ed Al Viro in case he attempts to replace <asm-generic/export.h> with <linux/export.h> again.
Commit 62694797f56b was suboptimal because arch/riscv/kernel/mcount-dyn.S does not use EXPORT_SYMBOL. Removing #include <asm-generic/export.h> was correct.
I had submitted a patchset earlier, but it was not picked up:
https://lore.kernel.org/all/[email protected]/
arch/riscv/lib/uaccess_vector.S | 1 - 1 file changed, 1 deletion(-)
arch/riscv/lib/uaccess_vector.S +0 -1
@@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <linux/linkage.h> -#include <asm-generic/export.h> #include <asm/asm.h> #include <asm/asm-extable.h> #include <asm/csr.h>
Signature · 1 line
2.40.1
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Quoted 8 lines · On Sun, 21 Jan 2024 06:33:11 +0900 you wrote:
Commit
62694797f56b("uselinux/export.hrather thanasm-generic/export.h") replaced deprecated <asm-generic/export.h> inclusions.Commit
c2a658d41924("riscv: lib: vectorize copy_to_user/copy_from_user") introduced a new instance of #include <asm-generic/export.h>.[...]
Here is the summary with links:
- riscv: remove unneeded #include <asm-generic/export.h>
https://git.kernel.org/riscv/c/3a6dd5f614a1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html