Skip to contentSkip to conversation

arm64: dts: qcom: ipq6018: support thermal sensors

PATCH Applied Mantas Pucka 3 participants 6 messages Jan 25, 2024 – Feb 7, 2024

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover arm64: dts: qcom: ipq6018: support thermal sensors

IPQ6018 have a thermal sensor HW that's compatible with existing qcom-tsens driver, so add dt-binding and enable it in devicei-tree.

Mantas Pucka (3):
dt-bindings: thermal: qcom-tsens: add IPQ6018 compatible
arm64: dts: qcom: ipq6018: add tsens node
arm64: dts: qcom: ipq6018: add thermal zones

 .../devicetree/bindings/thermal/qcom-tsens.yaml    |   1 +
 arch/arm64/boot/dts/qcom/ipq6018.dtsi              | 131 +++++++++++++++++++++
 2 files changed, 132 insertions(+)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/3 dt-bindings: thermal: qcom-tsens: add IPQ6018 compatible

IPQ6018 has tsens HW block compatible with IPQ8074.

---
 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +1 -0
index 99d9c526c0b6..d6f333a7bcd1 100644
@@ -76,6 +76,7 @@ properties:
       - description: v2 of TSENS with combined interrupt
         items:
           - enum:
+              - qcom,ipq6018-tsens
               - qcom,ipq9574-tsens
           - const: qcom,ipq8074-tsens
 
Signature · 1 line
2.7.4
Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] dt-bindings: thermal: qcom-tsens: add IPQ6018 compatible

Quoted 3 lines · Mantas Pucka

IPQ6018 has tsens HW block compatible with IPQ8074.

Cheers,
Conor.

Quoted 19 lines
---
 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +1 -0
index 99d9c526c0b6..d6f333a7bcd1 100644
@@ -76,6 +76,7 @@ properties:
       - description: v2 of TSENS with combined interrupt
         items:
           - enum:
+              - qcom,ipq6018-tsens
               - qcom,ipq9574-tsens
           - const: qcom,ipq8074-tsens
 
Signature · 1 line
2.7.4
#3 lore raw

PATCH 2/3 arm64: dts: qcom: ipq6018: add tsens node

In reply to Mantas Pucka

IPQ6018 has temperature sensing HW block compatible with IPQ8074. Add node for it.

---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/qcom/ipq6018.dtsi +10 -0
index 3d0f6621ee97..f2765fe8c20b 100644
@@ -330,6 +330,16 @@
 			clock-names = "core";
 		};
 
+		tsens: thermal-sensor@4a9000 {
+			compatible = "qcom,ipq6018-tsens", "qcom,ipq8074-tsens";
+			reg = <0x0 0x004a9000 0x0 0x1000>,
+			      <0x0 0x004a8000 0x0 0x1000>;
+			interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "combined";
+			#qcom,sensors = <16>;
+			#thermal-sensor-cells = <1>;
+		};
+
 		cryptobam: dma-controller@704000 {
 			compatible = "qcom,bam-v1.7.0";
 			reg = <0x0 0x00704000 0x0 0x20000>;
Signature · 1 line
2.7.4
#4 lore raw

PATCH 3/3 arm64: dts: qcom: ipq6018: add thermal zones

In reply to Mantas Pucka

Add thermal zones to make use of thermal sensors data. For CPU zone, add cooling device that uses CPU frequency scaling.

---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 121 ++++++++++++++++++++++++++++++++++
 1 file changed, 121 insertions(+)
arch/arm64/boot/dts/qcom/ipq6018.dtsi +121 -0
index f2765fe8c20b..4fb253b845c8 100644
@@ -9,6 +9,7 @@
 #include <dt-bindings/clock/qcom,gcc-ipq6018.h>
 #include <dt-bindings/reset/qcom,gcc-ipq6018.h>
 #include <dt-bindings/clock/qcom,apss-ipq.h>
+#include <dt-bindings/thermal/thermal.h>
 
 / {
 	#address-cells = <2>;
@@ -43,6 +44,7 @@
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
 			cpu-supply = <&ipq6018_s2>;
+			#cooling-cells = <2>;
 		};
 
 		CPU1: cpu@1 {
@@ -55,6 +57,7 @@
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
 			cpu-supply = <&ipq6018_s2>;
+			#cooling-cells = <2>;
 		};
 
 		CPU2: cpu@2 {
@@ -67,6 +70,7 @@
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
 			cpu-supply = <&ipq6018_s2>;
+			#cooling-cells = <2>;
 		};
 
 		CPU3: cpu@3 {
@@ -79,6 +83,7 @@
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
 			cpu-supply = <&ipq6018_s2>;
+			#cooling-cells = <2>;
 		};
 
 		L2_0: l2-cache {
@@ -996,6 +1001,122 @@
 		};
 	};
 
+	thermal-zones {
+		nss-top-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsens 4>;
+
+			trips {
+				nss-top-critical {
+					temperature = <125000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+
+		nss-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsens 5>;
+
+			trips {
+				nss-critical {
+					temperature = <125000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+
+		wcss-phya0-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsens 7>;
+
+			trips {
+				wcss-phya0-critical {
+					temperature = <125000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+
+		wcss-phya1-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsens 8>;
+
+			trips {
+				wcss-phya1-critical {
+					temperature = <125000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cpu-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsens 13>;
+
+			trips {
+				cpu-critical {
+					temperature = <125000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+
+				cpu_alert: cpu-passive {
+					temperature = <110000>;
+					hysteresis = <1000>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cpu_alert>;
+					cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		lpass-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsens 14>;
+
+			trips {
+				lpass-critical {
+					temperature = <125000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+
+		ddrss-top-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+			thermal-sensors = <&tsens 15>;
+
+			trips {
+				ddrss-top-critical {
+					temperature = <125000>;
+					hysteresis = <1000>;
+					type = "critical";
+				};
+			};
+		};
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
Signature · 1 line
2.7.4
maintainer Applied
#5 lore raw

Re: (subset) [PATCH 0/3] arm64: dts: qcom: ipq6018: support thermal sensors

In reply to Mantas Pucka
Quoted 9 lines · Mantas Pucka

IPQ6018 have a thermal sensor HW that's compatible with existing qcom-tsens driver, so add dt-binding and enable it in devicei-tree.

Mantas Pucka (3):
dt-bindings: thermal: qcom-tsens: add IPQ6018 compatible
arm64: dts: qcom: ipq6018: add tsens node
arm64: dts: qcom: ipq6018: add thermal zones

[...]

Applied, thanks!

[2/3] arm64: dts: qcom: ipq6018: add tsens node

      commit: 0b17197055b528da22e9385200e61b847b499d48
[3/3] arm64: dts: qcom: ipq6018: add thermal zones
      commit: 8f053e5616352943e16966f195f5a7a161e6fe7d

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>