selftests/net/lib: update busywait timeout value
Subsystems (3)
PATCH v2 1/1 selftests/net/lib: update busywait timeout value
The busywait timeout value is a millisecond, not a second. So the current setting 2 is too small. On slow/busy host (or VMs) the current timeout can expire even on "correct" execution, causing random failures. Let's copy the WAIT_TIMEOUT from forwarding/lib.sh and set BUSYWAIT_TIMEOUT here.
---
v2: add fixes flag. update possible failures.
--- tools/testing/selftests/net/lib.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/testing/selftests/net/lib.sh +4 -1
@@ -4,6 +4,9 @@ ############################################################################## # Defines +WAIT_TIMEOUT=${WAIT_TIMEOUT:=20} +BUSYWAIT_TIMEOUT=$((WAIT_TIMEOUT * 1000)) # ms + # Kselftest framework requirement - SKIP code is 4. ksft_skip=4 # namespace list created by setup_ns
@@ -48,7 +51,7 @@ cleanup_ns() for ns in "$@"; do ip netns delete "${ns}" &> /dev/null - if ! busywait 2 ip netns list \| grep -vq "^$ns$" &> /dev/null; then + if ! busywait $BUSYWAIT_TIMEOUT ip netns list \| grep -vq "^$ns$" &> /dev/null; then echo "Warn: Failed to remove namespace $ns" ret=1 fi
Signature · 1 line
2.43.0
Quoted 8 lines · Hangbin Liu
The busywait timeout value is a millisecond, not a second. So the current setting 2 is too small. On slow/busy host (or VMs) the current timeout can expire even on "correct" execution, causing random failures. Let's copy the
WAIT_TIMEOUTfromforwarding/lib.shand setBUSYWAIT_TIMEOUThere.Fixes 25ae948b4478 ("selftests/net: add lib.sh")Signed-off-by Hangbin Liu <[email protected]>
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Wed, 24 Jan 2024 14:13:44 +0800 you wrote:
The busywait timeout value is a millisecond, not a second. So the current setting 2 is too small. On slow/busy host (or VMs) the current timeout can expire even on "correct" execution, causing random failures. Let's copy the
WAIT_TIMEOUTfromforwarding/lib.shand setBUSYWAIT_TIMEOUThere.Fixes 25ae948b4478 ("selftests/net: add lib.sh")Signed-off-by Hangbin Liu <[email protected]>[...]
Here is the summary with links:
- [PATCHv2,net] selftests/net/lib: update busywait timeout value
https://git.kernel.org/netdev/net/c/fc836129f708
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html