bpf: fix warning from basename()
Subsystems (3)
PATCH 1/1 bpf: fix warning from basename()
The function basename() expects a mutable character string, which now causes a warning:
bpf_legacy.c: In function ‘bpf_load_common’:
bpf_legacy.c:975:38: warning: passing argument 1 of ‘__xpg_basename’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
975 | basename(cfg->object), cfg->mode == EBPF_PINNED ?
| ~~~^~~~~~~~
In file included from bpf_legacy.c:21:/usr/include/libgen.h:34:36: note: expected ‘char *’ but argument is of type ‘const char *’
34 | extern char *__xpg_basename (char *__path) __THROW;
--- lib/bpf_legacy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/bpf_legacy.c +2 -2
@@ -972,8 +972,8 @@ int bpf_load_common(struct bpf_cfg_in *cfg, const struct bpf_cfg_ops *ops, ops->cbpf_cb (nl, cfg->opcodes, cfg->n_opcodes);if (cfg->mode ==EBPF_OBJECT || cfg->mode ==EBPF_PINNED ) {snprintf (annotation,sizeof (annotation),"%s:[%s]" , -basename (cfg->object), cfg->mode ==EBPF_PINNED ? -"*fsobj" : cfg->section); +basename (strdupa (cfg->object)), + cfg->mode ==EBPF_PINNED ?"*fsobj" : cfg->section); ops->ebpf_cb (nl, cfg->prog_fd, annotation); }
Signature · 1 line
2.43.0
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:
Hello:
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:
Quoted 6 lines · On Sat, 27 Jan 2024 14:00:32 -0800 you wrote:
The function
basename()expects a mutable character string, which now causes a warning:
bpf_legacy.c: In function ‘bpf_load_common’:
bpf_legacy.c:975:38: warning: passing argument 1 of ‘__xpg_basename’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
975 |basename(cfg->object),cfg->mode==EBPF_PINNED?
Quoted 6 lines
| ~~~^~~~~~~~In file included from bpf_legacy.c:21:
/usr/include/libgen.h:34:36: note: expected ‘char *’ but argument is of type ‘const char *’
34 | extern char*__xpg_basename(char*__path)__THROW;[...]
Here is the summary with links:
- [iproute2] bpf: fix warning from basename()
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=69e3b2fadcd3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html