Skip to contentSkip to conversation

virtio-net: support setting coalescing params for multiple vqs

PATCH In review Heng Qi 2 participants 6 messages Jan 30, 2024 – Jan 31, 2024

lore
Share & tools
lore

Heng Qi

author
#0 lore raw

PATCH v3 1/1 virtio-net: support setting coalescing params for multiple vqs

Currently, when each time the driver attempts to update the coalescing parameters for a vq, it needs to kick the device and wait for the ctrlq response to return. The following path is observed: 1. Driver kicks the device; 2. After the device receives the kick, CPU scheduling occurs and DMA multiple buffers multiple times;
3. The device completes processing and replies with a response.

Since Linux ctrlq currently cannot add commands in batches, it can only process one request synchronously at a time.
When a large-queue driver want to issue multiple requests, the subsequent request must wait for the previous request to be processed before it can be sent:
1. The driver kicks the device frequently, this often interrupt the work of the device-side CPU. In addition, each vq request
2. Each request is pipelined and there can always be only one request in the pipeline, causing more delays for the device-side CPU to wait for the DMA request to complete.

These interruptions and overhead will strain the CPU responsible for controlling the path of the DPU, especially in multi-device and large-queue scenarios.

To solve the above problems, we internally tried batch request, which merges requests from multiple queues and sends them at once. We conservatively tested 8 queue commands and sent them together. The DPU processing efficiency can be improved by 8 times, which greatly eases the DPU's support for multi-device and multi-queue DIM.

---
v2->v3:
1. Update some descriptions. @ Michael
2. virtio_net_ctrl_mrg_coal_vq -> virtnet_ctrl_mrg_coal_vq
3. Reword the commit log.

v1->v2: Updated commit log. Due to sensitivity, sorry that can not give the
absolute value directly. @Michael

 device-types/net/description.tex | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)
device-types/net/description.tex +22 -6
index aff5e08..dbca203 100644
@@ -1667,8 +1667,8 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 for notification coalescing.
 
 If the VIRTIO_NET_F_VQ_NOTF_COAL feature is negotiated, the driver can
-send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET
-for virtqueue notification coalescing.
+send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and
+VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET for virtqueue notification coalescing.
 
 \begin{lstlisting}
 struct virtio_net_ctrl_coal {
@@ -1682,11 +1682,17 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
     struct virtio_net_ctrl_coal coal;
 };
 
+struct virtnet_ctrl_mrg_coal_vq {
+        le16 num_entries; /* indicates number of valid entries */
+        struct virtio_net_ctrl_coal_vq entries[];
+};
+
 #define VIRTIO_NET_CTRL_NOTF_COAL 6
  #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET  0
  #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
  #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2
  #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3
+ #define VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET 4
 \end{lstlisting}
 
 Coalescing parameters:
@@ -1706,6 +1712,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 \item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, the structure virtio_net_ctrl_coal_vq is write-only for the driver.
 \item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET, \field{vq_index} and \field{reserved} are write-only
       for the driver, and the structure virtio_net_ctrl_coal is read-only for the driver.
+\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET, the structure virtnet_ctrl_mrg_coal_vq is write-only for the driver.
 \end{itemize}
 
 The class VIRTIO_NET_CTRL_NOTF_COAL has the following commands:
@@ -1716,6 +1723,9 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
                                         for an enabled transmit/receive virtqueue whose index is \field{vq_index}.
 \item VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET: use the structure virtio_net_ctrl_coal_vq to get the \field{max_usecs} and \field{max_packets} parameters
                                         for an enabled transmit/receive virtqueue whose index is \field{vq_index}.
+\item VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET: use the structure virtnet_ctrl_mrg_coal_vq to set the \field{max_usecs} and \field{max_packets} parameters
+                                         for \field{num_entries} enabled transmit/receive virtqueues. The corresponding index value
+                                         of each configured virtqueue is \field{vq_index}.
 \end{enumerate}
 
 The device may generate notifications more or less frequently than specified by set commands of the VIRTIO_NET_CTRL_NOTF_COAL class.
@@ -1782,9 +1792,13 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 
 The driver MUST set \field{vq_index} to the virtqueue index of an enabled transmit or receive virtqueue.
 
+The driver MUST set \field{num_entries} to a non-zero value and MUST NOT set \field{num_entries} to
+a value greater than the number of enabled transmit and receive virtqueues.
+
 The driver MUST have negotiated the VIRTIO_NET_F_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET.
 
-The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
+The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands
+VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
 
 The driver MUST ignore the values of coalescing parameters received from the VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET command if the device responds with VIRTIO_NET_ERR.
 
@@ -1794,10 +1808,12 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 
 The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
 
-The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET
+commands with VIRTIO_NET_ERR if it was not able to change some of the coalescing parameters. In
+this case, all of the parameters MUST remain unchanged, for all virtqueues.
 
-The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with
-VIRTIO_NET_ERR if the designated virtqueue is not an enabled transmit or receive virtqueue.
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET
+commands with VIRTIO_NET_ERR if the designated virtqueue is not an enabled transmit or receive virtqueue.
 
 Upon disabling and re-enabling a transmit virtqueue, the device MUST set the coalescing parameters of the virtqueue
 to those configured through the VIRTIO_NET_CTRL_NOTF_COAL_TX_SET command, or, if the driver did not set any TX coalescing parameters, to 0.
Signature · 18 lines
1.8.3.1


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
#1 lore raw

Hi Heng,

Quoted 16 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 10:15 AM
To: [email protected]
Cc: Jason Wang <[email protected]>; Michael S. Tsirkin <[email protected]>; Xuan Zhuo <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH v3] virtio-net: support setting coalescing params for multiple vqs

Currently, when each time the driver attempts to update the coalescing parameters for a vq, it needs to kick the device and wait for the ctrlq response to return.
The following path is observed: 1. Driver kicks the device; 2. After the device receives the kick, CPU scheduling occurs and DMA multiple buffers multiple times; 3. The device completes processing and replies with a response.

Quoted 2 lines

Since Linux ctrlq currently cannot add commands in batches, it can only process one request synchronously at a time.

It can. Please refactor the kernel code to not depend on OS global rtnl lock. This cannot be the motivation for spec patch discussed in v2 time.

Quoted 9 lines

When a large-queue driver want to issue multiple requests, the subsequent request must wait for the previous request to be processed before it can be sent:
1. The driver kicks the device frequently, this often interrupt the work of the device-side CPU. In addition, each vq request
2. Each request is pipelined and there can always be only one request in the pipeline, causing more delays for the device-side CPU to wait for the DMA request to complete.

Quoted 4 lines

These interruptions and overhead will strain the CPU responsible for controlling the path of the DPU, especially in multi-device and large-queue scenarios.

Please remove above line as you acked below that those driver notifications are ignored by the device in [1].

[1] https://lists.oasis-open.org/archives/virtio-comment/202401/msg00132.html

Quoted 43 lines

To solve the above problems, we internally tried batch request, which merges requests from multiple queues and sends them at once. We conservatively tested
8 queue commands and sent them together. The DPU processing efficiency can be improved by 8 times, which greatly eases the DPU's support for multi- device and multi-queue DIM.

---
v2->v3:
1. Update some descriptions. @ Michael
2. virtio_net_ctrl_mrg_coal_vq -> virtnet_ctrl_mrg_coal_vq
3. Reword the commit log.

v1->v2: Updated commit log. Due to sensitivity, sorry that can not give v1->the
absolute value directly. @Michael

 device-types/net/description.tex | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)
device- renamed from device-types/net/description.tex +0 -0

types/net/description.tex
index aff5e08..dbca203 100644

device-types/net/description.tex +0 -0
@@ -1667,8 +1667,8 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi for notification coalescing.

If the VIRTIO_NET_F_VQ_NOTF_COAL feature is negotiated, the driver can -
send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET -for virtqueue notification coalescing.

device-types/net/description.tex +2 -0
+send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET for virtqueue notification coalescing.

\begin{lstlisting}
struct virtio_net_ctrl_coal {

device-types/net/description.tex +0 -0
@@ -1682,11 +1682,17 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

Quoted 4 lines
     struct virtio_net_ctrl_coal coal;

};

+struct virtnet_ctrl_mrg_coal_vq {

Since this doing at batch level, ctrl_coal_vq_batch or ctrl_coal_vqs_batch seems better name.

device-types/net/description.tex \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi · line 1695

Quoted 9 lines
device-types/net/description.tex +4 -0
+        le16 num_entries; /* indicates number of valid entries */
+        struct virtio_net_ctrl_coal_vq entries[]; };
+
 #define VIRTIO_NET_CTRL_NOTF_COAL 6
  #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET  0
  #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
  #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2
  #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3
+ #define VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET 4

A new feature bit is needed as the driver does not know if all the devices support this command or not.
For example, some device does not support VQS_SET command.
The device is already out that supports notification features per VQ (without coalescing support) and does not plan to support coalescing because OS level enqueue command is optimal for it like rest of the tx and rx q.

Quoted 85 lines

\end{lstlisting}

Coalescing parameters:

device-types/net/description.tex +0 -0
@@ -1706,6 +1712,7 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi \item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, the structure virtio_net_ctrl_coal_vq is write-only for the driver.
\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET,
\field{vq_index} and \field{reserved} are write-only
for the driver, and the structure virtio_net_ctrl_coal is read-only for the
driver.
+\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET, the structure virtnet_ctrl_mrg_coal_vq is write-only for the driver.
\end{itemize}

The class VIRTIO_NET_CTRL_NOTF_COAL has the following commands:

device-types/net/description.tex +0 -0
@@ -1716,6 +1723,9 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi
for an enabled transmit/receive virtqueue whose index is
\field{vq_index}.
\item VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET: use the structure
virtio_net_ctrl_coal_vq to get the \field{max_usecs} and \field{max_packets} parameters
for an enabled transmit/receive virtqueue whose index is
\field{vq_index}.
+\item VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET: use the structure virtnet_ctrl_mrg_coal_vq to set the \field{max_usecs} and \field{max_packets} parameters
+ for \field{num_entries} enabled transmit/receive
virtqueues. The corresponding index value
+ of each configured virtqueue is \field{vq_index}.
\end{enumerate}

The device may generate notifications more or less frequently than specified
by set commands of the VIRTIO_NET_CTRL_NOTF_COAL class.

device-types/net/description.tex +0 -0
@@ -1782,9 +1792,13 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The driver MUST set \field{vq_index} to the virtqueue index of an enabled
transmit or receive virtqueue.

device-types/net/description.tex +2 -0
+The driver MUST set \field{num_entries} to a non-zero value and MUST
+NOT set \field{num_entries} to a value greater than the number of enabled

transmit and receive virtqueues.
+
The driver MUST have negotiated the VIRTIO_NET_F_NOTF_COAL feature
when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET.

-The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
+The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature
+when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.

The driver MUST ignore the values of coalescing parameters received from the
VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET command if the device responds with VIRTIO_NET_ERR.

device-types/net/description.tex +0 -0
@@ -1794,10 +1808,12 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.

-The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET commands with VIRTIO_NET_ERR

if it
+was not able to change some of the coalescing parameters. In this case, all of the parameters MUST remain unchanged, for all virtqueues.

-The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with -VIRTIO_NET_ERR if the designated virtqueue is not an enabled transmit or receive virtqueue.

device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with VIRTIO_NET_ERR if the designated virtqueue is not an enabled transmit or receive virtqueue.

Quoted 6 lines

Upon disabling and re-enabling a transmit virtqueue, the device MUST set the
coalescing parameters of the virtqueue to those configured through the VIRTIO_NET_CTRL_NOTF_COAL_TX_SET command, or, if the driver did not set any TX coalescing parameters, to 0.
--
1.8.3.1

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

author
#2 lore raw
Quoted 18 lines · Parav Pandit

Hi Heng,

Quoted 16 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 10:15 AM
To: [email protected]
Cc: Jason Wang <[email protected]>; Michael S. Tsirkin <[email protected]>; Xuan Zhuo <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH v3] virtio-net: support setting coalescing params for multiple vqs

Currently, when each time the driver attempts to update the coalescing parameters for a vq, it needs to kick the device and wait for the ctrlq response to return.
The following path is observed: 1. Driver kicks the device; 2. After the device receives the kick, CPU scheduling occurs and DMA multiple buffers multiple times; 3. The device completes processing and replies with a response.

Quoted 4 lines
Quoted 2 lines

Since Linux ctrlq currently cannot add commands in batches, it can only process one request synchronously at a time.

It can. Please refactor the kernel code to not depend on OS global rtnl lock. This cannot be the motivation for spec patch discussed in v2 time.

Hi Parav,

I don't think this is related to the OS global rtnl_lock. The purpose of removing rtnl_lock is to better support multi-nics OS. I think you're referring to having controlq handle things asynchronously (e.g. batch add commands), and if asynchronous handling is solved, yes, the "kicks" motivation needs to be removed. The remaining motivation is that the device CPU needs to frequently wait for each requested DMA to complete. The more requests there are, the less efficient the device responds.

Quoted 10 lines
Quoted 10 lines

When a large-queue driver want to issue multiple requests, the subsequent request must wait for the previous request to be processed before it can be sent:
1. The driver kicks the device frequently, this often interrupt the work of the device-side CPU. In addition, each vq request
2. Each request is pipelined and there can always be only one request in the pipeline, causing more delays for the device-side CPU to wait for the DMA request to complete.

Quoted 7 lines
Quoted 4 lines

These interruptions and overhead will strain the CPU responsible for controlling the path of the DPU, especially in multi-device and large-queue scenarios.

Please remove above line as you acked below that those driver notifications are ignored by the device in [1].

[1] https://lists.oasis-open.org/archives/virtio-comment/202401/msg00132.html

Please see the above reply.

Quoted 47 lines
Quoted 47 lines

To solve the above problems, we internally tried batch request, which merges requests from multiple queues and sends them at once. We conservatively tested
8 queue commands and sent them together. The DPU processing efficiency can be improved by 8 times, which greatly eases the DPU's support for multi- device and multi-queue DIM.

---
v2->v3:
1. Update some descriptions. @ Michael
2. virtio_net_ctrl_mrg_coal_vq -> virtnet_ctrl_mrg_coal_vq
3. Reword the commit log.

v1->v2: Updated commit log. Due to sensitivity, sorry that can not give v1->the
absolute value directly. @Michael

  device-types/net/description.tex | 28 ++++++++++++++++++++++------
  1 file changed, 22 insertions(+), 6 deletions(-)
device- renamed from device-types/net/description.tex +0 -0

types/net/description.tex
index aff5e08..dbca203 100644

device-types/net/description.tex +0 -0
@@ -1667,8 +1667,8 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi for notification coalescing.

If the VIRTIO_NET_F_VQ_NOTF_COAL feature is negotiated, the driver can -
send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET -for virtqueue notification coalescing.

device-types/net/description.tex +2 -0
+send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET for virtqueue notification coalescing.

  \begin{lstlisting}
  struct virtio_net_ctrl_coal {
device-types/net/description.tex +0 -0
@@ -1682,11 +1682,17 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

      struct virtio_net_ctrl_coal coal;

};

Quoted 2 lines
Quoted 1 line

+struct virtnet_ctrl_mrg_coal_vq {

Since this doing at batch level, ctrl_coal_vq_batch or ctrl_coal_vqs_batch seems better name.

OK. It's a better name.

Quoted 11 lines

device-types/net/description.tex \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi · line 1695

Quoted 10 lines
device-types/net/description.tex +4 -0
+        le16 num_entries; /* indicates number of valid entries */
+        struct virtio_net_ctrl_coal_vq entries[]; };
+
  #define VIRTIO_NET_CTRL_NOTF_COAL 6
   #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET  0
   #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
   #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2
   #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3
+ #define VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET 4

A new feature bit is needed as the driver does not know if all the devices support this command or not.

Well, 1.3 is still not released, if the device wants to support dim better, they should update the device. Then if you suggest a new feature bit, I will add it in the next version.

Quoted 2 lines

For example, some device does not support VQS_SET command.
The device is already out that supports notification features per VQ (without coalescing support) and does not plan to support coalescing because OS level enqueue command is optimal for it like rest of the tx and rx q.

Even though ctrlq can do like txq/rxq, for example 256 requests are batched, so the device only needs to process a single request, which is friendly to device. Then it can effectively handle requests from other VMs, perform software forwarding, etc.

Thanks,
Heng

Quoted 100 lines
Quoted 86 lines

\end{lstlisting}

Coalescing parameters:

device-types/net/description.tex +0 -0
@@ -1706,6 +1712,7 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi \item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, the structure virtio_net_ctrl_coal_vq is write-only for the driver.
\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET,
\field{vq_index} and \field{reserved} are write-only
for the driver, and the structure virtio_net_ctrl_coal is read-only for the
driver.
+\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET, the structure virtnet_ctrl_mrg_coal_vq is write-only for the driver.
\end{itemize}

The class VIRTIO_NET_CTRL_NOTF_COAL has the following commands:

device-types/net/description.tex +0 -0
@@ -1716,6 +1723,9 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi
for an enabled transmit/receive virtqueue whose index is
\field{vq_index}.
\item VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET: use the structure
virtio_net_ctrl_coal_vq to get the \field{max_usecs} and \field{max_packets} parameters
for an enabled transmit/receive virtqueue whose index is
\field{vq_index}.
+\item VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET: use the structure virtnet_ctrl_mrg_coal_vq to set the \field{max_usecs} and \field{max_packets} parameters
+ for \field{num_entries} enabled transmit/receive
virtqueues. The corresponding index value
+ of each configured virtqueue is \field{vq_index}.
\end{enumerate}

The device may generate notifications more or less frequently than specified
by set commands of the VIRTIO_NET_CTRL_NOTF_COAL class.

device-types/net/description.tex +0 -0
@@ -1782,9 +1792,13 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The driver MUST set \field{vq_index} to the virtqueue index of an enabled
transmit or receive virtqueue.

device-types/net/description.tex +2 -0
+The driver MUST set \field{num_entries} to a non-zero value and MUST
+NOT set \field{num_entries} to a value greater than the number of enabled

transmit and receive virtqueues.
+
The driver MUST have negotiated the VIRTIO_NET_F_NOTF_COAL feature
when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET.

-The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
+The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature
+when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.

The driver MUST ignore the values of coalescing parameters received from the
VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET command if the device responds with VIRTIO_NET_ERR.

device-types/net/description.tex +0 -0
@@ -1794,10 +1808,12 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.

-The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.

device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET commands with VIRTIO_NET_ERR

if it
+was not able to change some of the coalescing parameters. In this case, all of the parameters MUST remain unchanged, for all virtqueues.

-The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with -VIRTIO_NET_ERR if the designated virtqueue is not an enabled transmit or receive virtqueue.

device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with VIRTIO_NET_ERR if the designated virtqueue is not an enabled transmit or receive virtqueue.

Quoted 6 lines

Upon disabling and re-enabling a transmit virtqueue, the device MUST set the
coalescing parameters of the virtqueue to those configured through the VIRTIO_NET_CTRL_NOTF_COAL_TX_SET command, or, if the driver did not set any TX coalescing parameters, to 0.
--
1.8.3.1

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Quoted 8 lines

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#3 lore raw
Quoted 26 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 12:06 PM

Quoted 17 lines · Parav Pandit

Hi Heng,

Quoted 15 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 10:15 AM
To: [email protected]
Cc: Jason Wang <[email protected]>; Michael S. Tsirkin <[email protected]>; Xuan Zhuo <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH v3] virtio-net: support setting coalescing params for multiple vqs

Currently, when each time the driver attempts to update the coalescing parameters for a vq, it needs to kick the device and wait for the ctrlq response to return.
The following path is observed: 1. Driver kicks the device; 2. After the device receives the kick, CPU scheduling occurs and DMA multiple buffers multiple times; 3. The device completes processing and replies with

a response.

Quoted 3 lines
Quoted 3 lines

Since Linux ctrlq currently cannot add commands in batches, it can only process one request synchronously at a time.

Quoted 7 lines
Quoted 2 lines

It can. Please refactor the kernel code to not depend on OS global rtnl lock. This cannot be the motivation for spec patch discussed in v2 time.

Hi Parav,

I don't think this is related to the OS global rtnl_lock. The purpose of removing rtnl_lock is to better support multi-nics OS.

Even for single NIC if one holds rtnl lock to synchronously issue cvq commands it is wrong. And using try_lock sort of thing is just a plain hack to identify if one is using cvq or not.

Quoted 1 line

I think you're referring to having controlq handle things asynchronously

Async yes, with and without batch.

Quoted 5 lines

(e.g.
batch add commands), and if asynchronous handling is solved, yes, the "kicks" motivation needs to be removed. The remaining motivation is that the device CPU needs to frequently wait for each requested DMA to complete. The more requests there are, the less efficient the device responds.

And if the descriptors are arranged contiguously even for the split q, the dma are less.

I like to explicitly clarify that I am not again the batch mode.
I want to say that once you get rid of the rtnl kind of implementation and also do async commands, the performance gain from the batch will not be noticeable. Interrupt moderation is low latency operation that does not need to wait for accumulating in the batch.

Quoted 90 lines
Quoted 9 lines
Quoted 9 lines

When a large-queue driver want to issue multiple requests, the subsequent request must wait for the previous request to be processed before it can be
sent:
1. The driver kicks the device frequently, this often interrupt the work of the device-side CPU. In addition, each vq request
2. Each request is pipelined and there can always be only one request in

the

Quoted 1 line
Quoted 1 line

pipeline, causing more delays for the device-side CPU to wait for the

DMA

Quoted 7 lines
Quoted 6 lines

request to complete.

These interruptions and overhead will strain the CPU responsible for controlling the path of the DPU, especially in multi-device and large-queue scenarios.

Please remove above line as you acked below that those driver notifications

are ignored by the device in [1].

Quoted 4 lines

[1]
https://lists.oasis-open.org/archives/virtio-comment/202401/msg00132.h
tml

Please see the above reply.

Quoted 31 lines
Quoted 31 lines

To solve the above problems, we internally tried batch request, which merges requests from multiple queues and sends them at once. We conservatively tested
8 queue commands and sent them together. The DPU processing efficiency can be improved by 8 times, which greatly eases the DPU's support for multi- device and multi-queue DIM.

---
v2->v3:
1. Update some descriptions. @ Michael
2. virtio_net_ctrl_mrg_coal_vq -> virtnet_ctrl_mrg_coal_vq
3. Reword the commit log.

v1->v2: Updated commit log. Due to sensitivity, sorry that can not v1->give the
absolute value directly. @Michael

  device-types/net/description.tex | 28 ++++++++++++++++++++++------
  1 file changed, 22 insertions(+), 6 deletions(-)
device- renamed from device-types/net/description.tex +0 -0

types/net/description.tex index aff5e08..dbca203 100644

device-types/net/description.tex +0 -0
@@ -1667,8 +1667,8 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi for notification coalescing.

Quoted 7 lines
Quoted 7 lines

If the VIRTIO_NET_F_VQ_NOTF_COAL feature is negotiated, the driver
can - send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET -for virtqueue notification coalescing.

device-types/net/description.tex +2 -0
+send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET for virtqueue notification

coalescing.

Quoted 10 lines
Quoted 9 lines
  \begin{lstlisting}
  struct virtio_net_ctrl_coal {
device-types/net/description.tex +0 -0
@@ -1682,11 +1682,17 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

      struct virtio_net_ctrl_coal coal;

};

+struct virtnet_ctrl_mrg_coal_vq {

Since this doing at batch level, ctrl_coal_vq_batch or ctrl_coal_vqs_batch

seems better name.

OK. It's a better name.

Quoted 10 lines
Quoted 10 lines
device-types/net/description.tex +4 -0
+        le16 num_entries; /* indicates number of valid entries */
+        struct virtio_net_ctrl_coal_vq entries[]; };
+
  #define VIRTIO_NET_CTRL_NOTF_COAL 6
   #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET  0
   #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
   #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2
   #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3
+ #define VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET 4
Quoted 5 lines
Quoted 1 line

A new feature bit is needed as the driver does not know if all the devices

support this command or not.

Well, 1.3 is still not released, if the device wants to support dim better, they should update the device.

It can but the driver does not know if it supports or not.
So it tries and fails on the device that does not support.
1.3 is supposed to be released by now. It is stuck on unrelated OASIS infrastructure update.

Quoted 4 lines

Then if you suggest a new feature bit, I will add it in the next version.

Quoted 2 lines

For example, some device does not support VQS_SET command.
The device is already out that supports notification features per VQ (without

Quoted 8 lines

coalescing support) and does not plan to support coalescing because OS level enqueue command is optimal for it like rest of the tx and rx q.

Even though ctrlq can do like txq/rxq, for example 256 requests are batched, so the device only needs to process a single request, which is friendly to device. Then it can effectively handle requests from other VMs, perform software forwarding, etc.

Yes. I understand.
I just don’t think the gain with be 8x once the proper sw (= async and without rtnl lock is written that enqueues the cmd). So request is for the commit log updates to detach commit log from this sw inefficiency details.

Quoted 124 lines

Thanks,
Heng

Quoted 52 lines
Quoted 52 lines

\end{lstlisting}

Coalescing parameters:

device-types/net/description.tex +0 -0
@@ -1706,6 +1712,7 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi \item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, the structure virtio_net_ctrl_coal_vq is write-only for the driver.
\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET,
\field{vq_index} and \field{reserved} are write-only
for the driver, and the structure virtio_net_ctrl_coal is
read-only for the driver.
+\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET, the structure virtnet_ctrl_mrg_coal_vq is write-only for the driver.
\end{itemize}

The class VIRTIO_NET_CTRL_NOTF_COAL has the following commands:

device-types/net/description.tex +0 -0
@@ -1716,6 +1723,9 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi
for an enabled
transmit/receive virtqueue whose index is \field{vq_index}.
\item VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET: use the structure
virtio_net_ctrl_coal_vq to get the \field{max_usecs} and \field{max_packets} parameters
for an enabled
transmit/receive virtqueue whose index is \field{vq_index}. +\item VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET: use the structure virtnet_ctrl_mrg_coal_vq to set the \field{max_usecs} and \field{max_packets} parameters
+ for \field{num_entries}
+ enabled transmit/receive
virtqueues. The corresponding index value
+ of each configured virtqueue is \field{vq_index}.
\end{enumerate}

The device may generate notifications more or less frequently than
specified by set commands of the VIRTIO_NET_CTRL_NOTF_COAL class.

device-types/net/description.tex +0 -0
@@ -1782,9 +1792,13 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The driver MUST set \field{vq_index} to the virtqueue index of an
enabled transmit or receive virtqueue.

device-types/net/description.tex +3 -0
+The driver MUST set \field{num_entries} to a non-zero value and MUST
+NOT set \field{num_entries} to a value greater than the number of
+enabled

transmit and receive virtqueues.
+
The driver MUST have negotiated the VIRTIO_NET_F_NOTF_COAL feature
when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET.

Quoted 2 lines
Quoted 2 lines

-The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET

and

Quoted 7 lines
Quoted 7 lines

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
+The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature
+when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.

Quoted 8 lines
Quoted 8 lines

The driver MUST ignore the values of coalescing parameters received
from the VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET command if the device responds with VIRTIO_NET_ERR.

device-types/net/description.tex +0 -0
@@ -1794,10 +1808,12 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET

and

Quoted 1 line
Quoted 1 line

VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR

if it

Quoted 4 lines
Quoted 4 lines

was not able to change the parameters.

-The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the

parameters.

Quoted 2 lines

device-types/net/description.tex

Quoted 2 lines
device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET commands with

VIRTIO_NET_ERR

Quoted 7 lines
Quoted 7 lines

if it

device-types/net/description.tex +2 -0
+was not able to change some of the coalescing parameters. In this
+case, all of

the parameters MUST remain unchanged, for all virtqueues.

-The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with -

VIRTIO_NET_ERR if the

Quoted 4 lines
Quoted 4 lines

designated virtqueue is not an enabled transmit or receive virtqueue.

device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with VIRTIO_NET_ERR

if the

Quoted 5 lines
Quoted 5 lines

designated virtqueue is not an enabled transmit or receive virtqueue.

Upon disabling and re-enabling a transmit virtqueue, the device
MUST set the coalescing parameters of the virtqueue to those configured through the VIRTIO_NET_CTRL_NOTF_COAL_TX_SET command,

or,

Quoted 21 lines
Quoted 3 lines

if the driver did not set any TX coalescing parameters, to 0. --
1.8.3.1

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected] List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License:
https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines:
https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

author
#4 lore raw
Quoted 24 lines · Parav Pandit
Quoted 24 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 12:06 PM

Quoted 17 lines · Parav Pandit

Hi Heng,

Quoted 15 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 10:15 AM
To: [email protected]
Cc: Jason Wang <[email protected]>; Michael S. Tsirkin <[email protected]>; Xuan Zhuo <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH v3] virtio-net: support setting coalescing params for multiple vqs

Currently, when each time the driver attempts to update the coalescing parameters for a vq, it needs to kick the device and wait for the ctrlq response to return.
The following path is observed: 1. Driver kicks the device; 2. After the device receives the kick, CPU scheduling occurs and DMA multiple buffers multiple times; 3. The device completes processing and replies with

a response.

Quoted 2 lines
Quoted 2 lines

Since Linux ctrlq currently cannot add commands in batches, it can only process one request synchronously at a time.

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

It can. Please refactor the kernel code to not depend on OS global rtnl lock. This cannot be the motivation for spec patch discussed in v2 time.

Hi Parav,

I don't think this is related to the OS global rtnl_lock. The purpose of removing rtnl_lock is to better support multi-nics OS.

Even for single NIC if one holds rtnl lock to synchronously issue cvq commands it is wrong.

Yes, I agree with this.

Quoted 1 line

And using try_lock sort of thing is just a plain hack to identify if one is using cvq or not.

It's a compromise.
But I want to say sorry, the transformation of rtnl_lock does not appear in my list for the time being. Would like to see if anyone else takes this forward. :)

Quoted 3 lines
Quoted 2 lines

I think you're referring to having controlq handle things asynchronously

Async yes, with and without batch.

YES.

Quoted 10 lines
Quoted 6 lines

(e.g.
batch add commands), and if asynchronous handling is solved, yes, the "kicks" motivation needs to be removed. The remaining motivation is that the device CPU needs to frequently wait for each requested DMA to complete. The more requests there are, the less efficient the device responds.

And if the descriptors are arranged contiguously even for the split q, the dma are less.

I like to explicitly clarify that I am not again the batch mode.
I want to say that once you get rid of the rtnl kind of implementation and also do async commands, the performance gain from the batch will not be noticeable.

We did tests and found that even though the async of the dim command has been added, the device(the backend components) still hopes to reduce the pressure in batch mode.

Our dpu's cvq is sw-simulated, and the CPU responsible for handling cvq requests has a lot of extra work, such as forwarding, security, etc. So efficiency is need.

Quoted 1 line

Interrupt moderation is low latency operation that does not need to wait for accumulating in the batch.

We don't need to wait continuously, just accumulate requests that already have update requirements.

Quoted 83 lines
Quoted 83 lines
Quoted 7 lines
Quoted 7 lines

When a large-queue driver want to issue multiple requests, the subsequent request must wait for the previous request to be processed before it can be
sent:
1. The driver kicks the device frequently, this often interrupt the work of the device-side CPU. In addition, each vq request
2. Each request is pipelined and there can always be only one request in

the

Quoted 1 line
Quoted 1 line

pipeline, causing more delays for the device-side CPU to wait for the

DMA

Quoted 7 lines
Quoted 6 lines

request to complete.

These interruptions and overhead will strain the CPU responsible for controlling the path of the DPU, especially in multi-device and large-queue scenarios.

Please remove above line as you acked below that those driver notifications

are ignored by the device in [1].

Quoted 3 lines

[1]
https://lists.oasis-open.org/archives/virtio-comment/202401/msg00132.h
tml

Please see the above reply.

Quoted 30 lines
Quoted 30 lines

To solve the above problems, we internally tried batch request, which merges requests from multiple queues and sends them at once. We conservatively tested
8 queue commands and sent them together. The DPU processing efficiency can be improved by 8 times, which greatly eases the DPU's support for multi- device and multi-queue DIM.

---
v2->v3:
1. Update some descriptions. @ Michael
2. virtio_net_ctrl_mrg_coal_vq -> virtnet_ctrl_mrg_coal_vq
3. Reword the commit log.

v1->v2: Updated commit log. Due to sensitivity, sorry that can not v1->give the
absolute value directly. @Michael

   device-types/net/description.tex | 28 ++++++++++++++++++++++------
   1 file changed, 22 insertions(+), 6 deletions(-)
device- renamed from device-types/net/description.tex +0 -0

types/net/description.tex index aff5e08..dbca203 100644

device-types/net/description.tex +0 -0
@@ -1667,8 +1667,8 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi for notification coalescing.

Quoted 7 lines
Quoted 7 lines

If the VIRTIO_NET_F_VQ_NOTF_COAL feature is negotiated, the driver
can - send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET -for virtqueue notification coalescing.

device-types/net/description.tex +2 -0
+send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET for virtqueue notification

coalescing.

Quoted 9 lines
Quoted 8 lines
   \begin{lstlisting}
   struct virtio_net_ctrl_coal {
device-types/net/description.tex +0 -0
@@ -1682,11 +1682,17 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

       struct virtio_net_ctrl_coal coal;

};

+struct virtnet_ctrl_mrg_coal_vq {

Since this doing at batch level, ctrl_coal_vq_batch or ctrl_coal_vqs_batch

seems better name.

OK. It's a better name.

Quoted 9 lines
Quoted 9 lines
device-types/net/description.tex +4 -0
+        le16 num_entries; /* indicates number of valid entries */
+        struct virtio_net_ctrl_coal_vq entries[]; };
+
   #define VIRTIO_NET_CTRL_NOTF_COAL 6
    #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET  0
    #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
    #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2
    #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3
+ #define VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET 4
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

A new feature bit is needed as the driver does not know if all the devices

support this command or not.

Well, 1.3 is still not released, if the device wants to support dim better, they should update the device.

It can but the driver does not know if it supports or not.
So it tries and fails on the device that does not support.
1.3 is supposed to be released by now. It is stuck on unrelated OASIS infrastructure update.

Will add a new feature bit.

Quoted 8 lines
Quoted 8 lines

Then if you suggest a new feature bit, I will add it in the next version.

Quoted 2 lines

For example, some device does not support VQS_SET command.
The device is already out that supports notification features per VQ (without

coalescing support) and does not plan to support coalescing because OS level enqueue command is optimal for it like rest of the tx and rx q.

Quoted 8 lines
Quoted 5 lines

Even though ctrlq can do like txq/rxq, for example 256 requests are batched, so the device only needs to process a single request, which is friendly to device. Then it can effectively handle requests from other VMs, perform software forwarding, etc.

Yes. I understand.
I just don’t think the gain with be 8x once the proper sw (= async and without rtnl lock is written that enqueues the cmd). So request is for the commit log updates to detach commit log from this sw inefficiency details.

Will update this.

Thanks,
Heng

Quoted 109 lines
Quoted 109 lines
Quoted 51 lines
Quoted 51 lines
   \end{lstlisting}

   Coalescing parameters:
device-types/net/description.tex +0 -0
@@ -1706,6 +1712,7 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi \item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, the structure virtio_net_ctrl_coal_vq is write-only for the driver.
\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET,
\field{vq_index} and \field{reserved} are write-only
for the driver, and the structure virtio_net_ctrl_coal is
read-only for the driver.
+\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET, the structure virtnet_ctrl_mrg_coal_vq is write-only for the driver.
\end{itemize}

The class VIRTIO_NET_CTRL_NOTF_COAL has the following commands:

device-types/net/description.tex +0 -0
@@ -1716,6 +1723,9 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi
for an enabled
transmit/receive virtqueue whose index is \field{vq_index}.
\item VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET: use the structure
virtio_net_ctrl_coal_vq to get the \field{max_usecs} and \field{max_packets} parameters
for an enabled
transmit/receive virtqueue whose index is \field{vq_index}. +\item VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET: use the structure virtnet_ctrl_mrg_coal_vq to set the \field{max_usecs} and \field{max_packets} parameters
+ for \field{num_entries}
+ enabled transmit/receive
virtqueues. The corresponding index value
+ of each configured virtqueue is \field{vq_index}.
\end{enumerate}

The device may generate notifications more or less frequently than
specified by set commands of the VIRTIO_NET_CTRL_NOTF_COAL class.

device-types/net/description.tex +0 -0
@@ -1782,9 +1792,13 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The driver MUST set \field{vq_index} to the virtqueue index of an
enabled transmit or receive virtqueue.

device-types/net/description.tex +3 -0
+The driver MUST set \field{num_entries} to a non-zero value and MUST
+NOT set \field{num_entries} to a value greater than the number of
+enabled

transmit and receive virtqueues.
+
The driver MUST have negotiated the VIRTIO_NET_F_NOTF_COAL feature
when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET.

Quoted 2 lines
Quoted 2 lines

-The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET

and

Quoted 7 lines
Quoted 7 lines

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
+The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature
+when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.

Quoted 8 lines
Quoted 8 lines

The driver MUST ignore the values of coalescing parameters received
from the VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET command if the device responds with VIRTIO_NET_ERR.

device-types/net/description.tex +0 -0
@@ -1794,10 +1808,12 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET

and

Quoted 1 line
Quoted 1 line

VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR

if it

Quoted 4 lines
Quoted 4 lines

was not able to change the parameters.

-The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the

parameters.

Quoted 2 lines

device-types/net/description.tex

Quoted 2 lines
device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET commands with

VIRTIO_NET_ERR

Quoted 7 lines
Quoted 7 lines

if it

device-types/net/description.tex +2 -0
+was not able to change some of the coalescing parameters. In this
+case, all of

the parameters MUST remain unchanged, for all virtqueues.

-The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with -

VIRTIO_NET_ERR if the

Quoted 4 lines
Quoted 4 lines

designated virtqueue is not an enabled transmit or receive virtqueue.

device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with VIRTIO_NET_ERR

if the

Quoted 5 lines
Quoted 5 lines

designated virtqueue is not an enabled transmit or receive virtqueue.

Upon disabling and re-enabling a transmit virtqueue, the device
MUST set the coalescing parameters of the virtqueue to those configured through the VIRTIO_NET_CTRL_NOTF_COAL_TX_SET command,

or,

Quoted 10 lines
Quoted 3 lines

if the driver did not set any TX coalescing parameters, to 0. --
1.8.3.1

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Subscribe: [email protected]
Unsubscribe: [email protected] List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License:
https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines:
https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#5 lore raw
Quoted 41 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 2:19 PM

Quoted 25 lines · Parav Pandit
Quoted 25 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 12:06 PM

Quoted 18 lines · Parav Pandit

Hi Heng,

Quoted 16 lines

From: Heng Qi <[email protected]>
Sent: Tuesday, January 30, 2024 10:15 AM
To: [email protected]
Cc: Jason Wang <[email protected]>; Michael S. Tsirkin <[email protected]>; Xuan Zhuo <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH v3] virtio-net: support setting coalescing params for multiple vqs

Currently, when each time the driver attempts to update the coalescing parameters for a vq, it needs to kick the device and wait for the ctrlq response to return.
The following path is observed: 1. Driver kicks the device; 2. After the device receives the kick, CPU scheduling occurs and DMA multiple buffers multiple times; 3. The device completes processing and replies with

a response.

Quoted 2 lines
Quoted 2 lines

Since Linux ctrlq currently cannot add commands in batches, it can only process one request synchronously at a time.

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

It can. Please refactor the kernel code to not depend on OS global rtnl lock. This cannot be the motivation for spec patch discussed in v2 time.

Hi Parav,

I don't think this is related to the OS global rtnl_lock. The purpose of removing rtnl_lock is to better support multi-nics OS.

Even for single NIC if one holds rtnl lock to synchronously issue cvq

commands it is wrong.

Yes, I agree with this.

Quoted 8 lines
Quoted 1 line

And using try_lock sort of thing is just a plain hack to identify if one is using

cvq or not.

It's a compromise.
But I want to say sorry, the transformation of rtnl_lock does not appear in my list for the time being.
Would like to see if anyone else takes this forward. :)

Ok. Fair enough, however the first series that plans to do the work in the netdim's worker context will have to do the work without crazy rtnl and try lock mess. So whoever writes the series will have to do without rtnl lock anyway.
Not related to spec, so can be discussed in some other thread.

Quoted 22 lines
Quoted 4 lines
Quoted 3 lines

I think you're referring to having controlq handle things asynchronously

Async yes, with and without batch.

YES.

Quoted 6 lines
Quoted 6 lines

(e.g.
batch add commands), and if asynchronous handling is solved, yes, the "kicks" motivation needs to be removed. The remaining motivation is that the device CPU needs to frequently wait for each requested DMA to complete. The more requests there are, the less efficient the device

responds.

Quoted 1 line

And if the descriptors are arranged contiguously even for the split q, the dma

are less.

Quoted 3 lines

I like to explicitly clarify that I am not again the batch mode. I want to say that once you get rid of the rtnl kind of implementation and

also do async commands, the performance gain from the batch will not be noticeable.

Quoted 8 lines

We did tests and found that even though the async of the dim command has been added, the device(the backend components) still hopes to reduce the pressure in batch mode.

Our dpu's cvq is sw-simulated, and the CPU responsible for handling cvq requests has a lot of extra work, such as forwarding, security, etc. So efficiency is need.

Sure.
I just don’t follow how multiple VQs values can be batched in single command once you don’t do any synchronous commands.

Quoted 6 lines
Quoted 1 line

Interrupt moderation is low latency operation that does not need to wait for

accumulating in the batch.

We don't need to wait continuously, just accumulate requests that already have update requirements.

The part that I don’t follow, in which sw context would you accumulate?
Each netdim worker asks to update their value, one don’t not wait continuously, all commands are following async. So which context is going to accumulate values for multiple?

Quoted 259 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

When a large-queue driver want to issue multiple requests, the subsequent request must wait for the previous request to be processed before it can be
sent:
1. The driver kicks the device frequently, this often interrupt the work

of

Quoted 37 lines
Quoted 37 lines
Quoted 3 lines
Quoted 3 lines

the device-side CPU. In addition, each vq request
2. Each request is pipelined and there can always be only one
request in

the

Quoted 2 lines
Quoted 2 lines

pipeline, causing more delays for the device-side CPU to
wait for the

DMA

Quoted 8 lines
Quoted 6 lines

request to complete.

These interruptions and overhead will strain the CPU responsible for controlling the path of the DPU, especially in multi-device and large-queue scenarios.

Please remove above line as you acked below that those driver notifications

are ignored by the device in [1].

Quoted 4 lines

[1]
https://lists.oasis-open.org/archives/virtio-comment/202401/msg00132
.h
tml

Please see the above reply.

Quoted 15 lines
Quoted 15 lines

To solve the above problems, we internally tried batch request, which merges requests from multiple queues and sends them at once. We conservatively tested
8 queue commands and sent them together. The DPU processing efficiency can be improved by 8 times, which greatly eases the DPU's support for multi- device and multi-queue DIM.

---
v2->v3:
1. Update some descriptions. @ Michael
2. virtio_net_ctrl_mrg_coal_vq -> virtnet_ctrl_mrg_coal_vq
3. Reword the commit log.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

v1->v2: Updated commit log. Due to sensitivity, sorry that can not v1->give the
absolute value directly. @Michael

   device-types/net/description.tex | 28 ++++++++++++++++++++++-----

-

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
   1 file changed, 22 insertions(+), 6 deletions(-)
device- renamed from device-types/net/description.tex +0 -0

types/net/description.tex index aff5e08..dbca203 100644

device-types/net/description.tex +0 -0
@@ -1667,8 +1667,8 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi for notification coalescing.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

If the VIRTIO_NET_F_VQ_NOTF_COAL feature is negotiated, the
driver can - send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET

and

Quoted 31 lines
Quoted 31 lines
Quoted 5 lines
Quoted 5 lines

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET -for virtqueue notification coalescing.

device-types/net/description.tex +2 -0
+send commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET for virtqueue notification

coalescing.

Quoted 10 lines
Quoted 8 lines
   \begin{lstlisting}
   struct virtio_net_ctrl_coal {
device-types/net/description.tex +0 -0
@@ -1682,11 +1682,17 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

       struct virtio_net_ctrl_coal coal;

};

+struct virtnet_ctrl_mrg_coal_vq {

Since this doing at batch level, ctrl_coal_vq_batch or ctrl_coal_vqs_batch

seems better name.

OK. It's a better name.

Quoted 11 lines

device-types/net/description.tex \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi · line 1695

Quoted 9 lines
device-types/net/description.tex +4 -0
+        le16 num_entries; /* indicates number of valid entries */
+        struct virtio_net_ctrl_coal_vq entries[]; };
+
   #define VIRTIO_NET_CTRL_NOTF_COAL 6
    #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET  0
    #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
    #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET 2
    #define VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET 3
+ #define VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET 4

A new feature bit is needed as the driver does not know if all the devices

Quoted 7 lines
Quoted 4 lines

support this command or not.

Well, 1.3 is still not released, if the device wants to support dim better, they should update the device.

It can but the driver does not know if it supports or not. So it tries and fails on the device that does not support. 1.3 is supposed to be released by now. It is stuck on unrelated OASIS

infrastructure update.

Will add a new feature bit.

Quoted 9 lines
Quoted 9 lines

Then if you suggest a new feature bit, I will add it in the next version.

Quoted 3 lines

For example, some device does not support VQS_SET command. The device is already out that supports notification features per VQ (without

coalescing support) and does not plan to support coalescing because OS level enqueue command is optimal for it like rest of the tx and rx q.

Quoted 7 lines
Quoted 5 lines

Even though ctrlq can do like txq/rxq, for example 256 requests are batched, so the device only needs to process a single request, which is friendly to device. Then it can effectively handle requests from other VMs, perform software forwarding, etc.

Yes. I understand.
I just don’t think the gain with be 8x once the proper sw (= async and

without rtnl lock is written that enqueues the cmd).

Quoted 1 line

So request is for the commit log updates to detach commit log from this sw

inefficiency details.

Will update this.

Thanks,
Heng

Quoted 34 lines
Quoted 34 lines
Quoted 34 lines
Quoted 34 lines
   \end{lstlisting}

   Coalescing parameters:
device-types/net/description.tex +0 -0
@@ -1706,6 +1712,7 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi \item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, the structure virtio_net_ctrl_coal_vq is write-only for the driver.
\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET,
\field{vq_index} and \field{reserved} are write-only
for the driver, and the structure virtio_net_ctrl_coal is
read-only for the driver.
+\item For the command VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET, the structure virtnet_ctrl_mrg_coal_vq is write-only for the driver.
\end{itemize}

The class VIRTIO_NET_CTRL_NOTF_COAL has the following commands:

device-types/net/description.tex +0 -0
@@ -1716,6 +1723,9 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi
for an enabled
transmit/receive virtqueue whose index is \field{vq_index}.
\item VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET: use the structure
virtio_net_ctrl_coal_vq to get the \field{max_usecs} and \field{max_packets} parameters
for an enabled
transmit/receive virtqueue whose index is \field{vq_index}. +\item VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET: use the structure virtnet_ctrl_mrg_coal_vq to set the \field{max_usecs} and \field{max_packets} parameters
+ for \field{num_entries}
+ enabled transmit/receive
virtqueues. The corresponding index value
+ of each configured virtqueue is \field{vq_index}.
\end{enumerate}

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The device may generate notifications more or less frequently
than specified by set commands of the VIRTIO_NET_CTRL_NOTF_COAL

class.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
device-types/net/description.tex +0 -0
@@ -1782,9 +1792,13 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The driver MUST set \field{vq_index} to the virtqueue index of
an enabled transmit or receive virtqueue.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
device-types/net/description.tex +3 -0
+The driver MUST set \field{num_entries} to a non-zero value and
+MUST NOT set \field{num_entries} to a value greater than the
+number of enabled

transmit and receive virtqueues.
+
The driver MUST have negotiated the VIRTIO_NET_F_NOTF_COAL
feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_TX_SET

and

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

VIRTIO_NET_CTRL_NOTF_COAL_RX_SET.

-The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands

VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET

Quoted 10 lines
Quoted 10 lines

and

Quoted 9 lines
Quoted 9 lines

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
+The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature
+when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET, VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.

The driver MUST ignore the values of coalescing parameters
received from the VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET command if

the

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

device responds with VIRTIO_NET_ERR.

device-types/net/description.tex +0 -0
@@ -1794,10 +1808,12 @@ \subsubsection{Control

Virtqueue}\label{sec:Device Types / Network Device / Devi

The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET

and

Quoted 1 line
Quoted 1 line

VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with

VIRTIO_NET_ERR

Quoted 4 lines
Quoted 4 lines

if it

Quoted 3 lines
Quoted 3 lines

was not able to change the parameters.

-The device MUST respond to the

VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET

Quoted 3 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

command with VIRTIO_NET_ERR if it was not able to change the

parameters.

Quoted 1 line
Quoted 1 line

+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET

and

Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line

+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET commands with

VIRTIO_NET_ERR

Quoted 6 lines
Quoted 6 lines

if it

device-types/net/description.tex +2 -0
+was not able to change some of the coalescing parameters. In this
+case, all of

the parameters MUST remain unchanged, for all virtqueues.

-The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET

and

Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Quoted 1 line

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with -

VIRTIO_NET_ERR if the

Quoted 4 lines
Quoted 4 lines

designated virtqueue is not an enabled transmit or receive virtqueue.

device-types/net/description.tex +2 -0
+The device MUST respond to VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET,
+VIRTIO_NET_CTRL_NOTF_COAL_VQS_SET and

VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET commands with

VIRTIO_NET_ERR

Quoted 6 lines
Quoted 6 lines

if the

Quoted 5 lines
Quoted 5 lines

designated virtqueue is not an enabled transmit or receive virtqueue.

Upon disabling and re-enabling a transmit virtqueue, the device
MUST set the coalescing parameters of the virtqueue to those configured through the VIRTIO_NET_CTRL_NOTF_COAL_TX_SET

command,

Quoted 21 lines
Quoted 21 lines

or,

Quoted 20 lines
Quoted 3 lines

if the driver did not set any TX coalescing parameters, to 0. --
1.8.3.1

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected] List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License:
https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines:
https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/