net/tun: use reciprocal_scale
Subsystems (3)
PATCH 1/1 net/tun: use reciprocal_scale
Use the inline function reciprocal_scale rather than open coding the scale optimization. Also, remove unnecessary initializations. Resulting compiled code is unchanged (according to godbolt).
--- drivers/net/tun.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/tun.c +3 -4
@@ -54,6 +54,7 @@#include <linux/if_tun.h> #include <linux/if_vlan.h> #include <linux/crc32.h> +#include <linux/math.h> #include <linux/nsproxy.h> #include <linux/virtio_net.h> #include <linux/rcupdate.h>
@@ -523,8 +524,7 @@ static inline void tun_flow_save_rps_rxhash(struct tun_flow_entry *e, u32 hash)static u16 tun_automq_select_queue (struct tun_struct *tun,struct sk_buff *skb) {struct tun_flow_entry *e; -u32 txq =0 ; -u32 numqueues =0 ; +u32 txq, numqueues; numqueues =READ_ONCE (tun->numqueues);
@@ -534,8 +534,7 @@ static u16 tun_automq_select_queue(struct tun_struct *tun, struct sk_buff *skb)tun_flow_save_rps_rxhash (e, txq); txq = e->queue_index; }else { -/* use multiply and shift instead of expensive divide */ - txq = ((u64 )txq * numqueues) >>32 ; + txq =reciprocal_scale (txq, numqueues); }return txq;
Signature · 1 line
2.43.0
Quoted 5 lines · Stephen Hemminger
Use the inline function
reciprocal_scalerather than open coding the scale optimization. Also, remove unnecessary initializations. Resulting compiled code is unchanged (according to godbolt).Signed-off-by Stephen Hemminger <[email protected]>
Targeting net-next
Quoted 6 lines · Stephen Hemminger
Use the inline function
reciprocal_scalerather than open coding the scale optimization. Also, remove unnecessary initializations. Resulting compiled code is unchanged (according to godbolt).Signed-off-by Stephen Hemminger <[email protected]>
Thanks
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:
Quoted 8 lines · On Thu, 25 Jan 2024 16:25:11 -0800 you wrote:
Use the inline function
reciprocal_scalerather than open coding the scale optimization. Also, remove unnecessary initializations. Resulting compiled code is unchanged (according to godbolt).Signed-off-by Stephen Hemminger <[email protected]>--- drivers/net/tun.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Here is the summary with links:
- net/tun: use reciprocal_scale
https://git.kernel.org/netdev/net-next/c/3f3ebe536208
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html