f2fs: compress: fix to cover f2fs_disable_compressed_file() w/ i_sem
Chao Yu
maintainerPATCH v2 1/1 f2fs: compress: fix to cover f2fs_disable_compressed_file() w/ i_sem
- f2fs_disable_compressed_file
- check inode_has_data
- f2fs_file_mmap
- mkwrite
- f2fs_get_block_locked : update metadata in compressed inode's disk layout
- fi->i_flags &= ~F2FS_COMPR_FL
- clear_inode_flag(inode, FI_COMPRESSED_FILE);
we should use i_sem lock to prevent above race case.
---
v2:
- remove unneeded i_size check pointed out by Jaegeuk.
fs/f2fs/f2fs.h | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
fs/f2fs/f2fs.h +11 -2
@@ -4409,15 +4409,24 @@ static inline bool f2fs_disable_compressed_file(struct inode *inode) {struct f2fs_inode_info *fi =F2FS_I (inode); -if (!f2fs_compressed_file (inode)) +f2fs_down_write (&F2FS_I (inode)->i_sem); + +if (!f2fs_compressed_file (inode)) { +f2fs_up_write (&F2FS_I (inode)->i_sem);return true; -if (S_ISREG (inode->i_mode) &&F2FS_HAS_BLOCKS (inode)) + } +if (f2fs_is_mmap_file (inode) || + (S_ISREG (inode->i_mode) &&F2FS_HAS_BLOCKS (inode))) { +f2fs_up_write (&F2FS_I (inode)->i_sem);return false; + } fi->i_flags &= ~F2FS_COMPR_FL ;stat_dec_compr_inode (inode);clear_inode_flag (inode,FI_COMPRESSED_FILE );f2fs_mark_inode_dirty_sync (inode, true); + +f2fs_up_write (&F2FS_I (inode)->i_sem);return true; }
Signature · 1 line
2.40.1
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 11 lines · On Mon, 22 Jan 2024 10:23:13 +0800 you wrote:
-
f2fs_disable_compressed_file
- checkinode_has_data
-f2fs_file_mmap
- mkwrite
-f2fs_get_block_locked: update metadata in compressed inode's disk layout
-fi->i_flags&= ~F2FS_COMPR_FL
-clear_inode_flag(inode, FI_COMPRESSED_FILE);[...]
Here is the summary with links:
- [f2fs-dev,v2] f2fs: compress: fix to cover f2fs_disable_compressed_file() w/ i_sem
https://git.kernel.org/jaegeuk/f2fs/c/9f100ecdedc3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html