mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
Subsystems (4)
PATCH 1/1 mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
Class-based I2C probing requires detect() and address_list to be set in the I2C client driver, see checks in i2c_detect(). It's misleading to declare I2C_CLASS_HWMON support if this precondition isn't met.
--- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/mellanox/mlxsw/minimal.c +0 -1
@@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = {static struct i2c_driver mlxsw_m_i2c_driver = { .driver.name ="mlxsw_minimal" , - .class =I2C_CLASS_HWMON , .id_table = mlxsw_m_i2c_id, };
Signature · 1 line
2.43.0
Quoted 6 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>
Quoted 19 lines
--- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 - 1 file changed, 1 deletion(-)drivers/net/ethernet/mellanox/mlxsw/minimal.c +0
-1@@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = {static struct i2c_driver mlxsw_m_i2c_driver = { .driver.name ="mlxsw_minimal" , - .class =I2C_CLASS_HWMON , .id_table = mlxsw_m_i2c_id, };Signature · 1 line
2.43.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Sat, 27 Jan 2024 16:08:18 +0100 you wrote:
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>[...]
Here is the summary with links:
- [net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
https://git.kernel.org/netdev/net-next/c/ccf1445204a1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html