clk: qcom: use module_platform_driver() to register drivers
Subsystems (3)
cover clk: qcom: use module_platform_driver() to register drivers
Several Qualcomm clock controller drivers use subsys_initcall to register the driver early. This makes sense for GCC or TCSRcc. However there is no need to register camera, display, GPU or venus clocks earlier. Shift registration to driver init level, where they belong.
Note, I didn't touch lpass clock drivers, they need to be analysed separately.
---
Dmitry Baryshkov (4):
clk: qcom: camcc-*: switch to module_platform_driver
clk: qcom: dispcc-*: switch to module_platform_driver
clk: qcom: gpucc-*: switch to module_platform_driver
clk: qcom: videocc-*: switch to module_platform_driver
drivers/clk/qcom/camcc-sc7180.c | 12 +----------- drivers/clk/qcom/camcc-sc7280.c | 12 +----------- drivers/clk/qcom/camcc-sdm845.c | 12 +----------- drivers/clk/qcom/camcc-sm6350.c | 12 +----------- drivers/clk/qcom/dispcc-qcm2290.c | 12 +----------- drivers/clk/qcom/dispcc-sc7180.c | 12 +----------- drivers/clk/qcom/dispcc-sc7280.c | 12 +----------- drivers/clk/qcom/dispcc-sc8280xp.c | 12 +----------- drivers/clk/qcom/dispcc-sdm845.c | 12 +----------- drivers/clk/qcom/dispcc-sm6125.c | 12 +----------- drivers/clk/qcom/dispcc-sm6350.c | 12 +----------- drivers/clk/qcom/dispcc-sm6375.c | 12 +----------- drivers/clk/qcom/dispcc-sm8250.c | 12 +----------- drivers/clk/qcom/dispcc-sm8450.c | 12 +----------- drivers/clk/qcom/dispcc-sm8550.c | 12 +----------- drivers/clk/qcom/dispcc-sm8650.c | 12 +----------- drivers/clk/qcom/gpucc-sa8775p.c | 12 +----------- drivers/clk/qcom/gpucc-sc7180.c | 12 +----------- drivers/clk/qcom/gpucc-sc7280.c | 12 +----------- drivers/clk/qcom/gpucc-sdm845.c | 12 +----------- drivers/clk/qcom/gpucc-sm8150.c | 12 +----------- drivers/clk/qcom/gpucc-sm8250.c | 12 +----------- drivers/clk/qcom/gpucc-sm8350.c | 12 +----------- drivers/clk/qcom/gpucc-sm8550.c | 12 +----------- drivers/clk/qcom/videocc-sc7180.c | 12 +----------- drivers/clk/qcom/videocc-sc7280.c | 12 +----------- drivers/clk/qcom/videocc-sdm845.c | 12 +----------- drivers/clk/qcom/videocc-sm8150.c | 12 +----------- drivers/clk/qcom/videocc-sm8250.c | 12 +----------- drivers/clk/qcom/videocc-sm8450.c | 12 +----------- drivers/clk/qcom/videocc-sm8550.c | 12 +----------- 31 files changed, 31 insertions(+), 341 deletions(-)
---
base-commit: 076d56d74f17e625b3d63cf4743b3d7d02180379
change-id: 20240206-clk-module-platform-driver-4161aee8d197
Best regards,
Signature · 1 line
Dmitry Baryshkov <[email protected]>
PATCH 1/4 clk: qcom: camcc-*: switch to module_platform_driver
There is no need to register camera clock controllers during subsys init calls. Use module_platform_driver() instead.
--- drivers/clk/qcom/camcc-sc7180.c | 12 +----------- drivers/clk/qcom/camcc-sc7280.c | 12 +----------- drivers/clk/qcom/camcc-sdm845.c | 12 +----------- drivers/clk/qcom/camcc-sm6350.c | 12 +----------- 4 files changed, 4 insertions(+), 44 deletions(-)
drivers/clk/qcom/camcc-sc7180.c +1 -11
@@ -1703,17 +1703,7 @@ static struct platform_driver cam_cc_sc7180_driver = { }, }; -static int __init cam_cc_sc7180_init (void ) -{ -return platform_driver_register (&cam_cc_sc7180_driver); -} -subsys_initcall (cam_cc_sc7180_init); - -static void __exit cam_cc_sc7180_exit(void) -{ -platform_driver_unregister (&cam_cc_sc7180_driver); -} -module_exit (cam_cc_sc7180_exit); +module_platform_driver (cam_cc_sc7180_driver);MODULE_DESCRIPTION ("QTI CAM_CC SC7180 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/camcc-sc7280.c +1 -11
@@ -2468,17 +2468,7 @@ static struct platform_driver cam_cc_sc7280_driver = { }, }; -static int __init cam_cc_sc7280_init (void ) -{ -return platform_driver_register (&cam_cc_sc7280_driver); -} -subsys_initcall (cam_cc_sc7280_init); - -static void __exit cam_cc_sc7280_exit(void) -{ -platform_driver_unregister (&cam_cc_sc7280_driver); -} -module_exit (cam_cc_sc7280_exit); +module_platform_driver (cam_cc_sc7280_driver);MODULE_DESCRIPTION ("QTI CAM_CC SC7280 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/camcc-sdm845.c +1 -11
@@ -1746,17 +1746,7 @@ static struct platform_driver cam_cc_sdm845_driver = { }, }; -static int __init cam_cc_sdm845_init (void ) -{ -return platform_driver_register (&cam_cc_sdm845_driver); -} -subsys_initcall (cam_cc_sdm845_init); - -static void __exit cam_cc_sdm845_exit(void) -{ -platform_driver_unregister (&cam_cc_sdm845_driver); -} -module_exit (cam_cc_sdm845_exit); +module_platform_driver (cam_cc_sdm845_driver);MODULE_DESCRIPTION ("QTI CAM_CC SDM845 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/camcc-sm6350.c +1 -11
@@ -1890,17 +1890,7 @@ static struct platform_driver camcc_sm6350_driver = { }, }; -static int __init camcc_sm6350_init (void ) -{ -return platform_driver_register (&camcc_sm6350_driver); -} -subsys_initcall (camcc_sm6350_init); - -static void __exit camcc_sm6350_exit(void) -{ -platform_driver_unregister (&camcc_sm6350_driver); -} -module_exit (camcc_sm6350_exit); +module_platform_driver (camcc_sm6350_driver);MODULE_DESCRIPTION ("QTI CAMCC SM6350 Driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.39.2
Re: [PATCH 1/4] clk: qcom: camcc-*: switch to module_platform_driver
Quoted 5 lines · Dmitry Baryshkov
There is no need to register camera clock controllers during subsys init calls. Use
module_platform_driver()instead.Signed-off-by Dmitry Baryshkov <[email protected]>---
Konrad
PATCH 2/4 clk: qcom: dispcc-*: switch to module_platform_driver
In reply to Dmitry BaryshkovThere is no need to register display clock controllers during subsys init calls. Use module_platform_driver() instead.
--- drivers/clk/qcom/dispcc-qcm2290.c | 12 +----------- drivers/clk/qcom/dispcc-sc7180.c | 12 +----------- drivers/clk/qcom/dispcc-sc7280.c | 12 +----------- drivers/clk/qcom/dispcc-sc8280xp.c | 12 +----------- drivers/clk/qcom/dispcc-sdm845.c | 12 +----------- drivers/clk/qcom/dispcc-sm6125.c | 12 +----------- drivers/clk/qcom/dispcc-sm6350.c | 12 +----------- drivers/clk/qcom/dispcc-sm6375.c | 12 +----------- drivers/clk/qcom/dispcc-sm8250.c | 12 +----------- drivers/clk/qcom/dispcc-sm8450.c | 12 +----------- drivers/clk/qcom/dispcc-sm8550.c | 12 +----------- drivers/clk/qcom/dispcc-sm8650.c | 12 +----------- 12 files changed, 12 insertions(+), 132 deletions(-)
drivers/clk/qcom/dispcc-qcm2290.c +1 -11
@@ -539,17 +539,7 @@ static struct platform_driver disp_cc_qcm2290_driver = { }, }; -static int __init disp_cc_qcm2290_init (void ) -{ -return platform_driver_register (&disp_cc_qcm2290_driver); -} -subsys_initcall (disp_cc_qcm2290_init); - -static void __exit disp_cc_qcm2290_exit(void) -{ -platform_driver_unregister (&disp_cc_qcm2290_driver); -} -module_exit (disp_cc_qcm2290_exit); +module_platform_driver (disp_cc_qcm2290_driver);MODULE_DESCRIPTION ("QTI DISP_CC qcm2290 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/dispcc-sc7180.c +1 -11
@@ -724,17 +724,7 @@ static struct platform_driver disp_cc_sc7180_driver = { }, }; -static int __init disp_cc_sc7180_init (void ) -{ -return platform_driver_register (&disp_cc_sc7180_driver); -} -subsys_initcall (disp_cc_sc7180_init); - -static void __exit disp_cc_sc7180_exit(void) -{ -platform_driver_unregister (&disp_cc_sc7180_driver); -} -module_exit (disp_cc_sc7180_exit); +module_platform_driver (disp_cc_sc7180_driver);MODULE_DESCRIPTION ("QTI DISP_CC SC7180 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/dispcc-sc7280.c +1 -11
@@ -895,17 +895,7 @@ static struct platform_driver disp_cc_sc7280_driver = { }, }; -static int __init disp_cc_sc7280_init (void ) -{ -return platform_driver_register (&disp_cc_sc7280_driver); -} -subsys_initcall (disp_cc_sc7280_init); - -static void __exit disp_cc_sc7280_exit(void) -{ -platform_driver_unregister (&disp_cc_sc7280_driver); -} -module_exit (disp_cc_sc7280_exit); +module_platform_driver (disp_cc_sc7280_driver);MODULE_DESCRIPTION ("QTI DISP_CC sc7280 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/dispcc-sc8280xp.c +1 -11
@@ -3202,17 +3202,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { }, }; -static int __init disp_cc_sc8280xp_init (void ) -{ -return platform_driver_register (&disp_cc_sc8280xp_driver); -} -subsys_initcall (disp_cc_sc8280xp_init); - -static void __exit disp_cc_sc8280xp_exit(void) -{ -platform_driver_unregister (&disp_cc_sc8280xp_driver); -} -module_exit (disp_cc_sc8280xp_exit); +module_platform_driver (disp_cc_sc8280xp_driver);MODULE_DESCRIPTION ("Qualcomm SC8280XP dispcc driver" );MODULE_LICENSE ("GPL" );
drivers/clk/qcom/dispcc-sdm845.c +1 -11
@@ -872,17 +872,7 @@ static struct platform_driver disp_cc_sdm845_driver = { }, }; -static int __init disp_cc_sdm845_init (void ) -{ -return platform_driver_register (&disp_cc_sdm845_driver); -} -subsys_initcall (disp_cc_sdm845_init); - -static void __exit disp_cc_sdm845_exit(void) -{ -platform_driver_unregister (&disp_cc_sdm845_driver); -} -module_exit (disp_cc_sdm845_exit); +module_platform_driver (disp_cc_sdm845_driver);MODULE_LICENSE ("GPL v2" );MODULE_DESCRIPTION ("QTI DISPCC SDM845 Driver" );
drivers/clk/qcom/dispcc-sm6125.c +1 -11
@@ -693,17 +693,7 @@ static struct platform_driver disp_cc_sm6125_driver = { }, }; -static int __init disp_cc_sm6125_init (void ) -{ -return platform_driver_register (&disp_cc_sm6125_driver); -} -subsys_initcall (disp_cc_sm6125_init); - -static void __exit disp_cc_sm6125_exit(void) -{ -platform_driver_unregister (&disp_cc_sm6125_driver); -} -module_exit (disp_cc_sm6125_exit); +module_platform_driver (disp_cc_sm6125_driver);MODULE_DESCRIPTION ("QTI DISPCC SM6125 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/dispcc-sm6350.c +1 -11
@@ -781,17 +781,7 @@ static struct platform_driver disp_cc_sm6350_driver = { }, }; -static int __init disp_cc_sm6350_init (void ) -{ -return platform_driver_register (&disp_cc_sm6350_driver); -} -subsys_initcall (disp_cc_sm6350_init); - -static void __exit disp_cc_sm6350_exit(void) -{ -platform_driver_unregister (&disp_cc_sm6350_driver); -} -module_exit (disp_cc_sm6350_exit); +module_platform_driver (disp_cc_sm6350_driver);MODULE_DESCRIPTION ("QTI DISP_CC SM6350 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/dispcc-sm6375.c +1 -11
@@ -594,17 +594,7 @@ static struct platform_driver disp_cc_sm6375_driver = { }, }; -static int __init disp_cc_sm6375_init (void ) -{ -return platform_driver_register (&disp_cc_sm6375_driver); -} -subsys_initcall (disp_cc_sm6375_init); - -static void __exit disp_cc_sm6375_exit(void) -{ -platform_driver_unregister (&disp_cc_sm6375_driver); -} -module_exit (disp_cc_sm6375_exit); +module_platform_driver (disp_cc_sm6375_driver);MODULE_DESCRIPTION ("QTI DISPCC SM6375 Driver" );MODULE_LICENSE ("GPL" );
drivers/clk/qcom/dispcc-sm8250.c +1 -11
@@ -1383,17 +1383,7 @@ static struct platform_driver disp_cc_sm8250_driver = { }, }; -static int __init disp_cc_sm8250_init (void ) -{ -return platform_driver_register (&disp_cc_sm8250_driver); -} -subsys_initcall (disp_cc_sm8250_init); - -static void __exit disp_cc_sm8250_exit(void) -{ -platform_driver_unregister (&disp_cc_sm8250_driver); -} -module_exit (disp_cc_sm8250_exit); +module_platform_driver (disp_cc_sm8250_driver);MODULE_DESCRIPTION ("QTI DISPCC SM8250 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/dispcc-sm8450.c +1 -11
@@ -1815,17 +1815,7 @@ static struct platform_driver disp_cc_sm8450_driver = { }, }; -static int __init disp_cc_sm8450_init (void ) -{ -return platform_driver_register (&disp_cc_sm8450_driver); -} -subsys_initcall (disp_cc_sm8450_init); - -static void __exit disp_cc_sm8450_exit(void) -{ -platform_driver_unregister (&disp_cc_sm8450_driver); -} -module_exit (disp_cc_sm8450_exit); +module_platform_driver (disp_cc_sm8450_driver);MODULE_DESCRIPTION ("QTI DISPCC SM8450 Driver" );MODULE_LICENSE ("GPL" );
drivers/clk/qcom/dispcc-sm8550.c +1 -11
@@ -1808,17 +1808,7 @@ static struct platform_driver disp_cc_sm8550_driver = { }, }; -static int __init disp_cc_sm8550_init (void ) -{ -return platform_driver_register (&disp_cc_sm8550_driver); -} -subsys_initcall (disp_cc_sm8550_init); - -static void __exit disp_cc_sm8550_exit(void) -{ -platform_driver_unregister (&disp_cc_sm8550_driver); -} -module_exit (disp_cc_sm8550_exit); +module_platform_driver (disp_cc_sm8550_driver);MODULE_DESCRIPTION ("QTI DISPCC SM8550 Driver" );MODULE_LICENSE ("GPL" );
drivers/clk/qcom/dispcc-sm8650.c +1 -11
@@ -1802,17 +1802,7 @@ static struct platform_driver disp_cc_sm8650_driver = { }, }; -static int __init disp_cc_sm8650_init (void ) -{ -return platform_driver_register (&disp_cc_sm8650_driver); -} -subsys_initcall (disp_cc_sm8650_init); - -static void __exit disp_cc_sm8650_exit(void) -{ -platform_driver_unregister (&disp_cc_sm8650_driver); -} -module_exit (disp_cc_sm8650_exit); +module_platform_driver (video_cc_sm8650_driver);MODULE_DESCRIPTION ("QTI DISPCC SM8650 Driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.39.2
Re: [PATCH 2/4] clk: qcom: dispcc-*: switch to module_platform_driver
Quoted 5 lines · Dmitry Baryshkov
There is no need to register display clock controllers during subsys init calls. Use
module_platform_driver()instead.Signed-off-by Dmitry Baryshkov <[email protected]>---
Konrad
PATCH 3/4 clk: qcom: gpucc-*: switch to module_platform_driver
In reply to Dmitry BaryshkovThere is no need to register GPU clock controllers during subsys init calls. Use module_platform_driver() instead.
--- drivers/clk/qcom/gpucc-sa8775p.c | 12 +----------- drivers/clk/qcom/gpucc-sc7180.c | 12 +----------- drivers/clk/qcom/gpucc-sc7280.c | 12 +----------- drivers/clk/qcom/gpucc-sdm845.c | 12 +----------- drivers/clk/qcom/gpucc-sm8150.c | 12 +----------- drivers/clk/qcom/gpucc-sm8250.c | 12 +----------- drivers/clk/qcom/gpucc-sm8350.c | 12 +----------- drivers/clk/qcom/gpucc-sm8550.c | 12 +----------- 8 files changed, 8 insertions(+), 88 deletions(-)
drivers/clk/qcom/gpucc-sa8775p.c +1 -11
@@ -609,17 +609,7 @@ static struct platform_driver gpu_cc_sa8775p_driver = { }, }; -static int __init gpu_cc_sa8775p_init (void ) -{ -return platform_driver_register (&gpu_cc_sa8775p_driver); -} -subsys_initcall (gpu_cc_sa8775p_init); - -static void __exit gpu_cc_sa8775p_exit(void) -{ -platform_driver_unregister (&gpu_cc_sa8775p_driver); -} -module_exit (gpu_cc_sa8775p_exit); +module_platform_driver (gpu_cc_sa8775p_driver);MODULE_DESCRIPTION ("SA8775P GPUCC driver" );MODULE_LICENSE ("GPL" );
drivers/clk/qcom/gpucc-sc7180.c +1 -11
@@ -252,17 +252,7 @@ static struct platform_driver gpu_cc_sc7180_driver = { }, }; -static int __init gpu_cc_sc7180_init (void ) -{ -return platform_driver_register (&gpu_cc_sc7180_driver); -} -subsys_initcall (gpu_cc_sc7180_init); - -static void __exit gpu_cc_sc7180_exit(void) -{ -platform_driver_unregister (&gpu_cc_sc7180_driver); -} -module_exit (gpu_cc_sc7180_exit); +module_platform_driver (gpu_cc_sc7180_driver);MODULE_DESCRIPTION ("QTI GPU_CC SC7180 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/gpucc-sc7280.c +1 -11
@@ -476,17 +476,7 @@ static struct platform_driver gpu_cc_sc7280_driver = { }, }; -static int __init gpu_cc_sc7280_init (void ) -{ -return platform_driver_register (&gpu_cc_sc7280_driver); -} -subsys_initcall (gpu_cc_sc7280_init); - -static void __exit gpu_cc_sc7280_exit(void) -{ -platform_driver_unregister (&gpu_cc_sc7280_driver); -} -module_exit (gpu_cc_sc7280_exit); +module_platform_driver (gpu_cc_sc7280_driver);MODULE_DESCRIPTION ("QTI GPU_CC SC7280 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/gpucc-sdm845.c +1 -11
@@ -203,17 +203,7 @@ static struct platform_driver gpu_cc_sdm845_driver = { }, }; -static int __init gpu_cc_sdm845_init (void ) -{ -return platform_driver_register (&gpu_cc_sdm845_driver); -} -subsys_initcall (gpu_cc_sdm845_init); - -static void __exit gpu_cc_sdm845_exit(void) -{ -platform_driver_unregister (&gpu_cc_sdm845_driver); -} -module_exit (gpu_cc_sdm845_exit); +module_platform_driver (gpu_cc_sdm845_driver);MODULE_DESCRIPTION ("QTI GPUCC SDM845 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/gpucc-sm8150.c +1 -11
@@ -315,17 +315,7 @@ static struct platform_driver gpu_cc_sm8150_driver = { }, }; -static int __init gpu_cc_sm8150_init (void ) -{ -return platform_driver_register (&gpu_cc_sm8150_driver); -} -subsys_initcall (gpu_cc_sm8150_init); - -static void __exit gpu_cc_sm8150_exit(void) -{ -platform_driver_unregister (&gpu_cc_sm8150_driver); -} -module_exit (gpu_cc_sm8150_exit); +module_platform_driver (gpu_cc_sm8150_driver);MODULE_DESCRIPTION ("QTI GPUCC SM8150 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/gpucc-sm8250.c +1 -11
@@ -331,17 +331,7 @@ static struct platform_driver gpu_cc_sm8250_driver = { }, }; -static int __init gpu_cc_sm8250_init (void ) -{ -return platform_driver_register (&gpu_cc_sm8250_driver); -} -subsys_initcall (gpu_cc_sm8250_init); - -static void __exit gpu_cc_sm8250_exit(void) -{ -platform_driver_unregister (&gpu_cc_sm8250_driver); -} -module_exit (gpu_cc_sm8250_exit); +module_platform_driver (gpu_cc_sm8250_driver);MODULE_DESCRIPTION ("QTI GPU_CC SM8250 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/gpucc-sm8350.c +1 -11
@@ -621,17 +621,7 @@ static struct platform_driver gpu_cc_sm8350_driver = { }, }; -static int __init gpu_cc_sm8350_init (void ) -{ -return platform_driver_register (&gpu_cc_sm8350_driver); -} -subsys_initcall (gpu_cc_sm8350_init); - -static void __exit gpu_cc_sm8350_exit(void) -{ -platform_driver_unregister (&gpu_cc_sm8350_driver); -} -module_exit (gpu_cc_sm8350_exit); +module_platform_driver (gpu_cc_sm8350_driver);MODULE_DESCRIPTION ("QTI GPU_CC SM8350 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/gpucc-sm8550.c +1 -11
@@ -594,17 +594,7 @@ static struct platform_driver gpu_cc_sm8550_driver = { }, }; -static int __init gpu_cc_sm8550_init (void ) -{ -return platform_driver_register (&gpu_cc_sm8550_driver); -} -subsys_initcall (gpu_cc_sm8550_init); - -static void __exit gpu_cc_sm8550_exit(void) -{ -platform_driver_unregister (&gpu_cc_sm8550_driver); -} -module_exit (gpu_cc_sm8550_exit); +module_platform_driver (gpu_cc_sm8550_driver);MODULE_DESCRIPTION ("QTI GPUCC SM8550 Driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.39.2
Re: [PATCH 3/4] clk: qcom: gpucc-*: switch to module_platform_driver
Quoted 5 lines · Dmitry Baryshkov
There is no need to register GPU clock controllers during subsys init calls. Use
module_platform_driver()instead.Signed-off-by Dmitry Baryshkov <[email protected]>---
But how will I play quake as my kernel loads!
Konrad
PATCH 4/4 clk: qcom: videocc-*: switch to module_platform_driver
In reply to Dmitry BaryshkovThere is no need to register video clock controllers during subsys init calls. Use module_platform_driver() instead.
--- drivers/clk/qcom/videocc-sc7180.c | 12 +----------- drivers/clk/qcom/videocc-sc7280.c | 12 +----------- drivers/clk/qcom/videocc-sdm845.c | 12 +----------- drivers/clk/qcom/videocc-sm8150.c | 12 +----------- drivers/clk/qcom/videocc-sm8250.c | 12 +----------- drivers/clk/qcom/videocc-sm8450.c | 12 +----------- drivers/clk/qcom/videocc-sm8550.c | 12 +----------- 7 files changed, 7 insertions(+), 77 deletions(-)
drivers/clk/qcom/videocc-sc7180.c +1 -11
@@ -237,17 +237,7 @@ static struct platform_driver video_cc_sc7180_driver = { }, }; -static int __init video_cc_sc7180_init (void ) -{ -return platform_driver_register (&video_cc_sc7180_driver); -} -subsys_initcall (video_cc_sc7180_init); - -static void __exit video_cc_sc7180_exit(void) -{ -platform_driver_unregister (&video_cc_sc7180_driver); -} -module_exit (video_cc_sc7180_exit); +module_platform_driver (video_cc_sc7180_driver);MODULE_LICENSE ("GPL v2" );MODULE_DESCRIPTION ("QTI VIDEOCC SC7180 Driver" );
drivers/clk/qcom/videocc-sc7280.c +1 -11
@@ -309,17 +309,7 @@ static struct platform_driver video_cc_sc7280_driver = { }, }; -static int __init video_cc_sc7280_init (void ) -{ -return platform_driver_register (&video_cc_sc7280_driver); -} -subsys_initcall (video_cc_sc7280_init); - -static void __exit video_cc_sc7280_exit(void) -{ -platform_driver_unregister (&video_cc_sc7280_driver); -} -module_exit (video_cc_sc7280_exit); +module_platform_driver (video_cc_sc7280_driver);MODULE_DESCRIPTION ("QTI VIDEO_CC sc7280 Driver" );MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/videocc-sdm845.c +1 -11
@@ -340,16 +340,6 @@ static struct platform_driver video_cc_sdm845_driver = { }, }; -static int __init video_cc_sdm845_init (void ) -{ -return platform_driver_register (&video_cc_sdm845_driver); -} -subsys_initcall (video_cc_sdm845_init); - -static void __exit video_cc_sdm845_exit(void) -{ -platform_driver_unregister (&video_cc_sdm845_driver); -} -module_exit (video_cc_sdm845_exit); +module_platform_driver (video_cc_sdm845_driver);MODULE_LICENSE ("GPL v2" );
drivers/clk/qcom/videocc-sm8150.c +1 -11
@@ -277,17 +277,7 @@ static struct platform_driver video_cc_sm8150_driver = { }, }; -static int __init video_cc_sm8150_init (void ) -{ -return platform_driver_register (&video_cc_sm8150_driver); -} -subsys_initcall (video_cc_sm8150_init); - -static void __exit video_cc_sm8150_exit(void) -{ -platform_driver_unregister (&video_cc_sm8150_driver); -} -module_exit (video_cc_sm8150_exit); +module_platform_driver (video_cc_sm8150_driver);MODULE_LICENSE ("GPL v2" );MODULE_DESCRIPTION ("QTI VIDEOCC SM8150 Driver" );
drivers/clk/qcom/videocc-sm8250.c +1 -11
@@ -402,17 +402,7 @@ static struct platform_driver video_cc_sm8250_driver = { }, }; -static int __init video_cc_sm8250_init (void ) -{ -return platform_driver_register (&video_cc_sm8250_driver); -} -subsys_initcall (video_cc_sm8250_init); - -static void __exit video_cc_sm8250_exit(void) -{ -platform_driver_unregister (&video_cc_sm8250_driver); -} -module_exit (video_cc_sm8250_exit); +module_platform_driver (video_cc_sm8250_driver);MODULE_LICENSE ("GPL v2" );MODULE_DESCRIPTION ("QTI VIDEOCC SM8250 Driver" );
drivers/clk/qcom/videocc-sm8450.c +1 -11
@@ -448,17 +448,7 @@ static struct platform_driver video_cc_sm8450_driver = { }, }; -static int __init video_cc_sm8450_init (void ) -{ -return platform_driver_register (&video_cc_sm8450_driver); -} -subsys_initcall (video_cc_sm8450_init); - -static void __exit video_cc_sm8450_exit(void) -{ -platform_driver_unregister (&video_cc_sm8450_driver); -} -module_exit (video_cc_sm8450_exit); +module_platform_driver (video_cc_sm8450_driver);MODULE_DESCRIPTION ("QTI VIDEOCC SM8450 Driver" );MODULE_LICENSE ("GPL" );
drivers/clk/qcom/videocc-sm8550.c +1 -11
@@ -453,17 +453,7 @@ static struct platform_driver video_cc_sm8550_driver = { }, }; -static int __init video_cc_sm8550_init (void ) -{ -return platform_driver_register (&video_cc_sm8550_driver); -} -subsys_initcall (video_cc_sm8550_init); - -static void __exit video_cc_sm8550_exit(void) -{ -platform_driver_unregister (&video_cc_sm8550_driver); -} -module_exit (video_cc_sm8550_exit); +module_platform_driver (video_cc_sm8550_driver);MODULE_DESCRIPTION ("QTI VIDEOCC SM8550 Driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.39.2
Re: [PATCH 4/4] clk: qcom: videocc-*: switch to module_platform_driver
Quoted 5 lines · Dmitry Baryshkov
There is no need to register video clock controllers during subsys init calls. Use
module_platform_driver()instead.Signed-off-by Dmitry Baryshkov <[email protected]>---
Konrad
Quoted 9 lines · Dmitry Baryshkov
Several Qualcomm clock controller drivers use
subsys_initcallto register the driver early. This makes sense for GCC or TCSRcc. However there is no need to register camera, display, GPU or venus clocks earlier. Shift registration to driver init level, where they belong.Note, I didn't touch lpass clock drivers, they need to be analysed separately.
[...]
Applied, thanks!
[1/4] clk: qcom: camcc-*: switch to module_platform_driver
commit: 0ac31d8c2bb90312071e299a23b3299adde13736
[2/4] clk: qcom: dispcc-*: switch to module_platform_driver
commit: f4ccb184940247c784e229a739344678e487046d
[3/4] clk: qcom: gpucc-*: switch to module_platform_driver
commit: a5119f7dbf90d12d169f3e3088908ead1955c1b0
[4/4] clk: qcom: videocc-*: switch to module_platform_driver
commit: 95dd41487aecd1e8feeca9e10c6b28243b2f6145Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>