Skip to contentSkip to conversation

build: set -mfpu=neon flag for armv7a builds

PATCH Applied Luca Boccassi 3 participants 3 messages Nov 15, 2018 – Nov 18, 2018 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Luca Boccassi

author
#0 lore raw

PATCH 1/1 build: set -mfpu=neon flag for armv7a builds

Building on armv7a with meson currenctly fails:

/usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
inlining failed in call to always_inline ‘vld1q_s32’: target specific option mismatch

Set -mfpu=neon on that architecture like the legacy makefiles do to fix the issue.

Fixes b1d48c41189a ("build: support ARM with meson")
Cc [email protected]
Signed-off-by Luca Boccassi <[email protected]>
---
 config/arm/meson.build | 3 +++
 1 file changed, 3 insertions(+)
config/arm/meson.build +3 -0
index 4b23b3954..b75513855 100644
@@ -89,6 +89,9 @@ if cc.sizeof('void *') != 8
 	dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
 	dpdk_conf.set('RTE_ARCH_ARM', 1)
 	dpdk_conf.set('RTE_ARCH_ARMv7', 1)
+	# the minimum architecture supported, armv7-a, needs the following,
+	# mk/machine/armv7a/rte.vars.mk sets it too
+	machine_args += '-mfpu=neon'
 else
 	dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
 	dpdk_conf.set('RTE_ARCH_ARM64', 1)
Signature · 1 line
2.19.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Luca Boccassi

Building on armv7a with meson currenctly fails:

/usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
inlining failed in call to always_inline ‘vld1q_s32’: target specific option mismatch

Quoted 7 lines

Set -mfpu=neon on that architecture like the legacy makefiles do to fix the issue.

Fixes b1d48c41189a ("build: support ARM with meson")
Cc [email protected]
Signed-off-by Luca Boccassi <[email protected]>
Acked-by Christian Ehrhardt <[email protected]>
Quoted 21 lines
---
 config/arm/meson.build | 3 +++
 1 file changed, 3 insertions(+)
config/arm/meson.build +3 -1
index 4b23b3954..b75513855 100644
@@ -89,6 +89,9 @@ if cc.sizeof('void *') != 8
        dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
        dpdk_conf.set('RTE_ARCH_ARM', 1)
        dpdk_conf.set('RTE_ARCH_ARMv7', 1)
+       # the minimum architecture supported, armv7-a, needs the following,
+       # mk/machine/armv7a/rte.vars.mk sets it too
+       machine_args += '-mfpu=neon'
 else
        dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
        dpdk_conf.set('RTE_ARCH_ARM64', 1)
--

2.19.1

Signature · 3 lines
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
Applied
#2 lore raw

15/11/2018 20:29, Christian Ehrhardt:

Quoted 11 lines · Luca Boccassi
Quoted 10 lines

Building on armv7a with meson currenctly fails:

/usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
inlining failed in call to always_inline ‘vld1q_s32’: target specific option mismatch

Set -mfpu=neon on that architecture like the legacy makefiles do to fix the issue.

Quoted 6 lines
Quoted 4 lines
Fixes b1d48c41189a ("build: support ARM with meson")
Cc [email protected]
Signed-off-by Luca Boccassi <[email protected]>
Acked-by Christian Ehrhardt <[email protected]>

Applied, thanks