Add 8qm SMMU information
Subsystems (6)
Frank Li
maintainerv2 cover Add 8qm SMMU information
Change at v2
- Remove iM95 for fec.
To: Ulf Hansson <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Shawn Guo <[email protected]>
To: Sascha Hauer <[email protected]>
To: Pengutronix Kernel Team <[email protected]>
To: Fabio Estevam <[email protected]>
To: NXP Linux Team <[email protected]>
To: Wei Fang <[email protected]>
To: Shenwei Wang <[email protected]>
To: Clark Wang <[email protected]>
To: David S. Miller <[email protected]>
To: Eric Dumazet <[email protected]>
To: Jakub Kicinski <[email protected]>
To: Paolo Abeni <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Frank Li (4):
dt-bindings: mmc: fsl-imx-esdhc: add iommus property
dt-bindings: net: fec: add iommus property
arm64: dts: imx8qm: add smmu node
arm64: dts: imx8qm: add smmu stream id information
.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++ Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++ arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++ 4 files changed, 53 insertions(+)
---
base-commit: 99748ff5ee0953610765e9d0cd6015c2eb0f7ace
change-id: 20240201-8qm_smmu-6318da8e9017
Best regards,
Signature · 1 line
Frank Li <[email protected]>
Frank Li
maintainerPATCH v2 1/4 dt-bindings: mmc: fsl-imx-esdhc: add iommus property
iMX95 and iMX8QM have smmu. Add property "iommus".
--- Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +3 -0
@@ -162,6 +162,9 @@ properties: - const: ahb - const: per + iommus: + maxItems: 1 + power-domains: maxItems: 1
Signature · 1 line
2.34.1
Re: [PATCH v2 1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property
Quoted 4 lines · Frank Li
iMX95 and iMX8QM have smmu. Add property "iommus".
Signed-off-by Frank Li <[email protected]>---
Best regards,
Krzysztof
Re: [PATCH v2 1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property
In reply to Frank LiQuoted 4 lines · Frank Li
iMX95 and iMX8QM have smmu. Add property "iommus".
Signed-off-by Frank Li <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 22 lines
--- Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +3
-1@@ -162,6 +162,9 @@ properties: - const: ahb - const: per + iommus: + maxItems: 1 + power-domains: maxItems: 1 --2.34.1
Frank Li
maintainerPATCH v2 2/4 dt-bindings: net: fec: add iommus property
In reply to Frank LiiMX8QM have iommu. Add proerty 'iommus'.
--- Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/net/fsl,fec.yaml +3 -0
@@ -224,6 +224,9 @@ properties: Can be omitted thus no delay is observed. Delay is in range of 1ms to 1000ms. Other delays are invalid. + iommus: + maxItems: 1 + required: - compatible - reg
Signature · 1 line
2.34.1
Re: [PATCH v2 2/4] dt-bindings: net: fec: add iommus property
Quoted 4 lines · Frank Li
iMX8QM have iommu. Add proerty 'iommus'.
Signed-off-by Frank Li <[email protected]>---
Best regards,
Krzysztof
Frank Li
maintainerRe: [PATCH v2 2/4] dt-bindings: net: fec: add iommus property
Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · Frank Li
iMX8QM have iommu. Add proerty 'iommus'.
Signed-off-by Frank Li <[email protected]>---
Other 3 patches already been linux-next. Who will pick this one?
Frank
Quoted 4 lines
Best regards,
Krzysztof
Re: [PATCH v2 2/4] dt-bindings: net: fec: add iommus property
Quoted 10 lines · Frank Li
Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · Frank Li
iMX8QM have iommu. Add proerty 'iommus'.
Signed-off-by Frank Li <[email protected]>---
Other 3 patches already been linux-next. Who will pick this one?
Resend it to net-next (with proper title).
Best regards,
Krzysztof
Jakub Kicinski
maintainerRe: [PATCH v2 2/4] dt-bindings: net: fec: add iommus property
Quoted 5 lines · On Sat, 17 Feb 2024 09:18:33 +0100 Krzysztof Kozlowski wrote:
Quoted 3 lines
Quoted 1 line
Other 3 patches already been linux-next. Who will pick this one?
Resend it to net-next (with proper title).
I happened to notice the discussion, let me take the v2. Thanks!
Frank Li
maintainerPATCH v2 3/4 arm64: dts: imx8qm: add smmu node
In reply to Frank LiAdd smmu node for imx8qm.
--- arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 +++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)
arch/arm64/boot/dts/freescale/imx8qm.dtsi +41 -0
@@ -265,6 +265,47 @@ timer { <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /* Hypervisor */ }; + smmu: iommu@51400000 { + compatible = "arm,mmu-500"; + interrupt-parent = <&gic>; + reg = <0 0x51400000 0 0x40000>; + #global-interrupts = <1>; + #iommu-cells = <2>; + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; + }; + system-controller { compatible = "fsl,imx-scu"; mbox-names = "tx0",
Signature · 1 line
2.34.1
Shawn Guo
AppliedRe: [PATCH v2 3/4] arm64: dts: imx8qm: add smmu node
Quoted 3 lines · Frank Li
Add smmu node for imx8qm.
Signed-off-by Frank Li <[email protected]>
Applied, thanks!
Frank Li
maintainerPATCH v2 4/4 arm64: dts: imx8qm: add smmu stream id information
In reply to Frank LiAdd smmu stream id information for fec and esdhc.
--- arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi +6 -0
@@ -6,20 +6,26 @@ &fec1 { compatible = "fsl,imx8qm-fec", "fsl,imx6sx-fec"; + iommus = <&smmu 0x12 0x7f80>; }; &fec2 { compatible = "fsl,imx8qm-fec", "fsl,imx6sx-fec"; + iommus = <&smmu 0x12 0x7f80>; }; &usdhc1 { compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; + iommus = <&smmu 0x11 0x7f80>; }; &usdhc2 { compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; + iommus = <&smmu 0x11 0x7f80>; }; &usdhc3 { compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; + iommus = <&smmu 0x11 0x7f80>; }; +
Signature · 1 line
2.34.1
Re: [PATCH v2 4/4] arm64: dts: imx8qm: add smmu stream id information
Quoted 28 lines · Frank Li
Add smmu stream id information for fec and esdhc.
Signed-off-by Frank Li <[email protected]>--- arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi +3
-0@@ -6,20 +6,26 @@ &fec1 { compatible = "fsl,imx8qm-fec", "fsl,imx6sx-fec"; + iommus = <&smmu 0x12 0x7f80>; }; &fec2 { compatible = "fsl,imx8qm-fec", "fsl,imx6sx-fec"; + iommus = <&smmu 0x12 0x7f80>; }; &usdhc1 { compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; + iommus = <&smmu 0x11 0x7f80>; };
arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi line 31
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi +3
-0&usdhc2 { compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; + iommus = <&smmu 0x11 0x7f80>; }; &usdhc3 { compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; + iommus = <&smmu 0x11 0x7f80>; }; +
Dropped this whitespace and applied.
Shawn
Quoted 4 lines
Signature · 2 lines
-- 2.34.1
Jakub Kicinski
maintainerQuoted 9 lines · On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
dt-bindings: mmc: fsl-imx-esdhc: add iommus property
dt-bindings: net: fec: add iommus property
arm64: dts: imx8qm: add smmu node
arm64: dts: imx8qm: add smmu stream id information.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++ Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++ arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++
Any preference on whether all these go via a platform tree, or should we pick up the net patch to netdev? I guess taking the DTB via netdev would be the usual way to handle this?
Frank Li
maintainerQuoted 6 lines · Jakub Kicinski
Quoted 5 lines · On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
dt-bindings: mmc: fsl-imx-esdhc: add iommus property
dt-bindings: net: fec: add iommus property
arm64: dts: imx8qm: add smmu node
arm64: dts: imx8qm: add smmu stream id information
Quoted 8 lines
Quoted 4 lines
.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++ Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++ arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++Any preference on whether all these go via a platform tree, or should we pick up the net patch to netdev? I guess taking the DTB via netdev would be the usual way to handle this?
Supposed dt-bindings go through netdev tree.
without dt-bindings, just DTB_CHECK warning. No strict dependence relationship between dt-bindings doc and dts file.
Frank
Quoted 12 lines · Frank Li
Quoted 11 lines · Jakub Kicinski
Quoted 9 lines · On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
dt-bindings: mmc: fsl-imx-esdhc: add iommus property
dt-bindings: net: fec: add iommus property
arm64: dts: imx8qm: add smmu node
arm64: dts: imx8qm: add smmu stream id information.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++ Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++ arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++
Quoted 8 lines
Quoted 3 lines
Any preference on whether all these go via a platform tree, or should we pick up the net patch to netdev? I guess taking the DTB via netdev would be the usual way to handle this?
Supposed dt-bindings go through netdev tree.
without dt-bindings, just
DTB_CHECKwarning. No strict dependence relationship between dt-bindings doc and dts file.
Please make it easier for maintainers and sent entirely independent patches for different subsystems in SEPARATE patchsets.
There is no dependency here between anything. Combining it, OTOH, brings the questions about such dependency and makes it a bit more difficult to apply for each maintainer.
Best regards,
Krzysztof
Frank Li
maintainerQuoted 22 lines · Krzysztof Kozlowski
Quoted 12 lines · Frank Li
Quoted 11 lines · Jakub Kicinski
Quoted 9 lines · On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
dt-bindings: mmc: fsl-imx-esdhc: add iommus property
dt-bindings: net: fec: add iommus property
arm64: dts: imx8qm: add smmu node
arm64: dts: imx8qm: add smmu stream id information.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++ Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++ arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++Quoted 8 lines
Quoted 3 lines
Any preference on whether all these go via a platform tree, or should we pick up the net patch to netdev? I guess taking the DTB via netdev would be the usual way to handle this?
Supposed dt-bindings go through netdev tree.
without dt-bindings, just
DTB_CHECKwarning. No strict dependence relationship between dt-bindings doc and dts file.
Quoted 6 lines
Please make it easier for maintainers and sent entirely independent patches for different subsystems in SEPARATE patchsets.
There is no dependency here between anything. Combining it, OTOH, brings the questions about such dependency and makes it a bit more difficult to apply for each maintainer.
Understand, but without dts change, it is not easy to understand why need change dt-binding files.
Frank
Quoted 4 lines
Best regards,
Krzysztof
Quoted 6 lines · Jakub Kicinski
Quoted 5 lines · On Thu, 01 Feb 2024 15:22:40 -0500 Frank Li wrote:
dt-bindings: mmc: fsl-imx-esdhc: add iommus property
dt-bindings: net: fec: add iommus property
arm64: dts: imx8qm: add smmu node
arm64: dts: imx8qm: add smmu stream id information
Quoted 8 lines
Quoted 4 lines
.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 3 ++ Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 ++ arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 ++++++++++++++++++++++Any preference on whether all these go via a platform tree, or should we pick up the net patch to netdev? I guess taking the DTB via netdev would be the usual way to handle this?
No, it's not. Taking DTS changes through arch/platform tree is the usual way.
Shawn
Jakub Kicinski
maintainerQuoted 6 lines · On Tue, 6 Feb 2024 18:50:51 +0800 Shawn Guo wrote:
Quoted 3 lines
Any preference on whether all these go via a platform tree, or should we pick up the net patch to netdev? I guess taking the DTB via netdev would be the usual way to handle this?
No, it's not. Taking DTS changes through
arch/platformtree is the usual way.
I said DTB.
Quoted 9 lines · Jakub Kicinski
Quoted 6 lines · On Tue, 6 Feb 2024 18:50:51 +0800 Shawn Guo wrote:
Quoted 3 lines
Any preference on whether all these go via a platform tree, or should we pick up the net patch to netdev? I guess taking the DTB via netdev would be the usual way to handle this?
No, it's not. Taking DTS changes through
arch/platformtree is the usual way.I said DTB.
If the DTB here means Device Tree Blob which is generated by DTC (Device Tree Compiler) taking DTS (Device Tree Source) as input, it's a build result and so neither of us could take.
Shawn
Jakub Kicinski
maintainerQuoted 6 lines · On Fri, 23 Feb 2024 10:07:39 +0800 Shawn Guo wrote:
Quoted 1 line · Jakub Kicinski
I said DTB.
If the DTB here means Device Tree Blob which is generated by DTC (Device Tree Compiler) taking DTS (Device Tree Source) as input, it's a build result and so neither of us could take.
I see, thanks for the explainer, I was referring to DeviceTree/Bindings. I'll say binding next time.
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 26 lines · On Thu, 01 Feb 2024 15:22:40 -0500 you wrote:
Change at v2
- Remove iM95 for fec.To: Ulf Hansson <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Shawn Guo <[email protected]>
To: Sascha Hauer <[email protected]>
To: Pengutronix Kernel Team <[email protected]>
To: Fabio Estevam <[email protected]>
To: NXP Linux Team <[email protected]>
To: Wei Fang <[email protected]>
To: Shenwei Wang <[email protected]>
To: Clark Wang <[email protected]>
To: David S. Miller <[email protected]>
To: Eric Dumazet <[email protected]>
To: Jakub Kicinski <[email protected]>
To: Paolo Abeni <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Quoted 1 line
[...]
Here is the summary with links:
- [v2,1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property (no matching commit)
- [v2,2/4] dt-bindings: net: fec: add iommus property
https://git.kernel.org/netdev/net-next/c/5983e5df8630
- [v2,3/4] arm64: dts: imx8qm: add smmu node
(no matching commit)
- [v2,4/4] arm64: dts: imx8qm: add smmu stream id information (no matching commit)
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html