bpf: hardcode BPF_PROG_PACK_SIZE to 2MB * num_possible_nodes()
PATCH v2 1/1 bpf: hardcode BPF_PROG_PACK_SIZE to 2MB * num_possible_nodes()
On some architectures like ARM64, PMD_SIZE can be really large in some configurations. Like with CONFIG_ARM64_64K_PAGES=y the PMD_SIZE is 512MB.
Use 2MB * num_possible_nodes() as the size for allocations done through the prog pack allocator. On most architectures, PMD_SIZE will be equal to 2MB in case of 4KB pages and will be greater than 2MB for bigger page sizes.
--- kernel/bpf/core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
kernel/bpf/core.c +6 -1
@@ -893,7 +893,12 @@ static LIST_HEAD(pack_list);* CONFIG_MMU=n. Use PAGE_SIZE in these cases. */ #ifdef PMD_SIZE -#define BPF_PROG_PACK_SIZE (PMD_SIZE * num_possible_nodes()) +/* PMD_SIZE is really big for some archs. It doesn't make sense to +* reserve too much memory in one allocation. Hardcode BPF_PROG_PACK_SIZE to +* 2MiB * num_possible_nodes(). On most architectures PMD_SIZE will be +* greater than or equal to 2MB. +*/ +#define BPF_PROG_PACK_SIZE (SZ_2M * num_possible_nodes())#else #define BPF_PROG_PACK_SIZE PAGE_SIZE#endif
Signature · 1 line
2.40.1
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 10 lines · On Mon, 11 Mar 2024 12:27:22 +0000 you wrote:
On some architectures like ARM64,
PMD_SIZEcan be really large in some configurations. Like withCONFIG_ARM64_64K_PAGES=ythePMD_SIZEis 512MB.Use 2MB *
num_possible_nodes()as the size for allocations done through the prog pack allocator. On most architectures,PMD_SIZEwill be equal to 2MB in case of 4KB pages and will be greater than 2MB for bigger page sizes.[...]
Here is the summary with links:
- [bpf-next,v2] bpf: hardcode BPF_PROG_PACK_SIZE to 2MB * num_possible_nodes()
https://git.kernel.org/bpf/bpf-next/c/d6170e4aaf86
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html