s390/qeth: handle deferred cc1
Subsystems (4)
Alexandra Winter
maintainerPATCH v3 1/1 s390/qeth: handle deferred cc1
The IO subsystem expects a driver to retry a ccw_device_start, when the subsequent interrupt response block (irb) contains a deferred condition code 1.
Symptoms before this commit:
On the read channel we always trigger the next read anyhow, so no different behaviour here.
On the write channel we may experience timeout errors, because the expected reply will never be received without the retry. Other callers of qeth_send_control_data() may wrongly assume that the ccw was successful, which may cause problems later.
Note that since
commit 2297791c92d0 ("s390/cio: dont unregister subchannel from child-drivers") and
commit 5ef1dc40ffa6 ("s390/cio: fix invalid -EBUSY on ccw_device_start") deferred CC1s are much more likely to occur. See the commit message of the latter for more background information.
---v1->v2: correct patch formatv2->v3: unlock qeth channel before scheduling recovery
--- drivers/s390/net/qeth_core_main.c | 38 +++++++++++++++++++++++++++++-- 1 file changed, 36 insertions(+), 2 deletions(-)
drivers/s390/net/qeth_core_main.c +36 -2
@@ -1179,6 +1179,20 @@ static int qeth_check_irb_error(struct qeth_card *card, struct ccw_device *cdev, } } +/** +* qeth_irq() - qeth interrupt handler +* @cdev: ccw device +* @intparm: expect pointer to iob +* @irb: Interruption Response Block +* +* In the good path: +* corresponding qeth channel is locked with last used iob as active_cmd. +* But this function is also called for error interrupts. +* +* Caller ensures that: +* Interrupts are disabled; ccw device lock is held; +* +*/ static void qeth_irq (struct ccw_device *cdev,unsigned long intparm,struct irb *irb) {
@@ -1220,11 +1234,10 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm, iob = (struct qeth_cmd_buffer *) (addr_t )intparm; } -qeth_unlock_channel (card, channel); - rc =qeth_check_irb_error (card, cdev, irb);if (rc) {/* IO was terminated, free its resources. */ +qeth_unlock_channel (card, channel);if (iob)qeth_cancel_cmd (iob, rc);return ;
@@ -1268,6 +1281,7 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm, rc =qeth_get_problem (card, cdev, irb);if (rc) { card->read_or_write_problem =1 ; +qeth_unlock_channel (card, channel);if (iob)qeth_cancel_cmd (iob, rc);qeth_clear_ipacmd_list (card);
@@ -1276,6 +1290,26 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm, } } +if (scsw_cmd_is_valid_cc (&irb->scsw) && irb->scsw.cmd.cc ==1 && iob) { +/* channel command hasn't started: retry. +* active_cmd is still set to last iob +*/ +QETH_CARD_TEXT (card,2 ,"irqcc1" ); + rc =ccw_device_start_timeout (cdev,__ccw_from_cmd (iob), + (addr_t )iob,0 ,0 , iob->timeout); +if (rc) { +QETH_DBF_MESSAGE (2 , +"ccw retry on %x failed, rc = %i\n" , +CARD_DEVID (card), rc); +QETH_CARD_TEXT_ (card,2 ," err%d" , rc); +qeth_unlock_channel (card, channel); +qeth_cancel_cmd (iob, rc); + } +return ; + } + +qeth_unlock_channel (card, channel); +if (iob) {/* sanity check: */ if (irb->scsw.cmd.count > iob->length) {
Signature · 1 line
2.40.1
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 12 lines · On Thu, 21 Mar 2024 12:53:37 +0100 you wrote:
The IO subsystem expects a driver to retry a
ccw_device_start, when the subsequent interrupt response block (irb) contains a deferred condition code 1.Symptoms before this commit:
On the read channel we always trigger the next read anyhow, so no different behaviour here.
On the write channel we may experience timeout errors, because the expected reply will never be received without the retry. Other callers ofqeth_send_control_data()may wrongly assume that the ccw was successful, which may cause problems later.
Quoted 1 line
[...]
Here is the summary with links:
- [net,v3] s390/qeth: handle deferred cc1
https://git.kernel.org/netdev/net/c/afb373ff3f54
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html