Skip to contentSkip to conversation

arm: imx9: Correct imx9_probe_mu prototype

PATCH Superseded Ye Li 2 participants 3 messages Mar 28, 2024 – Mar 30, 2024

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH 1/2 arm: imx9: Correct imx9_probe_mu prototype

Since the event callback imx9_probe_mu is re-defined, update its prototype.

---
 arch/arm/include/asm/arch-imx9/mu.h | 2 +-
 board/freescale/imx93_evk/spl.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/include/asm/arch-imx9/mu.h +1 -1
index b860499..649b8a6 100644
@@ -8,6 +8,6 @@
 
 #include <event.h>
 
-int imx9_probe_mu(void *ctx, struct event *event);
+int imx9_probe_mu(void);
 
 #endif
board/freescale/imx93_evk/spl.c +1 -1
index 2fd5559..7331a20 100644
@@ -116,7 +116,7 @@ void board_init_f(ulong dummy)
 
 	preloader_console_init();
 
-	ret = imx9_probe_mu(NULL, NULL);
+	ret = imx9_probe_mu();
 	if (ret) {
 		printf("Fail to init Sentinel API\n");
 	} else {
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 arm: imx9: Call imx9_probe_mu for DM post in board_r

This event callback imx9_probe_mu needs to be called in board_r as well, because many ELE APIs depending on this MU probed

---
 arch/arm/mach-imx/imx9/soc.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/imx9/soc.c +1 -0
index f06339f..15e87b8 100644
@@ -622,6 +622,7 @@ int imx9_probe_mu(void)
 	return 0;
 }
 EVENT_SPY_SIMPLE(EVT_DM_POST_INIT_F, imx9_probe_mu);
+EVENT_SPY_SIMPLE(EVT_DM_POST_INIT_R, imx9_probe_mu);
 
 int timer_init(void)
 {
Signature · 1 line
2.7.4
reviewer
#2 lore raw
In reply to Ye Li

board/freescale/imx93_evk/spl.c void board_init_f(ulong dummy) · line 119

Quoted 2 lines · Ye Li
board/freescale/imx93_evk/spl.c +1 -1
-       ret = imx9_probe_mu(NULL, NULL);
+       ret = imx9_probe_mu();

This series breaks the build because you missed updating phycore_imx93 and imx93_var_som:

board/phytec/phycore_imx93/spl.c: ret = imx9_probe_mu(NULL, NULL);
board/variscite/imx93_var_som/spl.c: ret = imx9_probe_mu(NULL, NULL);

Please fix and resend.