Skip to contentSkip to conversation

octeontx2-pf: Fix transmit scheduler resource leak

PATCH Applied Hariprasad Kelam 2 participants 2 messages Apr 4, 2024 – Apr 7, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 octeontx2-pf: Fix transmit scheduler resource leak

Inorder to support shaping and scheduling, Upon class creation Netdev driver allocates trasmit schedulers.

The previous patch which added support for Round robin scheduling has a bug due to which driver is not freeing transmit schedulers post class deletion.

This patch fixes the same.

Fixes 47a9656f168a ("octeontx2-pf: htb offload support for Round Robin scheduling")
---
 drivers/net/ethernet/marvell/octeontx2/nic/qos.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/marvell/octeontx2/nic/qos.c +1 -0
index 1e77bbf5d22a..1723e9912ae0 100644
@@ -382,6 +382,7 @@ static void otx2_qos_read_txschq_cfg_tl(struct otx2_qos_node *parent,
 		otx2_qos_read_txschq_cfg_tl(node, cfg);
 		cnt = cfg->static_node_pos[node->level];
 		cfg->schq_contig_list[node->level][cnt] = node->schq;
+		cfg->schq_index_used[node->level][cnt] = true;
 		cfg->schq_contig[node->level]++;
 		cfg->static_node_pos[node->level]++;
 		otx2_qos_read_txschq_cfg_schq(node, cfg);
Signature · 1 line
2.17.1
#1 lore raw
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Thu, 4 Apr 2024 16:54:27 +0530 you wrote:

Inorder to support shaping and scheduling, Upon class creation Netdev driver allocates trasmit schedulers.

The previous patch which added support for Round robin scheduling has a bug due to which driver is not freeing transmit schedulers post class deletion.

[...]

Here is the summary with links:
- [net] octeontx2-pf: Fix transmit scheduler resource leak

    https://git.kernel.org/netdev/net/c/bccb798e07f8

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html