inet: frags: delay fqdir_free_fn()
Subsystems (3)
PATCH 1/1 inet: frags: delay fqdir_free_fn()
fqdir_free_fn() is using very expensive rcu_barrier()
When one netns is dismantled, we often call fqdir_exit() multiple times, typically lauching fqdir_free_fn() twice.
Delaying by one second fqdir_free_fn() helps to reduce the number of rcu_barrier() calls, and lock contention on rcu_state.barrier_mutex.
--- net/ipv4/inet_fragment.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/ipv4/inet_fragment.c +2 -2
@@ -175,7 +175,7 @@ static void fqdir_free_fn(struct work_struct *work) } } -static DECLARE_WORK(fqdir_free_work, fqdir_free_fn); +static DECLARE_DELAYED_WORK(fqdir_free_work, fqdir_free_fn);static void fqdir_work_fn (struct work_struct *work) {
@@ -184,7 +184,7 @@ static void fqdir_work_fn(struct work_struct *work)rhashtable_free_and_destroy (&fqdir->rhashtable, inet_frags_free_cb,NULL );if (llist_add (&fqdir->free_list, &fqdir_free_list)) -queue_work (system_wq, &fqdir_free_work); +queue_delayed_work (system_wq, &fqdir_free_work,HZ ); }int fqdir_init (struct fqdir **fqdirp,struct inet_frags *f,struct net *net)
Signature · 1 line
2.44.0.478.gd926399ef9-goog
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Quoted 10 lines · On Thu, 4 Apr 2024 13:07:51 +0000 you wrote:
fqdir_free_fn()is using very expensivercu_barrier()When one netns is dismantled, we often call
fqdir_exit()multiple times, typically lauchingfqdir_free_fn()twice.Delaying by one second
fqdir_free_fn()helps to reduce the number ofrcu_barrier()calls, and lock contention on rcu_state.barrier_mutex.[...]
Here is the summary with links:
- [net-next] inet: frags: delay fqdir_free_fn()
https://git.kernel.org/netdev/net-next/c/802e12ff9cbf
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html