r8169: add missing conditional compiling for call to r8169_remove_leds
Heiner Kallweit
maintainerPATCH 1/1 r8169: add missing conditional compiling for call to r8169_remove_leds
Add missing dependency on CONFIG_R8169_LEDS. As-is a link error occurs if config option CONFIG_R8169_LEDS isn't enabled.
--- drivers/net/ethernet/realtek/r8169_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/realtek/r8169_main.c +2 -1
@@ -5046,7 +5046,8 @@ static void rtl_remove_one(struct pci_dev *pdev)cancel_work_sync (&tp->wk.work); -r8169_remove_leds (tp->leds); +if (IS_ENABLED (CONFIG_R8169_LEDS )) +r8169_remove_leds (tp->leds);unregister_netdev (tp->dev);
Signature · 1 line
2.44.0
Applied the patch and verified the reported issue.
Kernel compilation is successful on PowerPC with this patch.
Quoted 24 lines · Heiner Kallweit
Add missing dependency on
CONFIG_R8169_LEDS. As-is a link error occurs if config optionCONFIG_R8169_LEDSisn't enabled.Fixes 19fa4f2a85d7 ("r8169: fix LED-related deadlock on module removal")Reported-by Venkat Rao Bagalkote <[email protected]>Signed-off-by Heiner Kallweit <[email protected]>--- drivers/net/ethernet/realtek/r8169_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/ethernet/realtek/r8169_main.c +2
-1@@ -5046,7 +5046,8 @@ static void rtl_remove_one(struct pci_dev *pdev)cancel_work_sync (&tp->wk.work); -r8169_remove_leds (tp->leds); +if (IS_ENABLED (CONFIG_R8169_LEDS )) +r8169_remove_leds (tp->leds);unregister_netdev (tp->dev);
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 10 Apr 2024 15:11:28 +0200 you wrote:
Add missing dependency on
CONFIG_R8169_LEDS. As-is a link error occurs if config optionCONFIG_R8169_LEDSisn't enabled.Fixes 19fa4f2a85d7 ("r8169: fix LED-related deadlock on module removal")Reported-by Venkat Rao Bagalkote <[email protected]>Signed-off-by Heiner Kallweit <[email protected]>[...]
Here is the summary with links:
- [net] r8169: add missing conditional compiling for call to r8169_remove_leds
https://git.kernel.org/netdev/net/c/97e176fcbbf3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html