Skip to contentSkip to conversation

flow_offload: fix flow_offload_has_one_action() kdoc

PATCH Applied Asbjørn Sloth Tønnesen 4 participants 5 messages Apr 10, 2024 – Apr 12, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 flow_offload: fix flow_offload_has_one_action() kdoc

include/net/flow_offload.h:351: warning:
No description found for return value of 'flow_offload_has_one_action'

Fixes ab79af32b0a5 ("mlxsw: use intermediate representation for matchall offload")
---
 include/net/flow_offload.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/flow_offload.h +1 -1
index 314087a5e1818..7726b4a97050e 100644
@@ -345,7 +345,7 @@ static inline bool flow_action_has_entries(const struct flow_action *action)
  * flow_offload_has_one_action() - check if exactly one action is present
  * @action: tc filter flow offload action
  *
- * Returns true if exactly one action is present.
+ * Return: true if exactly one action is present.
  */
 static inline bool flow_offload_has_one_action(const struct flow_action *action)
 {
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw

[Removed my old email address from CC]

This LGTM, thank you.

Quoted 22 lines · Asbjørn Sloth Tønnesen

include/net/flow_offload.h:351: warning:
No description found for return value of 'flow_offload_has_one_action'

Fixes ab79af32b0a5 ("mlxsw: use intermediate representation for matchall offload")
---
 include/net/flow_offload.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/flow_offload.h +1 -1
index 314087a5e1818..7726b4a97050e 100644
@@ -345,7 +345,7 @@ static inline bool flow_action_has_entries(const struct flow_action *action)
  * flow_offload_has_one_action() - check if exactly one action is present
  * @action: tc filter flow offload action
  *
- * Returns true if exactly one action is present.
+ * Return: true if exactly one action is present.
  */
 static inline bool flow_offload_has_one_action(const struct flow_action *action)
 {
maintainer
#2 lore raw
Quoted 5 lines · On Thu, 11 Apr 2024 12:32:44 +0100 Pieter Jansen van Vuuren wrote:

[Removed my old email address from CC]

This LGTM, thank you.

Thanks Pieter! :)

Consider adding a .mailmap entry to remap the email addr. We already have Simon, Quentin and myself there, from @netronome :)

#3 lore raw
Quoted 12 lines · Jakub Kicinski
Quoted 5 lines · On Thu, 11 Apr 2024 12:32:44 +0100 Pieter Jansen van Vuuren wrote:

[Removed my old email address from CC]

This LGTM, thank you.

Thanks Pieter! :)

Consider adding a .mailmap entry to remap the email addr. We already have Simon, Quentin and myself there, from @netronome :)

Thank you Kuba, will do.

#4 lore raw
In reply to Asbjørn Sloth Tønnesen
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Wed, 10 Apr 2024 11:47:17 +0000 you wrote:

include/net/flow_offload.h:351: warning:
No description found for return value of 'flow_offload_has_one_action'

Fixes ab79af32b0a5 ("mlxsw: use intermediate representation for matchall offload")
---
 include/net/flow_offload.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net-next] flow_offload: fix flow_offload_has_one_action() kdoc

    https://git.kernel.org/netdev/net-next/c/e1eb10f8ef10

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html