net/handshake: remove redundant assignment to variable ret
Subsystems (4)
PATCH 1/1 net/handshake: remove redundant assignment to variable ret
The variable is being assigned an value and then is being re-assigned a new value in the next statement. The assignment is redundant and can be removed.
Cleans up clang scan build warning:net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores]
--- net/handshake/tlshd.c | 1 - 1 file changed, 1 deletion(-)
net/handshake/tlshd.c +0 -1
@@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req,if (!hdr) goto out_cancel; - ret = -EMSGSIZE ; ret =nla_put_s32 (msg,HANDSHAKE_A_ACCEPT_SOCKFD , fd);if (ret <0 ) goto out_cancel;
Signature · 1 line
2.39.2
Quoted 10 lines · Colin Ian King
The variable is being assigned an value and then is being re-assigned a new value in the next statement. The assignment is redundant and can be removed.
Cleans up clang scan build warning:
net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>
Quoted 29 lines · Colin Ian King
The variable is being assigned an value and then is being re-assigned a new value in the next statement. The assignment is redundant and can be removed.
Cleans up clang scan build warning:
net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>--- net/handshake/tlshd.c | 1 - 1 file changed, 1 deletion(-)net/handshake/tlshd.c +0
-1@@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req,if (!hdr) goto out_cancel; - ret = -EMSGSIZE ; ret =nla_put_s32 (msg,HANDSHAKE_A_ACCEPT_SOCKFD , fd);if (ret <0 ) goto out_cancel;Signature · 1 line
2.39.2
Signature · 1 line
Chuck Lever
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Mon, 15 Apr 2024 11:07:13 +0100 you wrote:
The variable is being assigned an value and then is being re-assigned a new value in the next statement. The assignment is redundant and can be removed.
Cleans up clang scan build warning:
net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores][...]
Here is the summary with links:
- [next] net/handshake: remove redundant assignment to variable ret
https://git.kernel.org/netdev/net-next/c/c2b640529ec7
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html