net: dsa: felix: flower: validate control flags
Subsystems (4)
PATCH 1/1 net: dsa: felix: flower: validate control flags
This driver currently doesn't support any control flags.
Use flow_rule_match_has_control_flags() to check for control flags, such as can be set through tc flower ... ip_flags frag.
In case any control flags are masked, flow_rule_match_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP.
Only compile-tested.
--- drivers/net/dsa/ocelot/felix_vsc9959.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/dsa/ocelot/felix_vsc9959.c +3 -0
@@ -1755,6 +1755,9 @@ static int vsc9959_stream_identify(struct flow_cls_offload *f, BIT_ULL(FLOW_DISSECTOR_KEY_ETH_ADDRS)))return -EOPNOTSUPP ; +if (flow_rule_match_has_control_flags (rule, f->common.extack)) +return -EOPNOTSUPP ; +if (flow_rule_match_key (rule,FLOW_DISSECTOR_KEY_ETH_ADDRS )) {struct flow_match_eth_addrs match;
Signature · 1 line
2.43.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 17 Apr 2024 14:44:06 +0000 you wrote:
This driver currently doesn't support any control flags.
Use
flow_rule_match_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_match_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.[...]
Here is the summary with links:
- [net-next] net: dsa: felix: flower: validate control flags
https://git.kernel.org/netdev/net-next/c/b1bf8600572d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html