Skip to contentSkip to conversation

clk: exynos5250: save/restore EPLL0 configuration

PATCH In review Sachin Kamat 4 participants 21 messages Nov 8, 2013 – Jan 2, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 clk: exynos5250: save/restore EPLL0 configuration

From: Andrew Bresticker <[email protected]>

The EPLL configuration register needs to be saved across suspend/resume.

---
 drivers/clk/samsung/clk-exynos5250.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/samsung/clk-exynos5250.c +1 -0
index ee866e377c80..6767635dc895 100644
@@ -143,6 +143,7 @@ static unsigned long exynos5250_clk_regs[] __initdata = {
 	SRC_CPU,
 	DIV_CPU0,
 	SRC_CORE1,
+	EPLL_CON0,
 	SRC_TOP0,
 	SRC_TOP2,
 	SRC_TOP3,
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/3 clk: exynos5250: save/restore EPLL0 configuration

Quoted 24 lines · Sachin Kamat

From: Andrew Bresticker <[email protected]>

The EPLL configuration register needs to be saved across suspend/resume.

---
 drivers/clk/samsung/clk-exynos5250.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/samsung/clk-exynos5250.c +1 -1
index ee866e377c80..6767635dc895 100644
@@ -143,6 +143,7 @@ static unsigned long exynos5250_clk_regs[] __initdata = {
        SRC_CPU,
        DIV_CPU0,
        SRC_CORE1,
+       EPLL_CON0,
        SRC_TOP0,
        SRC_TOP2,
        SRC_TOP3,
--
Quoted 2 lines

1.7.9.5

Forgot to mention that this series is based on top of Tomasz Figa's Exynos5250 cleanup series.
http://www.spinics.net/lists/arm-kernel/msg280039.html

Signature · 2 lines
With warm regards,
Sachin
#2 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

In reply to Sachin Kamat

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

---
 drivers/clk/samsung/clk-exynos5250.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/samsung/clk-exynos5250.c +2 -2
index 6767635dc895..986464c2339a 100644
@@ -562,8 +562,8 @@ static struct samsung_gate_clock exynos5250_gate_clks[] __initdata = {
 	GATE(hdmi, "hdmi", "mout_aclk200_disp1_sub", GATE_IP_DISP1, 6, 0, 0),
 
 	GATE(mfc, "mfc", "mout_aclk333_sub", GATE_IP_MFC, 0, 0, 0),
-	GATE(smmu_mfcl, "smmu_mfcl", "mout_aclk333_sub", GATE_IP_MFC, 1, 0, 0),
-	GATE(smmu_mfcr, "smmu_mfcr", "mout_aclk333_sub", GATE_IP_MFC, 2, 0, 0),
+	GATE(smmu_mfcl, "smmu_mfcl", "mout_aclk333_sub", GATE_IP_MFC, 2, 0, 0),
+	GATE(smmu_mfcr, "smmu_mfcr", "mout_aclk333_sub", GATE_IP_MFC, 1, 0, 0),
 
 	GATE(rotator, "rotator", "div_aclk266", GATE_IP_GEN, 1, 0, 0),
 	GATE(jpeg, "jpeg", "div_aclk166", GATE_IP_GEN, 2, 0, 0),
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

Best regards,
Tomasz

#4 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Hi Tomasz,

Quoted 11 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

Yes, there is a mistake in the TRM in this case.

Quoted 4 lines

I guess you are sure about this, so:

Thanks.

Signature · 2 lines
With warm regards,
Sachin
#5 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

In reply to Tomasz Figa

Hi Tomasz,

Quoted 9 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Quoted 6 lines

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

I believe you are going to take this through your tree along with a few others which you have already reviewed?

Signature · 2 lines
With warm regards,
Sachin
#6 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Hi Sachin,

2013/12/18 Sachin Kamat <[email protected]>:

Quoted 15 lines

Hi Tomasz,

Quoted 12 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

Quoted 6 lines
Quoted 3 lines

I guess you are sure about this, so:

I believe you are going to take this through your tree along with a few others which you have already reviewed?

Thanks for reminding me about this patch. It's been quite a while since it was posted
to the list.

Yes, I will apply it to samsung-clk tree.

Best regards,
Tomasz

#7 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Quoting Tomasz Figa (2013-12-18 10:28:57)

Quoted 22 lines

Hi Sachin,

2013/12/18 Sachin Kamat <[email protected]>:

Quoted 19 lines

Hi Tomasz,

Quoted 15 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

Quoted 8 lines
Quoted 2 lines

I believe you are going to take this through your tree along with a few others which you have already reviewed?

Thanks for reminding me about this patch. It's been quite a while since it was posted
to the list.

Yes, I will apply it to samsung-clk tree.

Feel free to add my Ack when you apply it. Will these be sent later as a pull request for the clk tree?

Regards,
Mike

Quoted 3 lines

Best regards,
Tomasz

#8 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Quoted 26 lines · On Wednesday 18 of December 2013 11:24:30 Mike Turquette wrote:

Quoting Tomasz Figa (2013-12-18 10:28:57)

Quoted 25 lines

Hi Sachin,

2013/12/18 Sachin Kamat <[email protected]>:

Quoted 21 lines

Hi Tomasz,

Quoted 9 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Quoted 6 lines

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

I believe you are going to take this through your tree along with a few others which you have already reviewed?

Quoted 8 lines
Quoted 5 lines

Thanks for reminding me about this patch. It's been quite a while since it was posted
to the list.

Yes, I will apply it to samsung-clk tree.

Feel free to add my Ack when you apply it. Will these be sent later as a pull request for the clk tree?

Yes. That's the plan. :)

Best regards,
Tomasz

#9 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

In reply to Sachin Kamat

Hi Sachin, Andrew,

Quoted 15 lines · On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:

Hi Tomasz,

Quoted 12 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

Quoted 6 lines
Quoted 3 lines

I guess you are sure about this, so:

I believe you are going to take this through your tree along with a few others which you have already reviewed?

This patch seems to depend on my Exynos 5250 clock clean-up series, which will be merged for 3.14. Are you okay with this patch being merged for 3.14 as well or this fix is needed for earlier kernel versions too? (It is not a regression introduced in 3.13, though.)

Best regards,
Tomasz

#10 lore raw

PATCH 2/3 clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Hi Tomasz,

Quoted 22 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 19 lines · On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:

Hi Tomasz,

Quoted 15 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

Quoted 7 lines
Quoted 2 lines

I believe you are going to take this through your tree along with a few others which you have already reviewed?

This patch seems to depend on my Exynos 5250 clock clean-up series, which will be merged for 3.14. Are you okay with this patch being merged for 3.14 as well or this fix is needed for earlier kernel versions too? (It is not a regression introduced in 3.13, though.)

Yes, I did rebase it on top of your series along with other patches. Though not a regression introduced in 3.13, I think it makes sense to have this sent as a fix during this release (3.13) itself. Let me know if you want me to base it
on top of 3.13-rc4 and re-send.

Signature · 2 lines
With warm regards,
Sachin
#11 lore raw

Re: [PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Quoted 33 lines · On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:

Hi Tomasz,

Quoted 22 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 19 lines · On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:

Hi Tomasz,

Quoted 15 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

Quoted 7 lines
Quoted 2 lines

I believe you are going to take this through your tree along with a few others which you have already reviewed?

This patch seems to depend on my Exynos 5250 clock clean-up series, which will be merged for 3.14. Are you okay with this patch being merged for 3.14 as well or this fix is needed for earlier kernel versions too? (It is not a regression introduced in 3.13, though.)

Quoted 5 lines

Yes, I did rebase it on top of your series along with other patches. Though not a regression introduced in 3.13, I think it makes sense to have this sent as a fix during this release (3.13) itself. Let me know if you want me to base it
on top of 3.13-rc4 and re-send.

Since this is just a trivial fix, let me do it myself when applying.

Best regards,
Tomasz

#12 lore raw

Re: [PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Quoted 34 lines · Tomasz Figa
Quoted 33 lines · On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:

Hi Tomasz,

Quoted 29 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 15 lines · On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:

Hi Tomasz,

Quoted 12 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

Quoted 6 lines
Quoted 3 lines

I guess you are sure about this, so:

I believe you are going to take this through your tree along with a few others which you have already reviewed?

This patch seems to depend on my Exynos 5250 clock clean-up series, which will be merged for 3.14. Are you okay with this patch being merged for 3.14 as well or this fix is needed for earlier kernel versions too? (It is not a regression introduced in 3.13, though.)

Quoted 8 lines
Quoted 5 lines

Yes, I did rebase it on top of your series along with other patches. Though not a regression introduced in 3.13, I think it makes sense to have this sent as a fix during this release (3.13) itself. Let me know if you want me to base it
on top of 3.13-rc4 and re-send.

Since this is just a trivial fix, let me do it myself when applying.

Thanks Tomasz.

Signature · 2 lines
With warm regards,
Sachin
#13 lore raw

Re: [PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Quoted 41 lines · On Saturday 21 of December 2013 09:37:06 Sachin Kamat wrote:
Quoted 40 lines · Tomasz Figa
Quoted 38 lines · On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:

Hi Tomasz,

Quoted 22 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 19 lines · On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:

Hi Tomasz,

Quoted 15 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

Quoted 7 lines
Quoted 2 lines

I believe you are going to take this through your tree along with a few others which you have already reviewed?

This patch seems to depend on my Exynos 5250 clock clean-up series, which will be merged for 3.14. Are you okay with this patch being merged for 3.14 as well or this fix is needed for earlier kernel versions too? (It is not a regression introduced in 3.13, though.)

Yes, I did rebase it on top of your series along with other patches. Though not a regression introduced in 3.13, I think it makes sense to have this sent as a fix during this release (3.13) itself. Let me know if you want me to base it
on top of 3.13-rc4 and re-send.

Quoted 4 lines
Quoted 2 lines

Since this is just a trivial fix, let me do it myself when applying.

Thanks Tomasz.

Applied onto fixes branch.

Best regards,
Tomasz

#14 lore raw

Re: [PATCH 2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Quoted 42 lines · Tomasz Figa
Quoted 41 lines · On Saturday 21 of December 2013 09:37:06 Sachin Kamat wrote:
Quoted 40 lines · Tomasz Figa
Quoted 38 lines · On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:

Hi Tomasz,

Quoted 22 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 19 lines · On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:

Hi Tomasz,

Quoted 15 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 5 lines · On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e. GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though.

I guess you are sure about this, so:

Quoted 7 lines
Quoted 2 lines

I believe you are going to take this through your tree along with a few others which you have already reviewed?

This patch seems to depend on my Exynos 5250 clock clean-up series, which will be merged for 3.14. Are you okay with this patch being merged for 3.14 as well or this fix is needed for earlier kernel versions too? (It is not a regression introduced in 3.13, though.)

Yes, I did rebase it on top of your series along with other patches. Though not a regression introduced in 3.13, I think it makes sense to have this sent as a fix during this release (3.13) itself. Let me know if you want me to base it
on top of 3.13-rc4 and re-send.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Since this is just a trivial fix, let me do it myself when applying.

Thanks Tomasz.

Applied onto fixes branch.

Thanks Tomasz. But did not find this on your fixes branch [1]. Not yet pushed out, maybe?

[1] git://git.kernel.org/pub/scm/linux/kernel/git/tfiga/samsung-clk.git

Signature · 2 lines
With warm regards,
Sachin
#15 lore raw

PATCH 3/3 clk: exynos5250: register APLL rate table

In reply to Sachin Kamat

From: Andrew Bresticker <[email protected]>

Register the APLL rate table so that we can set the APLL rate from the cpufreq driver.

---
 drivers/clk/samsung/clk-exynos5250.c |   25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)
drivers/clk/samsung/clk-exynos5250.c +24 -1
index 986464c2339a..80f652053cb5 100644
@@ -667,6 +667,27 @@ static struct samsung_pll_rate_table epll_24mhz_tbl[] __initdata = {
 	{ },
 };
 
+static struct samsung_pll_rate_table apll_24mhz_tbl[] __initdata = {
+	/* sorted in descending order */
+	/* PLL_35XX_RATE(rate, m, p, s) */
+	PLL_35XX_RATE(1700000000, 425, 6, 0),
+	PLL_35XX_RATE(1600000000, 200, 3, 0),
+	PLL_35XX_RATE(1500000000, 250, 4, 0),
+	PLL_35XX_RATE(1400000000, 175, 3, 0),
+	PLL_35XX_RATE(1300000000, 325, 6, 0),
+	PLL_35XX_RATE(1200000000, 200, 4, 0),
+	PLL_35XX_RATE(1100000000, 275, 6, 0),
+	PLL_35XX_RATE(1000000000, 125, 3, 0),
+	PLL_35XX_RATE(900000000, 150, 4, 0),
+	PLL_35XX_RATE(800000000, 100, 3, 0),
+	PLL_35XX_RATE(700000000, 175, 3, 1),
+	PLL_35XX_RATE(600000000, 200, 4, 1),
+	PLL_35XX_RATE(500000000, 125, 3, 1),
+	PLL_35XX_RATE(400000000, 100, 3, 1),
+	PLL_35XX_RATE(300000000, 200, 4, 2),
+	PLL_35XX_RATE(200000000, 100, 3, 2),
+};
+
 static struct samsung_pll_clock exynos5250_plls[nr_plls] __initdata = {
 	[apll] = PLL_A(pll_35xx, fout_apll, "fout_apll", "fin_pll", APLL_LOCK,
 		APLL_CON0, "fout_apll", NULL),
@@ -707,8 +728,10 @@ static void __init exynos5250_clk_init(struct device_node *np)
 	samsung_clk_register_mux(exynos5250_pll_pmux_clks,
 				ARRAY_SIZE(exynos5250_pll_pmux_clks));
 
-	if (_get_rate("fin_pll") == 24 * MHZ)
+	if (_get_rate("fin_pll") == 24 * MHZ) {
 		exynos5250_plls[epll].rate_table = epll_24mhz_tbl;
+		exynos5250_plls[apll].rate_table = apll_24mhz_tbl;
+	}
 
 	if (_get_rate("mout_vpllsrc") == 24 * MHZ)
 		exynos5250_plls[vpll].rate_table =  vpll_24mhz_tbl;
Signature · 1 line
1.7.9.5
#16 lore raw

PATCH 3/3 clk: exynos5250: register APLL rate table

Hi Sachin, Andrew,

Quoted 10 lines · On Friday 08 of November 2013 15:44:08 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

Register the APLL rate table so that we can set the APLL rate from the cpufreq driver.

---
 drivers/clk/samsung/clk-exynos5250.c |   25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

You know that you still need to fix the cpufreq driver to use these, don't you? Anyway:

Best regards,
Tomasz

#17 lore raw

PATCH 3/3 clk: exynos5250: register APLL rate table

Hi Tomasz,

Quoted 14 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 10 lines · On Friday 08 of November 2013 15:44:08 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

Register the APLL rate table so that we can set the APLL rate from the cpufreq driver.

---
 drivers/clk/samsung/clk-exynos5250.c |   25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)
Quoted 4 lines

You know that you still need to fix the cpufreq driver to use these, don't you? Anyway:

This one too needs to be applied to your tree.

Signature · 2 lines
With warm regards,
Sachin
#18 lore raw

PATCH 3/3 clk: exynos5250: register APLL rate table

Quoted 17 lines · Sachin Kamat

Hi Tomasz,

Quoted 14 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 10 lines · On Friday 08 of November 2013 15:44:08 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

Register the APLL rate table so that we can set the APLL rate from the cpufreq driver.

---
 drivers/clk/samsung/clk-exynos5250.c |   25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)
Quoted 6 lines
Quoted 4 lines

You know that you still need to fix the cpufreq driver to use these, don't you? Anyway:

This one too needs to be applied to your tree.

Ping Tomasz.

Signature · 2 lines
With warm regards,
Sachin
Applied
#19 lore raw

PATCH 3/3 clk: exynos5250: register APLL rate table

Quoted 18 lines · On Tuesday 31 of December 2013 08:46:14 Sachin Kamat wrote:
Quoted 17 lines · Sachin Kamat

Hi Tomasz,

Quoted 14 lines · Tomasz Figa

Hi Sachin, Andrew,

Quoted 10 lines · On Friday 08 of November 2013 15:44:08 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

Register the APLL rate table so that we can set the APLL rate from the cpufreq driver.

---
 drivers/clk/samsung/clk-exynos5250.c |   25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

You know that you still need to fix the cpufreq driver to use these, don't you? Anyway:

This one too needs to be applied to your tree.

Ping Tomasz.

Applied.

Best regards,
Tomasz

#20 lore raw

PATCH 1/3 clk: exynos5250: save/restore EPLL0 configuration

In reply to Sachin Kamat

Hi Sachin, Andrew,

Quoted 16 lines · On Friday 08 of November 2013 15:44:06 Sachin Kamat wrote:

From: Andrew Bresticker <[email protected]>

The EPLL configuration register needs to be saved across suspend/resume.

---
 drivers/clk/samsung/clk-exynos5250.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/samsung/clk-exynos5250.c +0 -0
index ee866e377c80..6767635dc895 100644

drivers/clk/samsung/clk-exynos5250.c static unsigned long exynos5250_clk_regs[] __initdata = { · line 146

Quoted 4 lines
drivers/clk/samsung/clk-exynos5250.c +1 -0
@@ -143,6 +143,7 @@ static unsigned long exynos5250_clk_regs[] __initdata = {
 	SRC_CPU,
 	DIV_CPU0,
 	SRC_CORE1,
+	EPLL_CON0,

What about EPLL_CON1 and EPLL_CON2? Also, have you considered register restoration order?

Anyway, I believe it's not the correct way to restore PLL configuration. See my Samsung PM consolidation series, especially patch [1] to see my proposed way of handling this. (Beware of a bug that snuck into this patch
- samsung_clk_save() is not being called for PLL registers.)

[1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/24078/focus=24087

Best regards,
Tomasz