Skip to contentSkip to conversation

bridge/br_netlink.c: no need to return void function

PATCH Applied Hangbin Liu 3 participants 3 messages Apr 19, 2024 – Apr 22, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bridge/br_netlink.c: no need to return void function

br_info_notify is a void function. There is no need to return.

Fixes b6d0425b816e ("bridge: cfm: Netlink Notifications.")
---
 net/bridge/br_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bridge/br_netlink.c +1 -1
index 2cf4fc756263..f17dbac7d828 100644
@@ -667,7 +667,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
 {
 	u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
 
-	return br_info_notify(event, br, port, filter);
+	br_info_notify(event, br, port, filter);
 }
 
 /*
Signature · 1 line
2.43.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Hangbin Liu

br_info_notify is a void function. There is no need to return.

Fixes b6d0425b816e ("bridge: cfm: Netlink Notifications.")
---
  net/bridge/br_netlink.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
net/bridge/br_netlink.c +0 -0
index 2cf4fc756263..f17dbac7d828 100644

net/bridge/br_netlink.c void br_ifinfo_notify(int event, const struct net_bridge *br, · line 673

Quoted 8 lines
net/bridge/br_netlink.c +1 -1
@@ -667,7 +667,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
  {
  	u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
 
-	return br_info_notify(event, br, port, filter);
+	br_info_notify(event, br, port, filter);
  }
 
  /*
#2 lore raw
In reply to Hangbin Liu
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 7 lines · On Fri, 19 Apr 2024 16:02:00 +0800 you wrote:

br_info_notify is a void function. There is no need to return.

Fixes b6d0425b816e ("bridge: cfm: Netlink Notifications.")
---
 net/bridge/br_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net] bridge/br_netlink.c: no need to return void function

    https://git.kernel.org/netdev/net/c/4fd1edcdf13c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html