RDMA/mana_ib: fix missing ret value
Subsystems (2)
PATCH 1/1 RDMA/mana_ib: fix missing ret value
From: Konstantin Taranov <[email protected]>
Set ret to -ENODEV when netdev_master_upper_dev_get_rcu returns NULL.
--- drivers/infiniband/hw/mana/device.c | 1 + 1 file changed, 1 insertion(+)
drivers/infiniband/hw/mana/device.c +1 -0
@@ -87,6 +87,7 @@ static int mana_ib_probe(struct auxiliary_device *adev, upper_ndev =netdev_master_upper_dev_get_rcu (mc->ports[0 ]);if (!upper_ndev) {rcu_read_unlock (); + ret = -ENODEV ;ibdev_err (&dev->ib_dev,"Failed to get master netdev" ); goto free_ib_device; }
Signature · 1 line
2.43.0
Quoted 10 lines · Konstantin Taranov
From: Konstantin Taranov <[email protected]>
Set ret to
-ENODEVwhennetdev_master_upper_dev_get_rcureturns NULL.Fixes 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")Signed-off-by Konstantin Taranov <[email protected]>--- drivers/infiniband/hw/mana/device.c | 1 + 1 file changed, 1 insertion(+)
Applied to for-next, thanks
Jason
Quoted 6 lines · Jason Gunthorpe
Quoted 5 lines · Konstantin Taranov
From: Konstantin Taranov <[email protected]>
Set ret to
-ENODEVwhennetdev_master_upper_dev_get_rcureturns NULL.
Quoted 7 lines
Quoted 5 lines
Fixes 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")Signed-off-by Konstantin Taranov <[email protected]>--- drivers/infiniband/hw/mana/device.c | 1 + 1 file changed, 1 insertion(+)Applied to for-next, thanks
So, what's wrong with my patch that had been sent _before_ this one? At bare minimum I would like to see an explanation.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Jason Gunthorpe
Quoted 10 lines · Konstantin Taranov
From: Konstantin Taranov <[email protected]>
Set ret to
-ENODEVwhennetdev_master_upper_dev_get_rcureturns NULL.Fixes 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")Signed-off-by Konstantin Taranov <[email protected]>--- drivers/infiniband/hw/mana/device.c | 1 + 1 file changed, 1 insertion(+)
Quoted 3 lines
Quoted 1 line
Applied to for-next, thanks
So, what's wrong with my patch that had been sent _before_ this one?
Was it?
This patch:
$ date -d 'Tue, 23 Apr 2024 07:15:51 -0700' -u Tue Apr 23 02:15:51 PM UTC 2024
Your patch: https://lore.kernel.org/[email protected]/
$ date -d 'Tue, 23 Apr 2024 23:42:58 +0300' -u Tue Apr 23 08:42:58 PM UTC 2024
Seems like this one beat yours by six hours?
Cheers,
Nathan
Quoted 25 lines · Nathan Chancellor
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Jason Gunthorpe
Quoted 10 lines · Konstantin Taranov
From: Konstantin Taranov <[email protected]>
Set ret to
-ENODEVwhennetdev_master_upper_dev_get_rcureturns NULL.Fixes 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")Signed-off-by Konstantin Taranov <[email protected]>--- drivers/infiniband/hw/mana/device.c | 1 + 1 file changed, 1 insertion(+)Quoted 3 lines
Quoted 1 line
Applied to for-next, thanks
So, what's wrong with my patch that had been sent _before_ this one?
Was it?
This patch:
$ date -d 'Tue, 23 Apr 2024 07:15:51 -0700' -u Tue Apr 23 02:15:51 PM UTC 2024
Quoted 6 lines
Your patch: https://lore.kernel.org/[email protected]/
$ date -d 'Tue, 23 Apr 2024 23:42:58 +0300' -u Tue Apr 23 08:42:58 PM UTC 2024Seems like this one beat yours by six hours?
Repeating myself from another thread:
"""
Oh, my... Sorry, I missed PM, it was mine sent after that one! I guess time for weekend.
"""
Sorry for the noise and have a nice weekend!
Signature · 2 lines
With Best Regards, Andy Shevchenko