Skip to contentSkip to conversation

netlink: specs: Add missing bridge linkinfo attrs

PATCH Applied Donald Hunter 4 participants 4 messages May 3, 2024 – May 7, 2024

Subsystems (3)
Networking Network drivers YAML netlink (YNL)
lore
Share & tools
lore

Donald Hunter

author maintainer
#0 lore raw

PATCH 1/1 netlink: specs: Add missing bridge linkinfo attrs

Attributes for FDB learned entries were added to the if_link netlink api for bridge linkinfo but are missing from the rt_link.yaml spec. Add the missing attributes to the spec.

Fixes ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
Signed-off-by Donald Hunter <[email protected]>
---
 Documentation/netlink/specs/rt_link.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/netlink/specs/rt_link.yaml +6 -0
index 8e4d19adee8c..4e702ac8bf66 100644
@@ -1144,6 +1144,12 @@ attribute-sets:
       -
         name: mcast-querier-state
         type: binary
+      -
+        name: fdb-n-learned
+        type: u32
+      -
+        name: fdb-max-learned
+        type: u32
   -
     name: linkinfo-brport-attrs
     name-prefix: ifla-brport-
Signature · 1 line
2.44.0
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Donald Hunter

Attributes for FDB learned entries were added to the if_link netlink api for bridge linkinfo but are missing from the rt_link.yaml spec. Add the missing attributes to the spec.

Fixes ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
Signed-off-by Donald Hunter <[email protected]>
---
 Documentation/netlink/specs/rt_link.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/netlink/specs/rt_link.yaml +0 -0
index 8e4d19adee8c..4e702ac8bf66 100644
@@ -1144,6 +1144,12 @@ attribute-sets:
       -
         name: mcast-querier-state

Documentation/netlink/specs/rt_link.yaml attribute-sets: · line 1155

Quoted 10 lines
Documentation/netlink/specs/rt_link.yaml +6 -0
         type: binary
+      -
+        name: fdb-n-learned
+        type: u32
+      -
+        name: fdb-max-learned
+        type: u32
   -
     name: linkinfo-brport-attrs
     name-prefix: ifla-brport-
Acked-by Nikolay Aleksandrov <[email protected]>
Reviewed-by on v1 1/1
#2 lore raw
In reply to Donald Hunter
Quoted 13 lines

-----Original Message-----
From: Donald Hunter <[email protected]>
Sent: Friday, May 3, 2024 9:43 AM
To: [email protected]; Jakub Kicinski <[email protected]>; David S. Miller <[email protected]>; Eric Dumazet <[email protected]>; Paolo Abeni <[email protected]>; Jiri Pirko <[email protected]>; Keller, Jacob E <[email protected]>; Johannes Nixdorf <[email protected]>; Ido Schimmel <[email protected]>; Nikolay Aleksandrov <[email protected]>
Cc: [email protected]; Donald Hunter <[email protected]>
Subject: [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs

Quoted 7 lines

Attributes for FDB learned entries were added to the if_link netlink api for bridge linkinfo but are missing from the rt_link.yaml spec. Add the missing attributes to the spec.

Fixes ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned

FDB entries")

Signed-off-by Donald Hunter <[email protected]>
Reviewed-by Jacob Keller <[email protected]>
Quoted 24 lines
---
 Documentation/netlink/specs/rt_link.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/netlink/specs/rt_link.yaml +6 -1
index 8e4d19adee8c..4e702ac8bf66 100644
@@ -1144,6 +1144,12 @@ attribute-sets:
       -
         name: mcast-querier-state
         type: binary
+      -
+        name: fdb-n-learned
+        type: u32
+      -
+        name: fdb-max-learned
+        type: u32
   -
     name: linkinfo-brport-attrs
     name-prefix: ifla-brport-
--

2.44.0

CI Applied
#3 lore raw
In reply to Donald Hunter
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Fri, 3 May 2024 17:43:04 +0100 you wrote:

Attributes for FDB learned entries were added to the if_link netlink api for bridge linkinfo but are missing from the rt_link.yaml spec. Add the missing attributes to the spec.

Fixes ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
Signed-off-by Donald Hunter <[email protected]>

[...]

Here is the summary with links:
- [net,v1] netlink: specs: Add missing bridge linkinfo attrs

    https://git.kernel.org/netdev/net/c/9adcac650618

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html