relayfs: remove comment on overwrite mode
PATCH 1/1 relayfs: remove comment on overwrite mode
Hi Andrew,
The overwrite arg has been removed from the relay_subbufs_consumed() (since it has been removed from relayfs altogether) so the comment preceding the function must go.
Thanks,
Hareesh
fs/relayfs/relay.c +0 -3
@@ -342,9 +342,6 @@* Adds to the channel buffer's consumed sub-buffer count. * subbufs_consumed should be the number of sub-buffers newly consumed, * not the total consumed. -* -* NOTE: kernel clients don't need to call this function if the channel -* mode is 'overwrite'. */ void relay_subbufs_consumed(struct rchan *chan, unsigned int cpu,
Quoted 5 lines · Hareesh Nagarajan
Hi Andrew,
The overwrite arg has been removed from the
relay_subbufs_consumed()(since it has been removed from relayfs altogether) so the comment preceding the function must go.
relayfs still supports overwrite mode, but it's now implemented differently (via the subbuf_start() callback instead of an overwrite arg), so this comment is still valid.
Tom
Quoted 17 lines
Thanks,
Hareesh
diff -ruNlinux-akpm/fs/relayfs/relay.clinux/fs/relayfs/relay.cfs/relayfs/relay.c +0
-3@@ -342,9 +342,6 @@* Adds to the channel buffer's consumed sub-buffer count. * subbufs_consumed should be the number of sub-buffers newly consumed, * not the total consumed. -* -* NOTE: kernel clients don't need to call this function if the channel -* mode is 'overwrite'. */ void relay_subbufs_consumed(struct rchan *chan, unsigned int cpu,