f2fs: zone: fix to don't trigger OPU on pinfile for direct IO
Chao Yu
maintainerPATCH v2 1/1 f2fs: zone: fix to don't trigger OPU on pinfile for direct IO
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>
Signed-off-by Chao Yu <[email protected]>
---
v2:
- fix to disallow OPU on pinfile no matter what device type f2fs uses.
fs/f2fs/data.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/f2fs/data.c +3 -2
@@ -1595,8 +1595,9 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) }/* use out-place-update for direct IO under LFS mode */ -if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { +if (map->m_may_create && (is_hole || + (flag ==F2FS_GET_BLOCK_DIO &&f2fs_lfs_mode (sbi) && + !f2fs_is_pinned_file (inode)))) {if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out;
Signature · 1 line
2.40.1
Quoted 28 lines · Chao Yu
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v2:
- fix to disallow OPU on pinfile no matter what device type f2fs uses.fs/f2fs/data.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)fs/f2fs/data.c +3
-3@@ -1595,8 +1595,9 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) }/* use out-place-update for direct IO under LFS mode */ -if (map->m_may_create && - (is_hole || (f2fs_lfs_mode (sbi) && flag ==F2FS_GET_BLOCK_DIO ))) { +if (map->m_may_create && (is_hole || + (flag ==F2FS_GET_BLOCK_DIO &&f2fs_lfs_mode (sbi) && + !f2fs_is_pinned_file (inode)))) {if (unlikely (f2fs_cp_error (sbi))) { err = -EIO ; goto sync_out; --
Quoted 2 lines
2.40.1
Reviewed-by Daeho Jeong <[email protected]>
Thanks,
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 9 lines · On Sun, 28 Apr 2024 09:12:36 +0800 you wrote:
Otherwise, it breaks pinfile's sematics.
Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v2:
- fix to disallow OPU on pinfile no matter what device type f2fs uses.fs/f2fs/data.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Here is the summary with links:
- [f2fs-dev,v2] f2fs: zone: fix to don't trigger OPU on pinfile for direct IO
https://git.kernel.org/jaegeuk/f2fs/c/48d180e2bf5a
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html