net: sched: sch_multiq: fix possible OOB write in multiq_tune()
Subsystems (3)
PATCH 1/1 net: sched: sch_multiq: fix possible OOB write in multiq_tune()
q->bands will be assigned to qopt->bands to execute subsequent code logic after kmalloc. So the old q->bands should not be used in kmalloc. Otherwise, an out-of-bounds write will occur.
--- net/sched/sch_multiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sched/sch_multiq.c +1 -1
@@ -185,7 +185,7 @@ static int multiq_tune(struct Qdisc *sch, struct nlattr *opt, qopt->bands =qdisc_dev (sch)->real_num_tx_queues; - removed =kmalloc (sizeof (*removed) * (q->max_bands - q->bands), + removed =kmalloc (sizeof (*removed) * (q->max_bands - qopt->bands),GFP_KERNEL );if (!removed)return -ENOMEM ;
Signature · 1 line
2.34.1
Quoted 6 lines · Hangyu Hua
q->bandswill be assigned toqopt->bandsto execute subsequent code logic after kmalloc. So the oldq->bandsshould not be used in kmalloc. Otherwise, an out-of-bounds write will occur.Fixes c2999f7fb05b ("net: sched: multiq: don't call qdisc_put() while holding tree lock")Signed-off-by Hangyu Hua <[email protected]>
Looks good to me.
Thanks.
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Mon, 3 Jun 2024 15:13:03 +0800 you wrote:
q->bandswill be assigned toqopt->bandsto execute subsequent code logic after kmalloc. So the oldq->bandsshould not be used in kmalloc. Otherwise, an out-of-bounds write will occur.Fixes c2999f7fb05b ("net: sched: multiq: don't call qdisc_put() while holding tree lock")Signed-off-by Hangyu Hua <[email protected]>[...]
Here is the summary with links:
- net: sched: sch_multiq: fix possible OOB write in multiq_tune()
https://git.kernel.org/netdev/net/c/affc18fdc694
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html