Skip to contentSkip to conversation

platform/chrome: cros_ec_debugfs: fix wrong EC message version

PATCH Applied Tzung-Bi Shih 3 participants 4 messages Jun 11, 2024 – Jun 12, 2024

Subsystems (3)
lore
Share & tools
lore

Tzung-Bi Shih

author maintainer
#0 lore raw

PATCH 1/1 platform/chrome: cros_ec_debugfs: fix wrong EC message version

ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it wrongly uses message version 0.

Fix it.

Fixes e86264595225 ("mfd: cros_ec: add debugfs, console log file")
---
 drivers/platform/chrome/cros_ec_debugfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/chrome/cros_ec_debugfs.c +1 -0
index f0e9efb543df..4525ad1b59f4 100644
@@ -334,6 +334,7 @@ static int ec_read_version_supported(struct cros_ec_dev *ec)
 	if (!msg)
 		return 0;
 
+	msg->version = 1;
 	msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
 	msg->outsize = sizeof(*params);
 	msg->insize = sizeof(*response);
Signature · 1 line
2.45.2.505.gda0bf45e8d-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Tzung-Bi Shih

ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it wrongly uses message version 0.

Fix it.

Fixes e86264595225 ("mfd: cros_ec: add debugfs, console log file")
Quoted 19 lines
---
 drivers/platform/chrome/cros_ec_debugfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/chrome/cros_ec_debugfs.c +1 -1
index f0e9efb543df..4525ad1b59f4 100644
@@ -334,6 +334,7 @@ static int ec_read_version_supported(struct cros_ec_dev *ec)
        if (!msg)
                return 0;
 
+       msg->version = 1;
        msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
        msg->outsize = sizeof(*params);
        msg->insize = sizeof(*response);
--

2.45.2.505.gda0bf45e8d-goog

#2 lore raw
In reply to Tzung-Bi Shih
This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Quoted 10 lines · On Tue, 11 Jun 2024 11:31:10 +0000 you wrote:

ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it wrongly uses message version 0.

Fix it.

Fixes e86264595225 ("mfd: cros_ec: add debugfs, console log file")

[...]

Here is the summary with links:
- platform/chrome: cros_ec_debugfs: fix wrong EC message version

    https://git.kernel.org/chrome-platform/c/c2a28647bbb4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#3 lore raw
In reply to Tzung-Bi Shih
This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Quoted 10 lines · On Tue, 11 Jun 2024 11:31:10 +0000 you wrote:

ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it wrongly uses message version 0.

Fix it.

Fixes e86264595225 ("mfd: cros_ec: add debugfs, console log file")

[...]

Here is the summary with links:
- platform/chrome: cros_ec_debugfs: fix wrong EC message version

    https://git.kernel.org/chrome-platform/c/c2a28647bbb4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html