net: mana: Use mana_cleanup_port_context() for rxq cleanup
PATCH 1/1 net: mana: Use mana_cleanup_port_context() for rxq cleanup
To cleanup rxqs in port context structures, instead of duplicating the code, use existing function mana_cleanup_port_context() which does the exact cleanup that's needed.
--- drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ethernet/microsoft/mana/mana_en.c +2 -4
@@ -2529,8 +2529,7 @@ static int mana_init_port(struct net_device *ndev)return 0 ; reset_apc: -kfree (apc->rxqs); - apc->rxqs =NULL ; +mana_cleanup_port_context (apc);return err; }
@@ -2787,8 +2786,7 @@ static int mana_probe_port(struct mana_context *ac, int port_idx, free_indir:mana_cleanup_indir_table (apc); reset_apc: -kfree (apc->rxqs); - apc->rxqs =NULL ; +mana_cleanup_port_context (apc); free_net: *ndev_storage =NULL ;netdev_err (ndev,"Failed to probe vPort %d: %d\n" , port_idx, err);
Signature · 1 line
2.34.1
Quoted 6 lines · Shradha Gupta
To cleanup rxqs in port context structures, instead of duplicating the code, use existing function
mana_cleanup_port_context()which does the exact cleanup that's needed.Signed-off-by Shradha Gupta <[email protected]>
Thanks for following-up with this clean-up, much appreciated.
Quoted 6 lines · Shradha Gupta
To cleanup rxqs in port context structures, instead of duplicating the code, use existing function
mana_cleanup_port_context()which does the exact cleanup that's needed.Signed-off-by Shradha Gupta <[email protected]>
Quoted 24 lines · Shradha Gupta
To cleanup rxqs in port context structures, instead of duplicating the code, use existing function
mana_cleanup_port_context()which does the exact cleanup that's needed.Signed-off-by Shradha Gupta <[email protected]>--- drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/net/ethernet/microsoft/mana/mana_en.c +1
-2@@ -2529,8 +2529,7 @@ static int mana_init_port(struct net_device *ndev)return 0 ; reset_apc: -kfree (apc->rxqs); - apc->rxqs =NULL ; +mana_cleanup_port_context (apc);return err; }
drivers/net/ethernet/microsoft/mana/mana_en.c static int mana_probe_port(struct mana_context *ac, int port_idx, · line 2792
Quoted 9 lines
drivers/net/ethernet/microsoft/mana/mana_en.c +1
-2@@ -2787,8 +2786,7 @@ static int mana_probe_port(struct mana_context *ac, int port_idx, free_indir:mana_cleanup_indir_table (apc); reset_apc: -kfree (apc->rxqs); - apc->rxqs =NULL ; +mana_cleanup_port_context (apc); free_net: *ndev_storage =NULL ;netdev_err (ndev,"Failed to probe vPort %d: %d\n" , port_idx, err);
Thanks!
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 14 Jun 2024 00:19:08 -0700 you wrote:
To cleanup rxqs in port context structures, instead of duplicating the code, use existing function
mana_cleanup_port_context()which does the exact cleanup that's needed.Signed-off-by Shradha Gupta <[email protected]>--- drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next] net: mana: Use mana_cleanup_port_context() for rxq cleanup
https://git.kernel.org/netdev/net-next/c/e275e19c918b
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html