fou: remove warn in gue_gro_receive on unsupported protocol
Subsystems (2)
PATCH 1/1 fou: remove warn in gue_gro_receive on unsupported protocol
From: Willem de Bruijn <[email protected]>
Drop the WARN_ON_ONCE inn gue_gro_receive if the encapsulated type is not known or does not have a GRO handler.
Such a packet is easily constructed. Syzbot generates them and sets off this warning.
Remove the warning as it is expected and not actionable.
The warning was previously reduced from WARN_ON to WARN_ON_ONCE in commit 270136613bf7 ("fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks").
--- net/ipv4/fou_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/fou_core.c +1 -1
@@ -433,7 +433,7 @@ static struct sk_buff *gue_gro_receive(struct sock *sk, offloads =NAPI_GRO_CB (skb)->is_ipv6 ? inet6_offloads : inet_offloads; ops =rcu_dereference (offloads[proto]); -if (WARN_ON_ONCE (!ops || !ops->callbacks.gro_receive)) +if (!ops || !ops->callbacks.gro_receive) goto out; pp =call_gro_receive (ops->callbacks.gro_receive, head, skb);
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
Quoted 9 lines · Willem de Bruijn
From: Willem de Bruijn <[email protected]>
Drop the
WARN_ON_ONCEinngue_gro_receiveif the encapsulated type is not known or does not have a GRO handler.Such a packet is easily constructed. Syzbot generates them and sets off this warning.
Quoted 7 lines
Remove the warning as it is expected and not actionable.
The warning was previously reduced from
WARN_ONtoWARN_ON_ONCEin commit270136613bf7("fou: DoWARN_ON_ONCEingue_gro_receivefor bad proto callbacks").Signed-off-by Willem de Bruijn <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Fri, 14 Jun 2024 08:25:18 -0400 you wrote:
From: Willem de Bruijn <[email protected]>
Drop the
WARN_ON_ONCEinngue_gro_receiveif the encapsulated type is not known or does not have a GRO handler.Such a packet is easily constructed. Syzbot generates them and sets off this warning.
[...]
Here is the summary with links:
- [net-next] fou: remove warn in gue_gro_receive on unsupported protocol
https://git.kernel.org/netdev/net-next/c/dd89a81d850f
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html