Skip to contentSkip to conversation

net: pse-pd: Kconfig: Fix missing firmware loader config select

PATCH Applied Kory Maincent 3 participants 3 messages Jun 20, 2024 – Jun 21, 2024

Subsystems (3)
lore
Share & tools
lore

Kory Maincent

author maintainer
#0 lore raw

PATCH 1/1 net: pse-pd: Kconfig: Fix missing firmware loader config select

Selecting FW_UPLOAD is not sufficient as it allows the firmware loader API to be built as a module alongside the pd692x0 driver built as builtin. Add select FW_LOADER to fix this issue.

Fixes 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver")
---
 drivers/net/pse-pd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/pse-pd/Kconfig +1 -0
index 577ea904b3d9..7fab916a7f46 100644
@@ -23,6 +23,7 @@ config PSE_REGULATOR
 config PSE_PD692X0
 	tristate "PD692X0 PSE controller"
 	depends on I2C
+	select FW_LOADER
 	select FW_UPLOAD
 	help
 	  This module provides support for PD692x0 regulator based Ethernet
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Kory Maincent

Selecting FW_UPLOAD is not sufficient as it allows the firmware loader API to be built as a module alongside the pd692x0 driver built as builtin. Add select FW_LOADER to fix this issue.

Fixes 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver")

Andrew

#2 lore raw
In reply to Kory Maincent
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 10 lines · On Thu, 20 Jun 2024 11:57:50 +0200 you wrote:

Selecting FW_UPLOAD is not sufficient as it allows the firmware loader API to be built as a module alongside the pd692x0 driver built as builtin. Add select FW_LOADER to fix this issue.

Fixes 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver")

[...]

Here is the summary with links:
- [net] net: pse-pd: Kconfig: Fix missing firmware loader config select

    https://git.kernel.org/netdev/net/c/7eadf50095bc

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html