Skip to contentSkip to conversation

bpf: add security_file_post_open() LSM hook to sleepable_lsm_hooks

PATCH Applied Matt Bobrowski 4 participants 4 messages Jun 18, 2024 – Jun 21, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf: add security_file_post_open() LSM hook to sleepable_lsm_hooks

The new generic LSM hook security_file_post_open() was recently added to the LSM framework in commit 8f46ff5767b0b ("security: Introduce file_post_open hook"). Let's proactively add this generic LSM hook to the sleepable_lsm_hooks BTF ID set, because I can't see there being any strong reasons not to, and it's only a matter of time before someone else comes around and asks for it to be there.

security_file_post_open() is inherently sleepable as it's purposely situated in the kernel that allows LSMs to directly read out the contents of the backing file if need be. Additionally, it's called directly after securuty_file_open(), and that LSM hook in itself already exists in the sleepable_lsm_hooks BTF ID set.

---
 kernel/bpf/bpf_lsm.c | 1 +
 1 file changed, 1 insertion(+)
kernel/bpf/bpf_lsm.c +1 -0
index 68240c3c6e7d..08a338e1f231 100644
@@ -280,6 +280,7 @@ BTF_ID(func, bpf_lsm_cred_prepare)
 BTF_ID(func, bpf_lsm_file_ioctl)
 BTF_ID(func, bpf_lsm_file_lock)
 BTF_ID(func, bpf_lsm_file_open)
+BTF_ID(func, bpf_lsm_file_post_open)
 BTF_ID(func, bpf_lsm_file_receive)
 
 BTF_ID(func, bpf_lsm_inode_create)
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
maintainer
#1 lore raw
Quoted 8 lines · Matt Bobrowski

The new generic LSM hook security_file_post_open() was recently added to the LSM framework in commit 8f46ff5767b0b ("security: Introduce file_post_open hook"). Let's proactively add this generic LSM hook to the sleepable_lsm_hooks BTF ID set, because I can't see there being any strong reasons not to, and it's only a matter of time before someone else comes around and asks for it to be there.

Quoted 4 lines

security_file_post_open() is inherently sleepable as it's purposely situated in the kernel that allows LSMs to directly read out the contents of the backing file if need be. Additionally, it's called directly after securuty_file_open(), and that LSM hook in itself

*cough*

"security_file_open()"

*cough*

Quoted 6 lines

already exists in the sleepable_lsm_hooks BTF ID set.

---
 kernel/bpf/bpf_lsm.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
paul-moore.com
maintainer
#2 lore raw
Quoted 9 lines · Paul Moore
Quoted 8 lines · Matt Bobrowski

The new generic LSM hook security_file_post_open() was recently added to the LSM framework in commit 8f46ff5767b0b ("security: Introduce file_post_open hook"). Let's proactively add this generic LSM hook to the sleepable_lsm_hooks BTF ID set, because I can't see there being any strong reasons not to, and it's only a matter of time before someone else comes around and asks for it to be there.

Quoted 8 lines
Quoted 4 lines

security_file_post_open() is inherently sleepable as it's purposely situated in the kernel that allows LSMs to directly read out the contents of the backing file if need be. Additionally, it's called directly after securuty_file_open(), and that LSM hook in itself

*cough*

"security_file_open()"

Fixed up while applying, thanks!

#3 lore raw
In reply to Matt Bobrowski
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Quoted 8 lines · On Tue, 18 Jun 2024 19:29:22 +0000 you wrote:

The new generic LSM hook security_file_post_open() was recently added to the LSM framework in commit 8f46ff5767b0b ("security: Introduce file_post_open hook"). Let's proactively add this generic LSM hook to the sleepable_lsm_hooks BTF ID set, because I can't see there being any strong reasons not to, and it's only a matter of time before someone else comes around and asks for it to be there.

[...]

Here is the summary with links:
- bpf: add security_file_post_open() LSM hook to sleepable_lsm_hooks

    https://git.kernel.org/bpf/bpf-next/c/6ddf3a9abd9f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html