Skip to contentSkip to conversation

selftests/bpf: test struct_ops bpf map auto-attach

PATCH Applied Mykyta Yatsenko [email protected] 2 participants 2 messages Jun 21, 2024

Subsystems (3)
lore
Share & tools
lore

Mykyta Yatsenko [email protected]

author
#0 lore raw

PATCH 1/1 selftests/bpf: test struct_ops bpf map auto-attach

From: Mykyta Yatsenko <[email protected]>

Adding selftest to verify that struct_ops maps are auto attached by bpf skeleton's *__attach function.

---
 .../selftests/bpf/prog_tests/bpf_tcp_ca.c     | 35 +++++++++++++++++++
 1 file changed, 35 insertions(+)
tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c +35 -0
index 164f237b24dd..bceff5900016 100644
@@ -185,6 +185,39 @@ static void test_dctcp(void)
 		close(fd);
 }
 
+static void test_dctcp_autoattach_map(void)
+{
+	struct cb_opts cb_opts = {
+		.cc = "bpf_dctcp",
+	};
+	struct network_helper_opts opts = {
+		.post_socket_cb	= cc_cb,
+		.cb_opts	= &cb_opts,
+	};
+	struct bpf_dctcp *dctcp_skel;
+	struct bpf_link *link;
+
+	dctcp_skel = bpf_dctcp__open_and_load();
+	if (!ASSERT_OK_PTR(dctcp_skel, "bpf_dctcp__open_and_load"))
+		return;
+
+	bpf_map__set_autoattach(dctcp_skel->maps.dctcp, true);
+	bpf_map__set_autoattach(dctcp_skel->maps.dctcp_nouse, false);
+
+	if (!ASSERT_OK(bpf_dctcp__attach(dctcp_skel), "bpf_dctcp__attach"))
+		goto destroy;
+
+	/* struct_ops is auto-attached  */
+	link = dctcp_skel->links.dctcp;
+	if (!ASSERT_OK_PTR(link, "link"))
+		goto destroy;
+
+	do_test(&opts);
+
+destroy:
+	bpf_dctcp__destroy(dctcp_skel);
+}
+
 static char *err_str;
 static bool found;
 
@@ -598,4 +631,6 @@ void test_bpf_tcp_ca(void)
 		test_tcp_ca_kfunc();
 	if (test__start_subtest("cc_cubic"))
 		test_cc_cubic();
+	if (test__start_subtest("dctcp_autoattach_map"))
+		test_dctcp_autoattach_map();
 }
Signature · 1 line
2.45.0
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 8 lines · On Fri, 21 Jun 2024 19:03:24 +0100 you wrote:

From: Mykyta Yatsenko <[email protected]>

Adding selftest to verify that struct_ops maps are auto attached by bpf skeleton's *__attach function.

[...]

Here is the summary with links:
- [bpf-next] selftests/bpf: test struct_ops bpf map auto-attach

    https://git.kernel.org/bpf/bpf-next/c/cd387ce54834

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html