Skip to contentSkip to conversation

docs/about/removed-features: Move the -soundhw into the right section

PATCH Applied Thomas Huth 4 participants 4 messages Aug 2, 2022 – Aug 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs/about/removed-features: Move the -soundhw into the right section

The note about the removal of '-soundhw' has been accidentally added to the section of removed "linux-user mode CPUs" ... it should reside in the section about removed "System emulator command line arguments" instead.

Fixes 039a68373c ("introduce -audio as a replacement for -soundhw")
---
 docs/about/removed-features.rst | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
docs/about/removed-features.rst +7 -7
index c7b9dadd5d..925e22016f 100644
@@ -396,6 +396,13 @@ Use ``-display sdl`` instead.
 
 Use ``-display curses`` instead.
 
+Creating sound card devices using ``-soundhw`` (removed in 7.1)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Sound card devices should be created using ``-device`` or ``-audio``.
+The exception is ``pcspk`` which can be activated using ``-machine
+pcspk-audiodev=<name>``.
+
 
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
@@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite broken. For that
 reason the maintainers strongly suspected no one actually used it.
 
 
-Creating sound card devices using ``-soundhw`` (removed in 7.1)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-Sound card devices should be created using ``-device`` or ``-audio``.
-The exception is ``pcspk`` which can be activated using ``-machine
-pcspk-audiodev=<name>``.
-
 TCG introspection features
 --------------------------
 
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Thomas Huth

The note about the removal of '-soundhw' has been accidentally added to the section of removed "linux-user mode CPUs" ... it should reside in the section about removed "System emulator command line arguments" instead.

Fixes 039a68373c ("introduce -audio as a replacement for -soundhw")
---
 docs/about/removed-features.rst | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 8 lines · On Dienstag, 2. August 2022 09:56:11 CEST Thomas Huth wrote:

The note about the removal of '-soundhw' has been accidentally added to the section of removed "linux-user mode CPUs" ... it should reside in the section about removed "System emulator command line arguments" instead.

Fixes 039a68373c ("introduce -audio as a replacement for -soundhw")

---

That can easily happen unfortunately, as the hierarchy syntax here, like in MAINTAINERS BTW, is not exactly perfect for the human eye.

Quoted 35 lines
 docs/about/removed-features.rst | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
(quoted diff) +0 -0

b/docs/about/removed-features.rst index c7b9dadd5d..925e22016f 100644

docs/about/removed-features.rst +7 -0
@@ -396,6 +396,13 @@ Use ``-display sdl`` instead.
 
 Use ``-display curses`` instead.
 
+Creating sound card devices using ``-soundhw`` (removed in 7.1)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Sound card devices should be created using ``-device`` or ``-audio``.
+The exception is ``pcspk`` which can be activated using ``-machine
+pcspk-audiodev=<name>``.
+
 
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
@@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite

broken. For that reason the maintainers strongly suspected no one actually used it.

docs/about/removed-features.rst +0 -7
-Creating sound card devices using ``-soundhw`` (removed in 7.1)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-Sound card devices should be created using ``-device`` or ``-audio``.
-The exception is ``pcspk`` which can be activated using ``-machine
-pcspk-audiodev=<name>``.
-
 TCG introspection features
 --------------------------
#3 lore raw
In reply to Thomas Huth

Le 02/08/2022 à 09:56, Thomas Huth a écrit :

Quoted 33 lines

The note about the removal of '-soundhw' has been accidentally added to the section of removed "linux-user mode CPUs" ... it should reside in the section about removed "System emulator command line arguments" instead.

Fixes 039a68373c ("introduce -audio as a replacement for -soundhw")
---
  docs/about/removed-features.rst | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
docs/about/removed-features.rst +7 -0
index c7b9dadd5d..925e22016f 100644
@@ -396,6 +396,13 @@ Use ``-display sdl`` instead.
 
  Use ``-display curses`` instead.
 
+Creating sound card devices using ``-soundhw`` (removed in 7.1)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Sound card devices should be created using ``-device`` or ``-audio``.
+The exception is ``pcspk`` which can be activated using ``-machine
+pcspk-audiodev=<name>``.
+
 
  QEMU Machine Protocol (QMP) commands
  ------------------------------------
@@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite broken. For that
  reason the maintainers strongly suspected no one actually used it.
 
 

docs/about/removed-features.rst tripped up the CI testing and was suspected to be quite broken. For that · line 693

Quoted 10 lines
docs/about/removed-features.rst +0 -7
-Creating sound card devices using ``-soundhw`` (removed in 7.1)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-Sound card devices should be created using ``-device`` or ``-audio``.
-The exception is ``pcspk`` which can be activated using ``-machine
-pcspk-audiodev=<name>``.
-
  TCG introspection features
  --------------------------
 

Applied to my trivial-patches branch.

Thanks,
Laurent