Skip to contentSkip to conversation

policy: Fix AutoEnable default when main.conf doesn't exist

PATCH Applied Arnav Singh 3 participants 3 messages Jun 29, 2024 – Jul 1, 2024 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 policy: Fix AutoEnable default when main.conf doesn't exist

180cf09933b2d8eb03972c8638063429fe5fece5 changed the default to true if the config file did not set it, but it still remained false if the config file did not exist at all. This change fixes that.

---
 plugins/policy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
plugins/policy.c +3 -1
index 0bbdbfc88..9a449da61 100644
@@ -74,6 +74,7 @@ static GSList *reconnects = NULL;
 static unsigned int service_id = 0;
 static GSList *devices = NULL;
 
+static const bool default_auto_enable = true;
 static bool auto_enable = false;
 
 struct policy_data {
@@ -858,6 +859,7 @@ static int policy_init(void)
 						sizeof(*reconnect_intervals);
 		reconnect_intervals = util_memdup(default_intervals,
 						sizeof(default_intervals));
+		auto_enable = default_auto_enable;
 		goto done;
 	}
 
@@ -895,7 +897,7 @@ static int policy_init(void)
 								&gerr);
 	if (gerr) {
 		g_clear_error(&gerr);
-		auto_enable = true;
+		auto_enable = default_auto_enable;
 	}
 
 	resume_delay = g_key_file_get_integer(
Signature · 1 line
2.45.2
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866862

---Test result---

Test Summary:

CheckPatch                    PASS      0.46 seconds
GitLint                       PASS      0.69 seconds
BuildEll                      PASS      25.27 seconds
BluezMake                     PASS      1642.43 seconds
MakeCheck                     PASS      13.64 seconds
MakeDistcheck                 PASS      192.64 seconds
CheckValgrind                 PASS      251.68 seconds
CheckSmatch                   PASS      354.58 seconds
bluezmakeextell               PASS      119.82 seconds
IncrementalBuild              PASS      1548.90 seconds
ScanBuild                     PASS      994.67 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Arnav Singh
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Sat, 29 Jun 2024 13:16:32 -0700 you wrote:

180cf09933b2d8eb03972c8638063429fe5fece5 changed the default to true if the config file did not set it, but it still remained false if the config file did not exist at all. This change fixes that.

---
 plugins/policy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ] policy: Fix AutoEnable default when main.conf doesn't exist

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f40e88d0bd5

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html