Skip to contentSkip to conversation

dt-bindings: pinctrl: pinctrl-single: Fix pinctrl-single,gpio-range description

PATCH In review Nishanth Menon 3 participants 3 messages Jun 27, 2024 – Jul 3, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: pinctrl: pinctrl-single: Fix pinctrl-single,gpio-range description

The binding is supposed to describe the properties of each element of the pinctrl-single,gpio-range array entry, however when we use "- items:" instead of "items:", it explicitly describes that there is just a single entry in the array.

The pinctrl-single,gpio-range property should describe more than one entry in the array. Fix the typo and adjust the alignment of the description of the entries appropriately.

Fixes 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")

---
Symptom:
pinctrl-single,gpio-range = <&range 0 21 7>; generates no warning
However,
pinctrl-single,gpio-range = <&range 0 21 7>, <&range 32 2 7>; generates "is too long" warning.

This is just an attempt to fix the binding that is existing.

V1: https://lore.kernel.org/all/[email protected]/

Patch is based on next-20240626

 .../devicetree/bindings/pinctrl/pinctrl-single.yaml    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml +5 -5
index c11495524dd2..4e7fd00d602a 100644
@@ -75,11 +75,11 @@ properties:
     description: Optional list of pin base, nr pins & gpio function
     $ref: /schemas/types.yaml#/definitions/phandle-array
     items:
-      - items:
-          - description: phandle of a gpio-range node
-          - description: pin base
-          - description: number of pins
-          - description: gpio function
+      items:
+        - description: phandle of a gpio-range node
+        - description: pin base
+        - description: number of pins
+        - description: gpio function
 
   '#gpio-range-cells':
     description: No longer needed, may exist in older files for gpio-ranges

base-commit: df9574a57d02b265322e77fb8628d4d33641dda9

Signature · 1 line
2.43.0
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 19 lines · Nishanth Menon

The binding is supposed to describe the properties of each element of the pinctrl-single,gpio-range array entry, however when we use "- items:" instead of "items:", it explicitly describes that there is just a single entry in the array.

The pinctrl-single,gpio-range property should describe more than one entry in the array. Fix the typo and adjust the alignment of the description of the entries appropriately.

Fixes 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")

---
Symptom:
pinctrl-single,gpio-range = <&range 0 21 7>; generates no warning
However,
pinctrl-single,gpio-range = <&range 0 21 7>, <&range 32 2 7>; generates "is too long" warning.

Quoted 9 lines

This is just an attempt to fix the binding that is existing.

V1: https://lore.kernel.org/all/[email protected]/

Patch is based on next-20240626

 .../devicetree/bindings/pinctrl/pinctrl-single.yaml    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
#2 lore raw
In reply to Nishanth Menon
Quoted 11 lines · Nishanth Menon

The binding is supposed to describe the properties of each element of the pinctrl-single,gpio-range array entry, however when we use "- items:" instead of "items:", it explicitly describes that there is just a single entry in the array.

The pinctrl-single,gpio-range property should describe more than one entry in the array. Fix the typo and adjust the alignment of the description of the entries appropriately.

Fixes 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")

Patch applied!

Yours,
Linus Walleij