Skip to contentSkip to conversation

block: fix get_max_segment_size() warning

PATCH Applied Chaitanya Kulkarni 4 participants 4 messages Jul 9, 2024 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: fix get_max_segment_size() warning

Correct the parameter name in the comment of get_max_segment_size() to fix following warning:-

block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size' block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size'

---
 block/blk-merge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-merge.c +1 -1
index 94502261e24a..668b784bc246 100644
@@ -210,7 +210,7 @@ static inline unsigned get_max_io_size(struct bio *bio,
  * get_max_segment_size() - maximum number of bytes to add as a single segment
  * @lim: Request queue limits.
  * @paddr: address of the range to add
- * @max_len: maximum length available to add at @paddr
+ * @len: maximum length available to add at @paddr
  *
  * Returns the maximum number of bytes of the range starting at @paddr that can
  * be added to a single segment.
Signature · 1 line
2.40.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Chaitanya Kulkarni

Correct the parameter name in the comment of get_max_segment_size() to fix following warning:-

block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size' block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size'

Signature · 2 lines
Damien Le Moal
Western Digital Research
maintainer Applied
#2 lore raw
In reply to Chaitanya Kulkarni
Quoted 8 lines · Chaitanya Kulkarni

Correct the parameter name in the comment of get_max_segment_size() to fix following warning:-

block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size' block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size'

[...]

Applied, thanks!

[1/1] block: fix get_max_segment_size() warning

      commit: 0ffc46eb1b6d0b9dd07e4f2b1019edd4fe678b9e

Best regards,

Signature · 1 line
Jens Axboe