Skip to contentSkip to conversation

selftests: forwarding: Make vxlan-bridge-1d pass on debug kernels

PATCH Applied Ido Schimmel 3 participants 3 messages Jul 7, 2024 – Jul 9, 2024

Subsystems (4)
lore
Share & tools
lore

Ido Schimmel

author maintainer
#0 lore raw

PATCH 1/1 selftests: forwarding: Make vxlan-bridge-1d pass on debug kernels

The ageing time used by the test is too short for debug kernels and results in entries being aged out prematurely [1].

Fix by increasing the ageing time.

The same change was done for the VLAN-aware version of the test in commit dfbab74044be ("selftests: forwarding: Make vxlan-bridge-1q pass on debug kernels").

[1]

 # ./vxlan_bridge_1d.sh
 [...]
 # TEST: VXLAN: flood before learning                                  [ OK ]
 # TEST: VXLAN: show learned FDB entry                                 [ OK ]
 # TEST: VXLAN: learned FDB entry                                      [FAIL]
 # veth3: Expected to capture 0 packets, got 4.
 # RTNETLINK answers: No such file or directory
 # TEST: VXLAN: deletion of learned FDB entry                          [ OK ]
 # TEST: VXLAN: Ageing of learned FDB entry                            [FAIL]
 # veth3: Expected to capture 0 packets, got 2.
 [...]
---
 tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh +4 -4
index 6f0a2e452ba1..3f9d50f1ef9e 100755
@@ -680,9 +680,9 @@ test_learning()
 	local mac=de:ad:be:ef:13:37
 	local dst=192.0.2.100
 
-	# Enable learning on the VxLAN device and set ageing time to 10 seconds
-	ip link set dev br1 type bridge ageing_time 1000
-	ip link set dev vx1 type vxlan ageing 10
+	# Enable learning on the VxLAN device and set ageing time to 30 seconds
+	ip link set dev br1 type bridge ageing_time 3000
+	ip link set dev vx1 type vxlan ageing 30
 	ip link set dev vx1 type vxlan learning
 	reapply_config
 
@@ -740,7 +740,7 @@ test_learning()
 
 	vxlan_flood_test $mac $dst 0 10 0
 
-	sleep 20
+	sleep 60
 
 	bridge fdb show brport vx1 | grep $mac | grep -q self
 	check_fail $?
Signature · 1 line
2.45.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 22 lines · Ido Schimmel

The ageing time used by the test is too short for debug kernels and results in entries being aged out prematurely [1].

Fix by increasing the ageing time.

The same change was done for the VLAN-aware version of the test in commit dfbab74044be ("selftests: forwarding: Make vxlan-bridge-1q pass on debug kernels").

[1]

 # ./vxlan_bridge_1d.sh
 [...]
 # TEST: VXLAN: flood before learning                                  [ OK ]
 # TEST: VXLAN: show learned FDB entry                                 [ OK ]
 # TEST: VXLAN: learned FDB entry                                      [FAIL]
 # veth3: Expected to capture 0 packets, got 4.
 # RTNETLINK answers: No such file or directory
 # TEST: VXLAN: deletion of learned FDB entry                          [ OK ]
 # TEST: VXLAN: Ageing of learned FDB entry                            [FAIL]
 # veth3: Expected to capture 0 packets, got 2.
 [...]
Quoted 2 lines
#2 lore raw
In reply to Ido Schimmel
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Sun, 7 Jul 2024 12:54:58 +0300 you wrote:

The ageing time used by the test is too short for debug kernels and results in entries being aged out prematurely [1].

Fix by increasing the ageing time.

The same change was done for the VLAN-aware version of the test in commit dfbab74044be ("selftests: forwarding: Make vxlan-bridge-1q pass on debug kernels").

[...]

Here is the summary with links:
- [net-next] selftests: forwarding: Make vxlan-bridge-1d pass on debug kernels

    https://git.kernel.org/netdev/net-next/c/3699e57aae88

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html