Skip to contentSkip to conversation

dt-bindings: net: realtek,rtl82xx: Document RTL8211F LED support

PATCH Applied Marek Vasut 3 participants 3 messages Jul 8, 2024 – Jul 11, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: net: realtek,rtl82xx: Document RTL8211F LED support

The RTL8211F PHY does support LED configuration, document support for LEDs in the binding document.

---
Cc: "David S. Miller" <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Florian Fainelli <[email protected]>
Cc: Heiner Kallweit <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
V2: Invert the conditional

---
 .../bindings/net/realtek,rtl82xx.yaml           | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml +14 -3
index 18ee72f5c74a8..d248a08a2136b 100644
@@ -14,9 +14,6 @@ maintainers:
 description:
   Bindings for Realtek RTL82xx PHYs
 
-allOf:
-  - $ref: ethernet-phy.yaml#
-
 properties:
   compatible:
     enum:
@@ -41,6 +38,8 @@ properties:
       - ethernet-phy-id001c.cad0
       - ethernet-phy-id001c.cb00
 
+  leds: true
+
   realtek,clkout-disable:
     type: boolean
     description:
@@ -54,6 +53,18 @@ properties:
 
 unevaluatedProperties: false
 
+allOf:
+  - $ref: ethernet-phy.yaml#
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              const: ethernet-phy-id001c.c916
+    then:
+      properties:
+        leds: false
+
 examples:
   - |
     mdio {
Signature · 1 line
2.43.0
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 19 lines · Marek Vasut

The RTL8211F PHY does support LED configuration, document support for LEDs in the binding document.

---
Cc: "David S. Miller" <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Florian Fainelli <[email protected]>
Cc: Heiner Kallweit <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
V2: Invert the conditional

Quoted 4 lines
---
 .../bindings/net/realtek,rtl82xx.yaml           | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
#2 lore raw
In reply to Marek Vasut
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 18 lines · On Mon, 8 Jul 2024 23:16:29 +0200 you wrote:

The RTL8211F PHY does support LED configuration, document support for LEDs in the binding document.

---
Cc: "David S. Miller" <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Florian Fainelli <[email protected]>
Cc: Heiner Kallweit <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]

Quoted 1 line

[...]

Here is the summary with links:
- [net-next,v2] dt-bindings: net: realtek,rtl82xx: Document RTL8211F LED support

    https://git.kernel.org/netdev/net-next/c/ab896aa62e30

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html