net: ethtool: Monotonically increase the message sequence number
Subsystems (3)
PATCH 1/1 net: ethtool: Monotonically increase the message sequence number
Currently, during the module firmware flashing process, unicast notifications are sent from the kernel using the same sequence number, making it impossible for user space to track missed notifications.
Monotonically increase the message sequence number, so the order of notifications could be tracked effectively.
--- net/ethtool/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ethtool/module.c +1 -1
@@ -488,7 +488,7 @@ ethnl_module_fw_flash_ntf(struct net_device *dev,if (!skb)return ; - hdr =ethnl_unicast_put (skb, ntf_params->portid, ntf_params->seq, + hdr =ethnl_unicast_put (skb, ntf_params->portid, ++ntf_params->seq,ETHTOOL_MSG_MODULE_FW_FLASH_NTF );if (!hdr) goto err_skb;
Signature · 1 line
2.45.0
Petr Machata
AppliedQuoted 9 lines · Danielle Ratson
Currently, during the module firmware flashing process, unicast notifications are sent from the kernel using the same sequence number, making it impossible for user space to track missed notifications.
Monotonically increase the message sequence number, so the order of notifications could be tracked effectively.
Signed-off-by Danielle Ratson <[email protected]>Reviewed-by Ido Schimmel <[email protected]>
Applied, thanks.
Quoted 6 lines · Petr Machata
Quoted 4 lines · Danielle Ratson
Currently, during the module firmware flashing process, unicast notifications are sent from the kernel using the same sequence number, making it impossible for user space to track missed notifications.
Quoted 7 lines
Quoted 5 lines
Monotonically increase the message sequence number, so the order of notifications could be tracked effectively.
Signed-off-by Danielle Ratson <[email protected]>Reviewed-by Ido Schimmel <[email protected]>Applied, thanks.
Oops, never mind, I was talking about our internal queue and the reply shouldn't have gone public.
Quoted 6 lines · On Thu, 11 Jul 2024 11:09:34 +0300 Danielle Ratson wrote:
Currently, during the module firmware flashing process, unicast notifications are sent from the kernel using the same sequence number, making it impossible for user space to track missed notifications.
Monotonically increase the message sequence number, so the order of notifications could be tracked effectively.
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 11 Jul 2024 11:09:34 +0300 you wrote:
Currently, during the module firmware flashing process, unicast notifications are sent from the kernel using the same sequence number, making it impossible for user space to track missed notifications.
Monotonically increase the message sequence number, so the order of notifications could be tracked effectively.
[...]
Here is the summary with links:
- [net-next] net: ethtool: Monotonically increase the message sequence number
https://git.kernel.org/netdev/net-next/c/275a63c9fe10
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html