net: ethernet: lantiq_etop: remove redundant device name setup
Subsystems (2)
PATCH v2 1/1 net: ethernet: lantiq_etop: remove redundant device name setup
The same name is set when allocating the netdevice structure in the alloc_etherdev_mq()->alloc_etherrdev_mqs() function. Therefore, there is no need to manually set it.
This fixes CheckPatch warnings:
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
strcpy(dev->name, "eth%d");
--- drivers/net/ethernet/lantiq_etop.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/lantiq_etop.c +0 -1
@@ -675,7 +675,6 @@ ltq_etop_probe(struct platform_device *pdev) err = -ENOMEM ; goto err_out; } -strcpy (dev->name,"eth%d" ); dev->netdev_ops = <q_eth_netdev_ops; dev->ethtool_ops = <q_etop_ethtool_ops; priv =netdev_priv (dev);
Signature · 1 line
2.39.2
Quoted 3 lines · Aleksander Jan Bajkowski
The same name is set when allocating the netdevice structure in the alloc_etherdev_mq()->alloc_etherrdev_mqs() function. Therefore, there is no need to manually set it.
If this one is not needed:
grep -r "eth%d" *3com/3c515.c: sprintf(dev->name, "eth%d", unit);8390/smc-ultra.c: sprintf(dev->name, "eth%d", unit);8390/wd.c: sprintf(dev->name, "eth%d", unit);8390/ne.c: sprintf(dev->name, "eth%d", unit);amd/lance.c: sprintf(dev->name, "eth%d", unit);atheros/atlx/atl2.c: strcpy(netdev->name, "eth%d"); /* ?? */cirrus/cs89x0.c: sprintf(dev->name, "eth%d", unit);dec/tulip/tulip_core.c: strcpy(dev->name, "eth%d"); /* un-hack */intel/ixgbe/ixgbe_main.c: strcpy(netdev->name, "eth%d");intel/ixgbevf/ixgbevf_main.c: strcpy(netdev->name, "eth%d");intel/e100.c: strcpy(netdev->name, "eth%d");intel/igbvf/netdev.c: strcpy(netdev->name, "eth%d");intel/e1000e/netdev.c: strscpy(netdev->name, "eth%d", sizeof(netdev->name));intel/igb/igb_main.c: strcpy(netdev->name, "eth%d");intel/igc/igc_main.c: strscpy(netdev->name, "eth%d", sizeof(netdev->name));intel/e1000/e1000_main.c: strcpy(netdev->name, "eth%d");lantiq_etop.c: strcpy(dev->name, "eth%d");micrel/ks8842.c: strcpy(netdev->name, "eth%d");smsc/smc9194.c: sprintf(dev->name, "eth%d", unit);
maybe you can remove all these as well?
Andrew
Jakub Kicinski
maintainerQuoted 1 line · On Sat, 13 Jul 2024 20:02:49 +0200 Andrew Lunn wrote:
maybe you can remove all these as well?
+1 seems like a good cleanup (after the merge window is over)
Quoted 27 lines · Andrew Lunn
Quoted 3 lines · Aleksander Jan Bajkowski
The same name is set when allocating the netdevice structure in the alloc_etherdev_mq()->alloc_etherrdev_mqs() function. Therefore, there is no need to manually set it.
If this one is not needed:
grep -r "eth%d" *
3com/3c515.c:sprintf(dev->name, "eth%d", unit);8390/smc-ultra.c:sprintf(dev->name, "eth%d", unit);8390/wd.c:sprintf(dev->name, "eth%d", unit);8390/ne.c:sprintf(dev->name, "eth%d", unit);amd/lance.c:sprintf(dev->name, "eth%d", unit);atheros/atlx/atl2.c:strcpy(netdev->name, "eth%d"); /* ?? */cirrus/cs89x0.c:sprintf(dev->name, "eth%d", unit);dec/tulip/tulip_core.c:strcpy(dev->name, "eth%d"); /* un-hack */intel/ixgbe/ixgbe_main.c:strcpy(netdev->name, "eth%d");intel/ixgbevf/ixgbevf_main.c:strcpy(netdev->name, "eth%d");intel/e100.c:strcpy(netdev->name, "eth%d");intel/igbvf/netdev.c:strcpy(netdev->name, "eth%d");intel/e1000e/netdev.c:strscpy(netdev->name, "eth%d", sizeof(netdev->name));intel/igb/igb_main.c:strcpy(netdev->name, "eth%d");intel/igc/igc_main.c:strscpy(netdev->name, "eth%d", sizeof(netdev->name));intel/e1000/e1000_main.c:strcpy(netdev->name, "eth%d");lantiq_etop.c:strcpy(dev->name, "eth%d");micrel/ks8842.c:strcpy(netdev->name, "eth%d");smsc/smc9194.c:sprintf(dev->name, "eth%d", unit);
Quoted 1 line
maybe you can remove all these as well?
Added to my todo list.
Quoted 1 line
Andrew
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Sat, 13 Jul 2024 19:09:20 +0200 you wrote:
The same name is set when allocating the netdevice structure in the alloc_etherdev_mq()->alloc_etherrdev_mqs() function. Therefore, there is no need to manually set it.
This fixes CheckPatch warnings:
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88strcpy(dev->name, "eth%d");[...]
Here is the summary with links:
- [net-next,v2] net: ethernet: lantiq_etop: remove redundant device name setup
https://git.kernel.org/netdev/net-next/c/9283477e2891
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html