Skip to contentSkip to conversation

btrfs: print warning message if bdev_file_open_by_path function fails during mount.

PATCH Superseded Li Zhang 2 participants 2 messages Jul 16, 2024 Btrfs file system

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Li Zhang

author
#0 lore raw

PATCH v2 1/1 btrfs: print warning message if bdev_file_open_by_path function fails during mount.

[ENHANCEMENT]
When mounting a btrfs filesystem, the filesystem opens the block device, and if this fails, there is no message about it. Print a message about it to help debugging.

[IMPLEMENTATION]
Print warning message if bdev_file_open_by_path fails.

[TEST]
I have a btrfs filesystem on three block devices, one of which is write-protected, so regular mounts fail, but there is no message in dmesg.

/dev/vdb normal
/dev/vdc write protected
/dev/vdd normal

Before patch:

$ sudo mount /dev/vdb /mnt/
mount: mount(2) failed: no such file or directory
$ sudo dmesg # Show only messages about missing block devices
....
[ 352.947196] BTRFS error (device vdb): devid 2 uuid 4ee2c625-a3b2-4fe0-b411-756b23e08533 missing
....

After patch:

$ sudo mount /dev/vdb /mnt/
mount: mount(2) failed: no such file or directory
$ sudo dmesg # Show bdev_file_open_by_path failed.
....
[ 352.944328] BTRFS error: faled to open device for path /dev/vdc with flags 0x3: -13
[ 352.947196] BTRFS error (device vdb): missing devid 2 uuid 4ee2c625-a3b2-4fe0-b411-756b23e08533
....

V1:
Use printk to print messages

V2:
Use btrfs_err to print messages and format output

---
 fs/btrfs/volumes.c | 1 +
 1 file changed, 1 insertion(+)
fs/btrfs/volumes.c +1 -0
index c39145e..179419f 100644
@@ -476,6 +476,7 @@ static noinline struct btrfs_fs_devices *find_fsid(
 
 	if (IS_ERR(*bdev_file)) {
 		ret = PTR_ERR(*bdev_file);
+		btrfs_err(NULL, "faled to open device for path %s with flags 0x%x: %d", device_path, flags, ret);
 		goto error;
 	}
 	bdev = file_bdev(*bdev_file);
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 8 lines · Li Zhang

[ENHANCEMENT]
When mounting a btrfs filesystem, the filesystem opens the block device, and if this fails, there is no message about it. Print a message about it to help debugging.

[IMPLEMENTATION]
Print warning message if bdev_file_open_by_path fails.

It's no longer a warning message (it's an error message now), plus this section/phrase is redundant - you have already said the same right above.

Quoted 18 lines

[TEST]
I have a btrfs filesystem on three block devices, one of which is write-protected, so regular mounts fail, but there is no message in dmesg.

/dev/vdb normal
/dev/vdc write protected
/dev/vdd normal

Before patch:

$ sudo mount /dev/vdb /mnt/
mount: mount(2) failed: no such file or directory
$ sudo dmesg # Show only messages about missing block devices
....
[ 352.947196] BTRFS error (device vdb): devid 2 uuid 4ee2c625-a3b2-4fe0-b411-756b23e08533 missing
....
Quoted 6 lines

After patch:

$ sudo mount /dev/vdb /mnt/
mount: mount(2) failed: no such file or directory
$ sudo dmesg # Show bdev_file_open_by_path failed.
....
[ 352.944328] BTRFS error: faled to open device for path /dev/vdc with flags 0x3: -13

typo: faled -> failed

Quoted 8 lines
[ 352.947196] BTRFS error (device vdb): missing devid 2 uuid 4ee2c625-a3b2-4fe0-b411-756b23e08533

....

V1:
Use printk to print messages

V2:
Use btrfs_err to print messages and format output

Details about what changed between patch versions goes under the line "---" below, so that it doesn't show up in the commit message after it gets committed.

Quoted 3 lines

---

Here.

fs/btrfs/volumes.c static noinline struct btrfs_fs_devices *find_fsid( · line 479

Quoted 12 lines
 fs/btrfs/volumes.c | 1 +
 1 file changed, 1 insertion(+)
fs/btrfs/volumes.c +1 -0
index c39145e..179419f 100644
@@ -476,6 +476,7 @@ static noinline struct btrfs_fs_devices *find_fsid(
 
        if (IS_ERR(*bdev_file)) {
                ret = PTR_ERR(*bdev_file);
+               btrfs_err(NULL, "faled to open device for path %s with flags 0x%x: %d", device_path, flags, ret);

typo: faled -> failed

Thanks.

Quoted 7 lines
fs/btrfs/volumes.c +0 -1
                goto error;
        }
        bdev = file_bdev(*bdev_file);
--

1.8.3.1