Skip to contentSkip to conversation

Allow SysRq emergency sync to thaw frozen filesystems

PATCH Superseded Eric Sandeen 10 participants 28 messages Jan 15, 2009 – Feb 16, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Allow SysRq emergency sync to thaw frozen filesystems

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

This doesn't have to piggyback on the existing emergency sync sysrq, but it seems like a reasonable, simple addition to me.

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

Thanks,
-Eric

---

drivers/char/sysrq.c +1 -0
Index: linux-2.6/drivers/char/sysrq.c
===================================================================
@@ -151,6 +151,7 @@ static struct sysrq_key_op sysrq_reboot_
 
 static void sysrq_handle_sync(int key, struct tty_struct *tty)
 {
+	emergency_thaw();
 	emergency_sync();
 }
 static struct sysrq_key_op sysrq_sync_op = {
fs/buffer.c +23 -0
Index: linux-2.6/fs/buffer.c
===================================================================
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
+
+/**
+ * emergency_thaw -- force thaw every filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq
+ */
+void emergency_thaw(void)
+{
+	pdflush_operation(do_thaw, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock
include/linux/buffer_head.h +1 -0
Index: linux-2.6/include/linux/buffer_head.h
===================================================================
@@ -171,6 +171,7 @@ void __wait_on_buffer(struct buffer_head
 wait_queue_head_t *bh_waitq_head(struct buffer_head *bh);
 int fsync_bdev(struct block_device *);
 struct super_block *freeze_bdev(struct block_device *);
+void emergency_thaw(void);
 int thaw_bdev(struct block_device *, struct super_block *);
 int fsync_super(struct super_block *);
 int fsync_no_super(struct block_device *);
Documentation/sysrq.txt +2 -1
Index: linux-2.6/Documentation/sysrq.txt
===================================================================
@@ -101,7 +101,8 @@ On all -  write a character to /proc/sys
 
 'r'     - Turns off keyboard raw mode and sets it to XLATE.
 
-'s'     - Will attempt to sync all mounted filesystems.
+'s'     - Will attempt to sync all mounted filesystems, and unfreeze
+	  any frozen fileystems.
 
 't'     - Will dump a list of current tasks and their information to your
           console.
#1 lore raw
Quoted 7 lines · On Wed, 14 Jan 2009 22:06:17 -0600 Eric Sandeen <[email protected]> wrote:

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

Quoted 6 lines

This doesn't have to piggyback on the existing emergency sync sysrq, but it seems like a reasonable, simple addition to me.

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

Worried.

Under what operational scenarios is ths feature actually needed/used?

Quoted 8 lines

---

Index: linux-2.6/drivers/char/sysrq.c
===================================================================

drivers/char/sysrq.c static struct sysrq_key_op sysrq_reboot_ · line 156

Quoted 6 lines
drivers/char/sysrq.c +1 -0
@@ -151,6 +151,7 @@ static struct sysrq_key_op sysrq_reboot_
 
 static void sysrq_handle_sync(int key, struct tty_struct *tty)
 {
+	emergency_thaw();
 	emergency_sync();
 }

Kind of weird. The thaw will happen after/during the sync().

I guess that if the sync is blocked on a frozen fs then things will sort themselves out.

otoh, if all the pdflush threads are blocked on frozen filesystems (possible?) then the emergency_thaw() simply won't do anything.

Quoted 6 lines

===================================================================

fs/buffer.c +0 -0
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);

fs/buffer.c struct super_block *freeze_bdev(struct b · line 269

Quoted 10 lines
fs/buffer.c +9 -0
 
+void do_thaw(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));

hm, I made the args to bdevname() backwards. Bad me.

Quoted 3 lines
fs/buffer.c +3 -0
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
#2 lore raw
Quoted 13 lines · Andrew Morton
Quoted 10 lines · On Wed, 14 Jan 2009 22:06:17 -0600 Eric Sandeen <[email protected]> wrote:

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

This doesn't have to piggyback on the existing emergency sync sysrq, but it seems like a reasonable, simple addition to me.

Quoted 7 lines
Quoted 3 lines

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

Worried.

Under what operational scenarios is ths feature actually needed/used?

Well, if you freeze root and do some things that require IO there, you can get stuck pretty easily

(hacked xfs_io to call the ioctl here)

[root@inode io]# ./xfs_io -r -x -F -c "freeze" /
[root@inode io]# ls
^Z
^C
<tap tap.. uhoh>

Quoted 9 lines
Quoted 9 lines

---

Index: linux-2.6/drivers/char/sysrq.c
===================================================================

drivers/char/sysrq.c +0 -0
@@ -151,6 +151,7 @@ static struct sysrq_key_op sysrq_reboot_
 
Quoted 7 lines

drivers/char/sysrq.c static struct sysrq_key_op sysrq_reboot_ · line 156

Quoted 5 lines
drivers/char/sysrq.c +1 -0
 static void sysrq_handle_sync(int key, struct tty_struct *tty)
 {
+	emergency_thaw();
 	emergency_sync();
 }

Kind of weird. The thaw will happen after/during the sync().

oh, hrm. Maybe I didn't think enough about how it's handed off to pdflush; I could rearrange if that makes sense? Or maybe handing to pdflush is wrong, it was just so convenient....

Quoted 5 lines

I guess that if the sync is blocked on a frozen fs then things will sort themselves out.

otoh, if all the pdflush threads are blocked on frozen filesystems (possible?) then the emergency_thaw() simply won't do anything.

Hm, maybe possible... I'll have to think about that.

Thanks,
-Eric

Quoted 23 lines
Quoted 6 lines

===================================================================

fs/buffer.c +0 -0
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);

fs/buffer.c struct super_block *freeze_bdev(struct b · line 269

Quoted 10 lines
fs/buffer.c +9 -0
 
+void do_thaw(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));

hm, I made the args to bdevname() backwards. Bad me.

Quoted 3 lines
fs/buffer.c +3 -0
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
#3 lore raw
Quoted 3 lines · Eric Sandeen
Quoted 2 lines · Andrew Morton

On Wed, 14 Jan 2009 22:06:17 -0600
Eric Sandeen <[email protected]> wrote:

...

Quoted 17 lines
Quoted 6 lines
Quoted 6 lines

Index: linux-2.6/drivers/char/sysrq.c
===================================================================

drivers/char/sysrq.c +0 -0
@@ -151,6 +151,7 @@ static struct sysrq_key_op sysrq_reboot_
 
Quoted 6 lines

drivers/char/sysrq.c static struct sysrq_key_op sysrq_reboot_ · line 156

Quoted 5 lines
drivers/char/sysrq.c +1 -0
 static void sysrq_handle_sync(int key, struct tty_struct *tty)
 {
+	emergency_thaw();
 	emergency_sync();
 }

Kind of weird. The thaw will happen after/during the sync().

oh, hrm. Maybe I didn't think enough about how it's handed off to pdflush; I could rearrange if that makes sense? Or maybe handing to pdflush is wrong, it was just so convenient....

Quoted 7 lines
Quoted 5 lines

I guess that if the sync is blocked on a frozen fs then things will sort themselves out.

otoh, if all the pdflush threads are blocked on frozen filesystems (possible?) then the emergency_thaw() simply won't do anything.

Hm, maybe possible... I'll have to think about that.

Oh, actually, I'd think not. If the freeze was done properly by the filesystem, all data was flushed, the fs was quiesced, and new IO was blocked. pdflush should never be visiting these...

In fact emergency sync is kind of orthogonal to emergency thaw, anything which needs a thaw should never actually need a sync.

-Eric

Quoted 2 lines

Thanks,
-Eric

#4 lore raw
Quoted 3 lines · Eric Sandeen

Oh, actually, I'd think not. If the freeze was done properly by the filesystem, all data was flushed, the fs was quiesced, and new IO was blocked. pdflush should never be visiting these...

Yes, but a lot of 'if's - and usually you're reaching for sysrq-S precisely *because* you suspect that stuff wasn't happening properly on its own...

#5 lore raw
Quoted 8 lines · [email protected] wrote:
Quoted 3 lines · Eric Sandeen

Oh, actually, I'd think not. If the freeze was done properly by the filesystem, all data was flushed, the fs was quiesced, and new IO was blocked. pdflush should never be visiting these...

Yes, but a lot of 'if's - and usually you're reaching for sysrq-S precisely *because* you suspect that stuff wasn't happening properly on its own...

Actually, only one if - if the fs implemented freeze properly.

Well, the use case I envision here is something like:

# freeze /my/mount/point/to/fs/to/snapshot

except oops, that wasn't mounted, and you just froze your root fs.

I was thinking more recovery from admin error, not programming error...

If we're using sysrq to work around any possible programming error, then we have a pretty tough job to make sure that it always works, no?

-Eric

#6 lore raw
In reply to Eric Sandeen
Quoted 18 lines · Eric Sandeen
Quoted 9 lines · Andrew Morton
Quoted 6 lines · On Wed, 14 Jan 2009 22:06:17 -0600 Eric Sandeen <[email protected]> wrote:

Index: linux-2.6/drivers/char/sysrq.c
===================================================================

drivers/char/sysrq.c +0 -0
@@ -151,6 +151,7 @@ static struct sysrq_key_op sysrq_reboot_
 
Quoted 7 lines

drivers/char/sysrq.c static struct sysrq_key_op sysrq_reboot_ · line 156

Quoted 5 lines
drivers/char/sysrq.c +1 -0
 static void sysrq_handle_sync(int key, struct tty_struct *tty)
 {
+	emergency_thaw();
 	emergency_sync();
 }

Kind of weird. The thaw will happen after/during the sync().

Quoted 3 lines

oh, hrm. Maybe I didn't think enough about how it's handed off to pdflush; I could rearrange if that makes sense? Or maybe handing to pdflush is wrong, it was just so convenient....

I don't understand the reason for handing it to pdflush. I would expect thaw to be very fast. Do we expect it to block anywhere, and if so, for very long? Not that I see any problem with it.

Shaggy

Signature · 2 lines
David Kleikamp
IBM Linux Technology Center
#7 lore raw
Quoted 9 lines · Dave Kleikamp
Quoted 3 lines · Eric Sandeen

oh, hrm. Maybe I didn't think enough about how it's handed off to pdflush; I could rearrange if that makes sense? Or maybe handing to pdflush is wrong, it was just so convenient....

I don't understand the reason for handing it to pdflush. I would expect thaw to be very fast. Do we expect it to block anywhere, and if so, for very long? Not that I see any problem with it.

Eric pointed out on irc that this is in interrupt context, so even taking a mutex is not allowed. I now agree that handing it to pdflush is reasonable.

Shaggy

Signature · 2 lines
David Kleikamp
IBM Linux Technology Center
#8 lore raw
In reply to Eric Sandeen
Quoted 7 lines

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

Quoted 6 lines

This doesn't have to piggyback on the existing emergency sync sysrq, but it seems like a reasonable, simple addition to me.

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

Emergency Sync should not do this. Invent another key.

...because otherwise, if you hit emergency sync but the system is still alive and relies on filesystem freezing, bad stuff will happen.

Pavel

Quoted 81 lines

---

Index: linux-2.6/drivers/char/sysrq.c
===================================================================

drivers/char/sysrq.c +1 -0
@@ -151,6 +151,7 @@ static struct sysrq_key_op sysrq_reboot_
 
 static void sysrq_handle_sync(int key, struct tty_struct *tty)
 {
+	emergency_thaw();
 	emergency_sync();
 }
 static struct sysrq_key_op sysrq_sync_op = {

Index: linux-2.6/fs/buffer.c
===================================================================

fs/buffer.c +23 -0
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
+
+/**
+ * emergency_thaw -- force thaw every filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq
+ */
+void emergency_thaw(void)
+{
+	pdflush_operation(do_thaw, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock

Index: linux-2.6/include/linux/buffer_head.h
===================================================================

include/linux/buffer_head.h +1 -0
@@ -171,6 +171,7 @@ void __wait_on_buffer(struct buffer_head
 wait_queue_head_t *bh_waitq_head(struct buffer_head *bh);
 int fsync_bdev(struct block_device *);
 struct super_block *freeze_bdev(struct block_device *);
+void emergency_thaw(void);
 int thaw_bdev(struct block_device *, struct super_block *);
 int fsync_super(struct super_block *);
 int fsync_no_super(struct block_device *);

Index: linux-2.6/Documentation/sysrq.txt
===================================================================

Documentation/sysrq.txt +2 -2
@@ -101,7 +101,8 @@ On all -  write a character to /proc/sys
 
 'r'     - Turns off keyboard raw mode and sets it to XLATE.
 
-'s'     - Will attempt to sync all mounted filesystems.
+'s'     - Will attempt to sync all mounted filesystems, and unfreeze
+	  any frozen fileystems.
 
 't'     - Will dump a list of current tasks and their information to your
           console.
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#9 lore raw
Quoted 4 lines · Pavel Machek

Emergency Sync should not do this. Invent another key.

...because otherwise, if you hit emergency sync but the system is still alive and relies on filesystem freezing, bad stuff will happen.

Under what conditions would a system be alive and relying on freezing, *and* an emergency thaw would be worse than whatever reason you're doing an emergency sync?

Hmm.. guess you *could* get into trouble if you tried to do a Sysrq-[not-s] and hit the wrong key - but you have the same danger if you have *any* sysrq- invoking an emergency_thaw and hit it by accident...

#10 lore raw
Quoted 7 lines · [email protected] wrote:
Quoted 4 lines · Pavel Machek

Emergency Sync should not do this. Invent another key.

...because otherwise, if you hit emergency sync but the system is still alive and relies on filesystem freezing, bad stuff will happen.

Quoted 7 lines

Under what conditions would a system be alive and relying on freezing, *and* an emergency thaw would be worse than whatever reason you're doing an emergency sync?

Hmm.. guess you *could* get into trouble if you tried to do a Sysrq-[not-s] and hit the wrong key - but you have the same danger if you have *any* sysrq- invoking an emergency_thaw and hit it by accident...

I could certainly use up another key ('z' is available for unfreeZe) but I have the same question; under what conditions do you expect to need an emergency sync and also need to maintain frozen filesystems as frozen?

Quoted 1 line

From a maximum flexibility and control perspective, it'd be better to

have them separated I suppose. Is it worth using up another available key?

-Eric

#11 lore raw
In reply to [email protected]
Quoted 10 lines · On Fri 2009-01-16 10:17:09, [email protected] wrote:
Quoted 4 lines · Pavel Machek

Emergency Sync should not do this. Invent another key.

...because otherwise, if you hit emergency sync but the system is still alive and relies on filesystem freezing, bad stuff will happen.

Under what conditions would a system be alive and relying on freezing, *and* an emergency thaw would be worse than whatever reason you're doing an emergency sync?

I sometimes hit emergency sync on perfectly healthy system... like before "insmod shiny-new-guaranteed-to-work-module"... I believe sysrq-s should not have sideffects.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#12 lore raw
In reply to [email protected]
Quoted 7 lines · On Fri, Jan 16, 2009 at 10:17:09AM -0500, [email protected] wrote:
Quoted 4 lines · Pavel Machek

Emergency Sync should not do this. Invent another key.

...because otherwise, if you hit emergency sync but the system is still alive and relies on filesystem freezing, bad stuff will happen.

Quoted 7 lines

Under what conditions would a system be alive and relying on freezing, *and* an emergency thaw would be worse than whatever reason you're doing an emergency sync?

Hmm.. guess you *could* get into trouble if you tried to do a Sysrq-[not-s] and hit the wrong key - but you have the same danger if you have *any* sysrq- invoking an emergency_thaw and hit it by accident...

My biggest complaint is that the two operations are largely orthogonal. Emergency sync and unfreeze are two very different operations, and while emergency sync is largely harmless, it just seems really unclean to combine the two. For one thing, it'll be extremely non-obvious that emergency sync implies unfreeze, and changing the sysrq help to say emergency-Sync-and-unfreeze just screams "kludge"....

- Ted

#13 lore raw
Quoted 7 lines · Theodore Tso

My biggest complaint is that the two operations are largely orthogonal. Emergency sync and unfreeze are two very different operations, and while emergency sync is largely harmless, it just seems really unclean to combine the two. For one thing, it'll be extremely non-obvious that emergency sync implies unfreeze, and changing the sysrq help to say emergency-Sync-and-unfreeze just screams "kludge"....

Fair enough - as it is, I usually end up doing sysrq-s, -s, -u, -s, -b anyhow because each sysrq- does one little thing, adding another little thing on some other control-meta-alt-cokebottle key *is* probably the right choice, we still have a few keyscan codes left.. ;)

#14 lore raw
In reply to Theodore Tso
Quoted 23 lines · Theodore Tso
Quoted 6 lines · On Fri, Jan 16, 2009 at 10:17:09AM -0500, [email protected] wrote:
Quoted 4 lines · Pavel Machek

Emergency Sync should not do this. Invent another key.

...because otherwise, if you hit emergency sync but the system is still alive and relies on filesystem freezing, bad stuff will happen.

Quoted 7 lines

Under what conditions would a system be alive and relying on freezing, *and* an emergency thaw would be worse than whatever reason you're doing an emergency sync?

Hmm.. guess you *could* get into trouble if you tried to do a Sysrq-[not-s] and hit the wrong key - but you have the same danger if you have *any* sysrq- invoking an emergency_thaw and hit it by accident...

My biggest complaint is that the two operations are largely orthogonal. Emergency sync and unfreeze are two very different operations, and while emergency sync is largely harmless, it just seems really unclean to combine the two. For one thing, it'll be extremely non-obvious that emergency sync implies unfreeze, and changing the sysrq help to say emergency-Sync-and-unfreeze just screams "kludge"....

Quoted 1 line

- Ted

Yeah, they really are orthogonal, it's true. Ok, if people are willing to give up 'z' I'll move it there.

-Eric

#15 lore raw

PATCH v2 1/1 Allow SysRq emergency thaw to thaw frozen filesystems

In reply to Eric Sandeen

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

I chose 'j' as the last remaining character other than 'h' which is sort of reserved for help (because help is generated on any unknown character).

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

Thanks,
-Eric

---

drivers/char/sysrq.c +13 -2
Index: linux-2.6/drivers/char/sysrq.c
===================================================================
@@ -346,6 +346,17 @@ static struct sysrq_key_op sysrq_moom_op
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
 
+static void sysrq_handle_thaw(int key, struct tty_struct *tty)
+{
+	emergency_thaw_all();
+}
+static struct sysrq_key_op sysrq_thaw_op = {
+	.handler	= sysrq_handle_thaw,
+	.help_msg	= "Thaw(J)",
+	.action_msg	= "Emergency Thaw of all frozen filesystems",
+	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
+};
+
 static void sysrq_handle_kill(int key, struct tty_struct *tty)
 {
 	send_sig_all(SIGKILL);
@@ -396,9 +407,9 @@ static struct sysrq_key_op *sysrq_key_ta
 	&sysrq_moom_op,			/* f */
 	/* g: May be registered by ppc for kgdb */
 	NULL,				/* g */
-	NULL,				/* h */
+	NULL,				/* h - reserved for help */
 	&sysrq_kill_op,			/* i */
-	NULL,				/* j */
+	&sysrq_thaw_op,			/* j */
 	&sysrq_SAK_op,			/* k */
 #ifdef CONFIG_SMP
 	&sysrq_showallcpus_op,		/* l */
fs/buffer.c +23 -0
Index: linux-2.6/fs/buffer.c
===================================================================
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw_all(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
+
+/**
+ * emergency_thaw_all -- forcibly thaw every frozen filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq-z
+ */
+void emergency_thaw_all(void)
+{
+	pdflush_operation(do_thaw_all, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock
include/linux/buffer_head.h +1 -0
Index: linux-2.6/include/linux/buffer_head.h
===================================================================
@@ -171,6 +171,7 @@ void __wait_on_buffer(struct buffer_head
 wait_queue_head_t *bh_waitq_head(struct buffer_head *bh);
 int fsync_bdev(struct block_device *);
 struct super_block *freeze_bdev(struct block_device *);
+void emergency_thaw_all(void);
 int thaw_bdev(struct block_device *, struct super_block *);
 int fsync_super(struct super_block *);
 int fsync_no_super(struct block_device *);
Documentation/sysrq.txt +5 -0
Index: linux-2.6/Documentation/sysrq.txt
===================================================================
@@ -81,6 +81,8 @@ On all -  write a character to /proc/sys
 
 'i'     - Send a SIGKILL to all processes, except for init.
 
+'j'	- Forcibly "Just thaw it" - filesystems frozen by the FIFREEZE ioctl.
+
 'k'     - Secure Access Key (SAK) Kills all programs on the current virtual
           console. NOTE: See important comments below in SAK section.
 
@@ -160,6 +162,9 @@ t'E'rm and k'I'll are useful if you have
 are unable to kill any other way, especially if it's spawning other
 processes.
 
+"'J'ust thaw it" is useful if your system becomes unresponsive due to a frozen
+(probably root) filesystem via the FIFREEZE ioctl.
+
 *  Sometimes SysRq seems to get 'stuck' after using it, what can I do?
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 That happens to me, also. I've found that tapping shift, alt, and control
#16 lore raw

Re: [PATCH V2] Allow SysRq emergency thaw to thaw frozen filesystems

Quoted 29 lines · Eric Sandeen

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

I chose 'j' as the last remaining character other than 'h' which is sort of reserved for help (because help is generated on any unknown character).

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

Thanks,
-Eric

---

Index: linux-2.6/drivers/char/sysrq.c
===================================================================

drivers/char/sysrq.c static struct sysrq_key_op sysrq_moom_op · line 355

Quoted 10 lines
drivers/char/sysrq.c +7 -0
@@ -346,6 +346,17 @@ static struct sysrq_key_op sysrq_moom_op
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
 
+static void sysrq_handle_thaw(int key, struct tty_struct *tty)
+{
+	emergency_thaw_all();
+}
+static struct sysrq_key_op sysrq_thaw_op = {
+	.handler	= sysrq_handle_thaw,
+	.help_msg	= "Thaw(J)",

Can the help text be less terse, e.g.: "thaw-filesystems(J)" ?

Not capital-T Thaw because that was used to mean "use sysrq-T" to invoke this sysrq.

drivers/char/sysrq.c static struct sysrq_key_op *sysrq_key_ta · line 410

Quoted 13 lines
drivers/char/sysrq.c +5 -1
+	.action_msg	= "Emergency Thaw of all frozen filesystems",
+	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
+};
+
 static void sysrq_handle_kill(int key, struct tty_struct *tty)
 {
 	send_sig_all(SIGKILL);
@@ -396,9 +407,9 @@ static struct sysrq_key_op *sysrq_key_ta
 	&sysrq_moom_op,			/* f */
 	/* g: May be registered by ppc for kgdb */
 	NULL,				/* g */
-	NULL,				/* h */
+	NULL,				/* h - reserved for help */

Yes, thanks.

Quoted 21 lines
drivers/char/sysrq.c +1 -1
 	&sysrq_kill_op,			/* i */
-	NULL,				/* j */
+	&sysrq_thaw_op,			/* j */
 	&sysrq_SAK_op,			/* k */
 #ifdef CONFIG_SMP
 	&sysrq_showallcpus_op,		/* l */

Index: linux-2.6/fs/buffer.c
===================================================================

fs/buffer.c +7 -0
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw_all(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))

fs/buffer.c struct super_block *freeze_bdev(struct b · line 277

Quoted 10 lines
fs/buffer.c +10 -0
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
+
+/**
+ * emergency_thaw_all -- forcibly thaw every frozen filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq-z
                                                              -j
Quoted 9 lines
fs/buffer.c +6 -0
+ */
+void emergency_thaw_all(void)
+{
+	pdflush_operation(do_thaw_all, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock
Signature · 1 line
~Randy
#17 lore raw

Re: [PATCH V2] Allow SysRq emergency thaw to thaw frozen filesystems

Quoted 33 lines · Randy Dunlap
Quoted 32 lines · Eric Sandeen

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

I chose 'j' as the last remaining character other than 'h' which is sort of reserved for help (because help is generated on any unknown character).

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

Thanks,
-Eric

---

Index: linux-2.6/drivers/char/sysrq.c
===================================================================

drivers/char/sysrq.c +0 -0
@@ -346,6 +346,17 @@ static struct sysrq_key_op sysrq_moom_op
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
 
Quoted 9 lines

drivers/char/sysrq.c static struct sysrq_key_op sysrq_moom_op · line 355

Quoted 7 lines
drivers/char/sysrq.c +7 -0
+static void sysrq_handle_thaw(int key, struct tty_struct *tty)
+{
+	emergency_thaw_all();
+}
+static struct sysrq_key_op sysrq_thaw_op = {
+	.handler	= sysrq_handle_thaw,
+	.help_msg	= "Thaw(J)",

Can the help text be less terse, e.g.: "thaw-filesystems(J)" ?

Sure, that's good.

Quoted 4 lines

Not capital-T Thaw because that was used to mean "use sysrq-T" to invoke this sysrq.

Quoted 15 lines

drivers/char/sysrq.c static struct sysrq_key_op *sysrq_key_ta · line 410

Quoted 13 lines
drivers/char/sysrq.c +5 -1
+	.action_msg	= "Emergency Thaw of all frozen filesystems",
+	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
+};
+
 static void sysrq_handle_kill(int key, struct tty_struct *tty)
 {
 	send_sig_all(SIGKILL);
@@ -396,9 +407,9 @@ static struct sysrq_key_op *sysrq_key_ta
 	&sysrq_moom_op,			/* f */
 	/* g: May be registered by ppc for kgdb */
 	NULL,				/* g */
-	NULL,				/* h */
+	NULL,				/* h - reserved for help */

Yes, thanks.

:)

Quoted 25 lines
Quoted 25 lines
drivers/char/sysrq.c +1 -1
 	&sysrq_kill_op,			/* i */
-	NULL,				/* j */
+	&sysrq_thaw_op,			/* j */
 	&sysrq_SAK_op,			/* k */
 #ifdef CONFIG_SMP
 	&sysrq_showallcpus_op,		/* l */

Index: linux-2.6/fs/buffer.c
===================================================================

fs/buffer.c +11 -0
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw_all(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
Quoted 8 lines

fs/buffer.c struct super_block *freeze_bdev(struct b · line 277

Quoted 6 lines
fs/buffer.c +6 -0
+}
+
+/**
+ * emergency_thaw_all -- forcibly thaw every frozen filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq-z
                                                              -j

Oops, was going to be unfreeZe 'til I realized peterz took that already!

-Eric

Quoted 11 lines
Quoted 9 lines
fs/buffer.c +6 -0
+ */
+void emergency_thaw_all(void)
+{
+	pdflush_operation(do_thaw_all, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock
#18 lore raw

PATCH v3 1/1 Allow SysRq emergency thaw to thaw frozen filesystems

In reply to Eric Sandeen

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

I chose 'j' as the last remaining character other than 'h' which is sort of reserved for help (because help is generated on any unknown character).

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

(this version fixes a couple small issues raised by Randy Dunlap)

Thanks,
-Eric

---

drivers/char/sysrq.c +13 -2
Index: linux-2.6/drivers/char/sysrq.c
===================================================================
@@ -346,6 +346,17 @@ static struct sysrq_key_op sysrq_moom_op
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
 
+static void sysrq_handle_thaw(int key, struct tty_struct *tty)
+{
+	emergency_thaw_all();
+}
+static struct sysrq_key_op sysrq_thaw_op = {
+	.handler	= sysrq_handle_thaw,
+	.help_msg	= "thaw-filesystems(J)",
+	.action_msg	= "Emergency Thaw of all frozen filesystems",
+	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
+};
+
 static void sysrq_handle_kill(int key, struct tty_struct *tty)
 {
 	send_sig_all(SIGKILL);
@@ -396,9 +407,9 @@ static struct sysrq_key_op *sysrq_key_ta
 	&sysrq_moom_op,			/* f */
 	/* g: May be registered by ppc for kgdb */
 	NULL,				/* g */
-	NULL,				/* h */
+	NULL,				/* h - reserved for help */
 	&sysrq_kill_op,			/* i */
-	NULL,				/* j */
+	&sysrq_thaw_op,			/* j */
 	&sysrq_SAK_op,			/* k */
 #ifdef CONFIG_SMP
 	&sysrq_showallcpus_op,		/* l */
fs/buffer.c +23 -0
Index: linux-2.6/fs/buffer.c
===================================================================
@@ -258,6 +258,29 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw_all(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
+
+/**
+ * emergency_thaw_all -- forcibly thaw every frozen filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq
+ */
+void emergency_thaw_all(void)
+{
+	pdflush_operation(do_thaw_all, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock
include/linux/buffer_head.h +1 -0
Index: linux-2.6/include/linux/buffer_head.h
===================================================================
@@ -171,6 +171,7 @@ void __wait_on_buffer(struct buffer_head
 wait_queue_head_t *bh_waitq_head(struct buffer_head *bh);
 int fsync_bdev(struct block_device *);
 struct super_block *freeze_bdev(struct block_device *);
+void emergency_thaw_all(void);
 int thaw_bdev(struct block_device *, struct super_block *);
 int fsync_super(struct super_block *);
 int fsync_no_super(struct block_device *);
Documentation/sysrq.txt +5 -0
Index: linux-2.6/Documentation/sysrq.txt
===================================================================
@@ -81,6 +81,8 @@ On all -  write a character to /proc/sys
 
 'i'     - Send a SIGKILL to all processes, except for init.
 
+'j'	- Forcibly "Just thaw it" - filesystems frozen by the FIFREEZE ioctl.
+
 'k'     - Secure Access Key (SAK) Kills all programs on the current virtual
           console. NOTE: See important comments below in SAK section.
 
@@ -160,6 +162,9 @@ t'E'rm and k'I'll are useful if you have
 are unable to kill any other way, especially if it's spawning other
 processes.
 
+"'J'ust thaw it" is useful if your system becomes unresponsive due to a frozen
+(probably root) filesystem via the FIFREEZE ioctl.
+
 *  Sometimes SysRq seems to get 'stuck' after using it, what can I do?
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 That happens to me, also. I've found that tapping shift, alt, and control
#19 lore raw

Re: [PATCH V3] Allow SysRq emergency thaw to thaw frozen filesystems

fs/buffer.c struct super_block *freeze_bdev(struct b · line 272

Quoted 12 lines · On Fri, 16 Jan 2009 13:50:19 -0600 Eric Sandeen <[email protected]> wrote:
fs/buffer.c +12 -0
+void do_thaw_all(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}

Is there any reason why we're not taking the appropriate locks here?

If so, please add a comment justifying the implementation.

Quoted 9 lines
fs/buffer.c +9 -0
+/**
+ * emergency_thaw_all -- forcibly thaw every frozen filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq
+ */
+void emergency_thaw_all(void)
+{
+	pdflush_operation(do_thaw_all, 0);
+}
#20 lore raw

PATCH v4 1/1 Allow SysRq emergency thaw to thaw frozen filesystems

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

I chose 'j' as the last remaining character other than 'h' which is sort of reserved for help (because help is generated on any unknown character).

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

(this version fixes a couple small issues raised by Randy Dunlap) (and adds sb_lock locking I forgot, as akpm pointed out) (Randy's CONFIG_BLOCK fix should still apply over this)

Thanks,
-Eric

---

drivers/char/sysrq.c +13 -2
Index: linux-2.6/drivers/char/sysrq.c
===================================================================
@@ -346,6 +346,17 @@ static struct sysrq_key_op sysrq_moom_op
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
 
+static void sysrq_handle_thaw(int key, struct tty_struct *tty)
+{
+	emergency_thaw_all();
+}
+static struct sysrq_key_op sysrq_thaw_op = {
+	.handler	= sysrq_handle_thaw,
+	.help_msg	= "thaw-filesystems(J)",
+	.action_msg	= "Emergency Thaw of all frozen filesystems",
+	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
+};
+
 static void sysrq_handle_kill(int key, struct tty_struct *tty)
 {
 	send_sig_all(SIGKILL);
@@ -396,9 +407,9 @@ static struct sysrq_key_op *sysrq_key_ta
 	&sysrq_moom_op,			/* f */
 	/* g: May be registered by ppc for kgdb */
 	NULL,				/* g */
-	NULL,				/* h */
+	NULL,				/* h - reserved for help */
 	&sysrq_kill_op,			/* i */
-	NULL,				/* j */
+	&sysrq_thaw_op,			/* j */
 	&sysrq_SAK_op,			/* k */
 #ifdef CONFIG_SMP
 	&sysrq_showallcpus_op,		/* l */
fs/buffer.c +25 -0
Index: linux-2.6/fs/buffer.c
===================================================================
@@ -258,6 +258,31 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw_all(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	spin_lock(&sb_lock);
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+	}
+	spin_unlock(&sb_lock);
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
+
+/**
+ * emergency_thaw_all -- forcibly thaw every frozen filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq
+ */
+void emergency_thaw_all(void)
+{
+	pdflush_operation(do_thaw_all, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock
include/linux/buffer_head.h +1 -0
Index: linux-2.6/include/linux/buffer_head.h
===================================================================
@@ -171,6 +171,7 @@ void __wait_on_buffer(struct buffer_head
 wait_queue_head_t *bh_waitq_head(struct buffer_head *bh);
 int fsync_bdev(struct block_device *);
 struct super_block *freeze_bdev(struct block_device *);
+void emergency_thaw_all(void);
 int thaw_bdev(struct block_device *, struct super_block *);
 int fsync_super(struct super_block *);
 int fsync_no_super(struct block_device *);
Documentation/sysrq.txt +5 -0
Index: linux-2.6/Documentation/sysrq.txt
===================================================================
@@ -81,6 +81,8 @@ On all -  write a character to /proc/sys
 
 'i'     - Send a SIGKILL to all processes, except for init.
 
+'j'	- Forcibly "Just thaw it" - filesystems frozen by the FIFREEZE ioctl.
+
 'k'     - Secure Access Key (SAK) Kills all programs on the current virtual
           console. NOTE: See important comments below in SAK section.
 
@@ -160,6 +162,9 @@ t'E'rm and k'I'll are useful if you have
 are unable to kill any other way, especially if it's spawning other
 processes.
 
+"'J'ust thaw it" is useful if your system becomes unresponsive due to a frozen
+(probably root) filesystem via the FIFREEZE ioctl.
+
 *  Sometimes SysRq seems to get 'stuck' after using it, what can I do?
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 That happens to me, also. I've found that tapping shift, alt, and control
#21 lore raw

Re: [PATCH V4] Allow SysRq emergency thaw to thaw frozen filesystems

Quoted 5 lines · Eric Sandeen

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

If you don't have console access, you're just logged in remotely, is there a way to do an emergency unthaw from a shell command?

-- Jamie

#22 lore raw

Re: [PATCH V4] Allow SysRq emergency thaw to thaw frozen filesystems

Quoted 9 lines · Jamie Lokier
Quoted 5 lines · Eric Sandeen

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

If you don't have console access, you're just logged in remotely, is there a way to do an emergency unthaw from a shell command?

echo j > /proc/sysrq-trigger

Shaggy

Signature · 2 lines
David Kleikamp
IBM Linux Technology Center
#23 lore raw

Re: [PATCH V4] Allow SysRq emergency thaw to thaw frozen filesystems

In reply to Jamie Lokier
Quoted 9 lines · Jamie Lokier
Quoted 5 lines · Eric Sandeen

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

If you don't have console access, you're just logged in remotely, is there a way to do an emergency unthaw from a shell command?

                                 ^^^^^^

That's a freeze, right? ;)

Anyway, I think you could use /proc/sysrq-trigger in that situation.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#24 lore raw

Re: [PATCH V4] Allow SysRq emergency thaw to thaw frozen filesystems

In reply to Eric Sandeen
Quoted 3 lines · On Mon, 02 Feb 2009 16:55:18 -0600 Eric Sandeen <[email protected]> wrote:

(this version fixes a couple small issues raised by Randy Dunlap) (and adds sb_lock locking I forgot, as akpm pointed out) (Randy's CONFIG_BLOCK fix should still apply over this)

<converts it to a delta so I can see what you did>

fs/buffer.c renamed from fs/buffer.c~allow-sysrq-emergency-thaw-to-thaw-frozen-filesystems-v4 +2 -0
@@ -263,11 +263,13 @@ void do_thaw_all(unsigned long unused)
 	struct super_block *sb;
 	char b[BDEVNAME_SIZE];
 
+	spin_lock(&sb_lock);
 	list_for_each_entry(sb, &super_blocks, s_list) {
 		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
 			printk(KERN_WARNING "Emergency Thaw on %s\n",
 			       bdevname(sb->s_bdev, b));
 	}
+	spin_unlock(&sb_lock);
 	printk(KERN_WARNING "Emergency Thaw complete\n");
 }
 

_

Can't call thaw_bdev() under spinlock.

If we're going to do this, I think it will need the whole sb_lock/s_count/s_umount song-n-dance.

It's a pretty common operation. What you want is, I think, identical to sync_supers(), only with one line changed.

so we could do

void apply_to_all_supers(void (fn)(struct super_block *))

{
	struct super_block *sb;

	spin_lock(&sb_lock);
restart:
	list_for_each_entry(sb, &super_blocks, s_list) {
		if (sb->s_dirt) {
			sb->s_count++;
			spin_unlock(&sb_lock);
			down_read(&sb->s_umount);
			(*fn)(sb);
			up_read(&sb->s_umount);
			spin_lock(&sb_lock);
			if (__put_super_and_need_restart(sb))
				goto restart;
		}
	}
	spin_unlock(&sb_lock);

}

That isn't quite sufficient to use for get_super(), but I think it could be made so.

Ditto user_get_super().

Ditto do_emergency_remount()

But that's a separate little project for someone. For the purposes of this patch I guess you could do yet another copy-n-paste.

#25 lore raw

Re: [PATCH V4] Allow SysRq emergency thaw to thaw frozen filesystems

Quoted 8 lines · Andrew Morton
Quoted 3 lines · On Mon, 02 Feb 2009 16:55:18 -0600 Eric Sandeen <[email protected]> wrote:

(this version fixes a couple small issues raised by Randy Dunlap) (and adds sb_lock locking I forgot, as akpm pointed out) (Randy's CONFIG_BLOCK fix should still apply over this)

<converts it to a delta so I can see what you did>

Sorry, didn't know if you want deltas on top of old patches or new respun patches. Guess now I know :)

Quoted 19 lines
fs/buffer.c renamed from fs/buffer.c~allow-sysrq-emergency-thaw-to-thaw-frozen-filesystems-v4 +2 -0
@@ -263,11 +263,13 @@ void do_thaw_all(unsigned long unused)
 	struct super_block *sb;
 	char b[BDEVNAME_SIZE];
 
+	spin_lock(&sb_lock);
 	list_for_each_entry(sb, &super_blocks, s_list) {
 		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
 			printk(KERN_WARNING "Emergency Thaw on %s\n",
 			       bdevname(sb->s_bdev, b));
 	}
+	spin_unlock(&sb_lock);
 	printk(KERN_WARNING "Emergency Thaw complete\n");
 }
 

_

Quoted 1 line

Can't call thaw_bdev() under spinlock.

Oh, sigh, I've come full circle to what I started with that didn't work, didn't I.

Quoted 33 lines

If we're going to do this, I think it will need the whole sb_lock/s_count/s_umount song-n-dance.

It's a pretty common operation. What you want is, I think, identical to sync_supers(), only with one line changed.

so we could do

void apply_to_all_supers(void (fn)(struct super_block *))

{
	struct super_block *sb;

	spin_lock(&sb_lock);
restart:
	list_for_each_entry(sb, &super_blocks, s_list) {
		if (sb->s_dirt) {
			sb->s_count++;
			spin_unlock(&sb_lock);
			down_read(&sb->s_umount);
			(*fn)(sb);
			up_read(&sb->s_umount);
			spin_lock(&sb_lock);
			if (__put_super_and_need_restart(sb))
				goto restart;
		}
	}
	spin_unlock(&sb_lock);

}

That isn't quite sufficient to use for get_super(), but I think it could be made so.

Quoted 6 lines

Ditto user_get_super().

Ditto do_emergency_remount()

But that's a separate little project for someone. For the purposes of this patch I guess you could do yet another copy-n-paste.

Ok, thanks. Sorry for dragging this out through 5 revisions :(

-Eric

#26 lore raw

Re: [PATCH V4] Allow SysRq emergency thaw to thaw frozen filesystems

Quoted 4 lines · On Tue, 03 Feb 2009 16:07:06 -0600 Eric Sandeen <[email protected]> wrote:
Quoted 3 lines · Andrew Morton

On Mon, 02 Feb 2009 16:55:18 -0600
Eric Sandeen <[email protected]> wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

(this version fixes a couple small issues raised by Randy Dunlap) (and adds sb_lock locking I forgot, as akpm pointed out) (Randy's CONFIG_BLOCK fix should still apply over this)

<converts it to a delta so I can see what you did>

Sorry, didn't know if you want deltas on top of old patches or new respun patches. Guess now I know :)

There's no easy answer. For new reviewers/testers, the whole patch is better.

But for people who reviewed/tested the earlier patch, the delta is better.

So a replacement patch is usually OK. I will turn it into a delta with a flick of the wrist and those people who I cc'ed on the patch (and mm-commits subscribers) will get to see the delta.

#27 lore raw

PATCH v5 1/1 Allow SysRq emergency thaw to thaw frozen filesystems

In reply to Andrew Morton

Now that the filesystem freeze operation has been elevated to the VFS, and is just an ioctl away, some sort of safety net for unintentionally frozen root filesystems may be in order.

The timeout thaw originally proposed did not get merged, but perhaps something like this would be useful in emergencies.

For example, freeze /path/to/mountpoint may freeze your root filesystem if you forgot that you had that unmounted.

I chose 'j' as the last remaining character other than 'h' which is sort of reserved for help (because help is generated on any unknown character).

I've tested this on a non-root fs with multiple (nested) freezers, as well as on a system rendered unresponsive due to a frozen root fs.

(this version fixes a couple small issues raised by Randy Dunlap) (and adds sb_lock locking I forgot, as akpm pointed out) (and includes Randy's CONFIG_BLOCK fix)
(and does proper locking, finally)

Thanks,
-Eric

---

drivers/char/sysrq.c +18 -1
Index: linux-2.6.28.x86_64/drivers/char/sysrq.c
===================================================================
@@ -348,6 +348,19 @@ static struct sysrq_key_op sysrq_moom_op
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
 
+#ifdef CONFIG_BLOCK
+static void sysrq_handle_thaw(int key, struct tty_struct *tty)
+{
+	emergency_thaw_all();
+}
+static struct sysrq_key_op sysrq_thaw_op = {
+	.handler	= sysrq_handle_thaw,
+	.help_msg	= "thaw-filesystems(J)",
+	.action_msg	= "Emergency Thaw of all frozen filesystems",
+	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
+};
+#endif
+
 static void sysrq_handle_kill(int key, struct tty_struct *tty)
 {
 	send_sig_all(SIGKILL);
@@ -398,9 +411,13 @@ static struct sysrq_key_op *sysrq_key_ta
 	&sysrq_moom_op,			/* f */
 	/* g: May be registered by ppc for kgdb */
 	NULL,				/* g */
-	NULL,				/* h */
+	NULL,				/* h - reserved for help */
 	&sysrq_kill_op,			/* i */
+#ifdef CONFIG_BLOCK
+	&sysrq_thaw_op,			/* j */
+#else
 	NULL,				/* j */
+#endif
 	&sysrq_SAK_op,			/* k */
 #ifdef CONFIG_SMP
 	&sysrq_showallcpus_op,		/* l */
fs/buffer.c +33 -0
Index: linux-2.6.28.x86_64/fs/buffer.c
===================================================================
@@ -258,6 +258,39 @@ struct super_block *freeze_bdev(struct b
 }
 EXPORT_SYMBOL(freeze_bdev);
 
+void do_thaw_all(unsigned long unused)
+{
+	struct super_block *sb;
+	char b[BDEVNAME_SIZE];
+
+	spin_lock(&sb_lock);
+restart:
+	list_for_each_entry(sb, &super_blocks, s_list) {
+		sb->s_count++;
+		spin_unlock(&sb_lock);
+		down_read(&sb->s_umount);
+		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
+			printk(KERN_WARNING "Emergency Thaw on %s\n",
+			       bdevname(sb->s_bdev, b));
+		up_read(&sb->s_umount);
+		spin_lock(&sb_lock);
+		if (__put_super_and_need_restart(sb))
+			goto restart;
+	}
+	spin_unlock(&sb_lock);
+	printk(KERN_WARNING "Emergency Thaw complete\n");
+}
+
+/**
+ * emergency_thaw_all -- forcibly thaw every frozen filesystem
+ *
+ * Used for emergency unfreeze of all filesystems via SysRq
+ */
+void emergency_thaw_all(void)
+{
+	pdflush_operation(do_thaw_all, 0);
+}
+
 /**
  * thaw_bdev  -- unlock filesystem
  * @bdev:	blockdevice to unlock
include/linux/buffer_head.h +1 -0
Index: linux-2.6.28.x86_64/include/linux/buffer_head.h
===================================================================
@@ -171,6 +171,7 @@ void __wait_on_buffer(struct buffer_head
 wait_queue_head_t *bh_waitq_head(struct buffer_head *bh);
 int fsync_bdev(struct block_device *);
 struct super_block *freeze_bdev(struct block_device *);
+void emergency_thaw_all(void);
 int thaw_bdev(struct block_device *, struct super_block *);
 int fsync_super(struct super_block *);
 int fsync_no_super(struct block_device *);
Documentation/sysrq.txt +5 -0
Index: linux-2.6.28.x86_64/Documentation/sysrq.txt
===================================================================
@@ -81,6 +81,8 @@ On all -  write a character to /proc/sys
 
 'i'     - Send a SIGKILL to all processes, except for init.
 
+'j'     - Forcibly "Just thaw it" - filesystems frozen by the FIFREEZE ioctl.
+
 'k'     - Secure Access Key (SAK) Kills all programs on the current virtual
           console. NOTE: See important comments below in SAK section.
 
@@ -160,6 +162,9 @@ t'E'rm and k'I'll are useful if you have
 are unable to kill any other way, especially if it's spawning other
 processes.
 
+"'J'ust thaw it" is useful if your system becomes unresponsive due to a frozen
+(probably root) filesystem via the FIFREEZE ioctl.
+
 *  Sometimes SysRq seems to get 'stuck' after using it, what can I do?
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 That happens to me, also. I've found that tapping shift, alt, and control