net/gve: Update TX queue state
PATCH 1/1 net/gve: Update TX queue state
Fixing Typo in updating the TX queue state
--- drivers/net/gve/gve_tx.c | 2 +- drivers/net/gve/gve_tx_dqo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/gve/gve_tx.c +1 -1
@@ -688,7 +688,7 @@rte_write32 (rte_cpu_to_be_32 (GVE_IRQ_MASK ), txq->ntfy_addr); - dev->data->rx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ; + dev->data->tx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ;return 0 ; }
drivers/net/gve/gve_tx_dqo.c +1 -1
@@ -392,7 +392,7 @@rte_write32 (rte_cpu_to_be_32 (GVE_IRQ_MASK ), txq->ntfy_addr); - dev->data->rx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ; + dev->data->tx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ;return 0 ; }
Signature · 1 line
1.8.3.1
Quoted 4 lines · Tathagat Priyadarshi
Fixing Typo in updating the TX queue state
Signed-off-by Tathagat Priyadarshi <[email protected]>
Good catch, thanks Tathagat.
I think impact is more than just typo, so let me update the patch title as:
net/gve: fix Tx queue state on queue start
Also needs fixes tag:
With above changes,
Applied to dpdk-next-net/main, thanks.
Quoted 31 lines
--- drivers/net/gve/gve_tx.c | 2 +- drivers/net/gve/gve_tx_dqo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/net/gve/gve_tx.c +1
-1@@ -688,7 +688,7 @@rte_write32 (rte_cpu_to_be_32 (GVE_IRQ_MASK ), txq->ntfy_addr); - dev->data->rx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ; + dev->data->tx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ;return 0 ; }drivers/net/gve/gve_tx_dqo.c +1
-1@@ -392,7 +392,7 @@rte_write32 (rte_cpu_to_be_32 (GVE_IRQ_MASK ), txq->ntfy_addr); - dev->data->rx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ; + dev->data->tx_queue_state[tx_queue_id] =RTE_ETH_QUEUE_STATE_STARTED ;return 0 ; }
Thanks Ferruh.
Quoted 58 lines · Ferruh Yigit
Quoted 4 lines · Tathagat Priyadarshi
Fixing Typo in updating the TX queue state
Signed-off-by Tathagat Priyadarshi <[email protected]>Good catch, thanks Tathagat.
I think impact is more than just typo, so let me update the patch title as:
net/gve: fix Tx queue state on queue start
Also needs fixes tag:
Fixes b044845bb015 ("net/gve: support queue start/stop")With above changes,
Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
Quoted 10 lines
--- drivers/net/gve/gve_tx.c | 2 +- drivers/net/gve/gve_tx_dqo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/net/gve/gve_tx.c +0
-0drivers/net/gve/gve_tx.c line 691
Quoted 4 lines
drivers/net/gve/gve_tx.c +0
-1@@ -688,7 +688,7 @@rte_write32 (rte_cpu_to_be_32 (GVE_IRQ_MASK ), txq->ntfy_addr); - dev->data->rx_queue_state[tx_queue_id] =
RTE_ETH_QUEUE_STATE_STARTED;drivers/net/gve/gve_tx.c line 691
Quoted 1 line
drivers/net/gve/gve_tx.c +1
-0+ dev->data->tx_queue_state[tx_queue_id] =
RTE_ETH_QUEUE_STATE_STARTED;drivers/net/gve/gve_tx_dqo.c line 395
Quoted 12 lines
drivers/net/gve/gve_tx.c +0
-0return 0 ; }drivers/net/gve/gve_tx_dqo.c +0
-1@@ -392,7 +392,7 @@rte_write32 (rte_cpu_to_be_32 (GVE_IRQ_MASK ), txq->ntfy_addr); - dev->data->rx_queue_state[tx_queue_id] =
RTE_ETH_QUEUE_STATE_STARTED;drivers/net/gve/gve_tx_dqo.c line 395
Quoted 1 line
drivers/net/gve/gve_tx_dqo.c +1
-0+ dev->data->tx_queue_state[tx_queue_id] =
RTE_ETH_QUEUE_STATE_STARTED;Quoted 3 lines
drivers/net/gve/gve_tx_dqo.c +0
-0return 0 ; }