net/gve: Fix TX/RX queue setup and stop for DQO
PATCH 1/1 net/gve: Fix TX/RX queue setup and stop for DQO
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop.
--- drivers/net/gve/gve_ethdev.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-)
drivers/net/gve/gve_ethdev.c +21 -5
@@ -289,7 +289,11 @@ struct gve_queue_page_list *return ret; }for (i =0 ; i < num_queues; i++) -if (gve_tx_queue_start (dev, i) !=0 ) { +if (gve_is_gqi (priv)) + ret =gve_tx_queue_start (dev, i); +else + ret =gve_tx_queue_start_dqo (dev, i); +if (ret !=0 ) {PMD_DRV_LOG (ERR ,"Fail to start Tx queue %d" , i); goto err_tx; }
@@ -315,9 +319,15 @@ struct gve_queue_page_list *return 0 ; err_rx: -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_rx_queues (dev); +else +gve_stop_rx_queues_dqo (dev); err_tx: -gve_stop_tx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_tx_queues (dev); +else +gve_stop_tx_queues_dqo (dev);return ret; }
@@ -362,10 +372,16 @@ struct gve_queue_page_list *static int gve_dev_stop (struct rte_eth_dev *dev) { +struct gve_priv *priv = dev->data->dev_private; dev->data->dev_link.link_status =RTE_ETH_LINK_DOWN ; -gve_stop_tx_queues (dev); -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) { +gve_stop_tx_queues (dev); +gve_stop_rx_queues (dev); + }else { +gve_stop_tx_queues_dqo (dev); +gve_stop_rx_queues_dqo (dev); + } dev->data->dev_started =0 ;
Signature · 1 line
1.8.3.1
PATCH v2 1/1 net/gve: Fix TX/RX queue setup and stop
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop.
--- drivers/net/gve/gve_ethdev.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-)
drivers/net/gve/gve_ethdev.c +23 -6
@@ -288,11 +288,16 @@ struct gve_queue_page_list *PMD_DRV_LOG (ERR ,"Failed to create %u tx queues." , num_queues);return ret; } -for (i =0 ; i < num_queues; i++) -if (gve_tx_queue_start (dev, i) !=0 ) { +for (i =0 ; i < num_queues; i++) { +if (gve_is_gqi (priv)) + ret =gve_tx_queue_start (dev, i); +else + ret =gve_tx_queue_start_dqo (dev, i); +if (ret !=0 ) {PMD_DRV_LOG (ERR ,"Fail to start Tx queue %d" , i); goto err_tx; } + } num_queues = dev->data->nb_rx_queues; priv->rxqs = (struct gve_rx_queue **)dev->data->rx_queues;
@@ -315,9 +320,15 @@ struct gve_queue_page_list *return 0 ; err_rx: -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_rx_queues (dev); +else +gve_stop_rx_queues_dqo (dev); err_tx: -gve_stop_tx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_tx_queues (dev); +else +gve_stop_tx_queues_dqo (dev);return ret; }
@@ -362,10 +373,16 @@ struct gve_queue_page_list *static int gve_dev_stop (struct rte_eth_dev *dev) { +struct gve_priv *priv = dev->data->dev_private; dev->data->dev_link.link_status =RTE_ETH_LINK_DOWN ; -gve_stop_tx_queues (dev); -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) { +gve_stop_tx_queues (dev); +gve_stop_rx_queues (dev); + }else { +gve_stop_tx_queues_dqo (dev); +gve_stop_rx_queues_dqo (dev); + } dev->data->dev_started =0 ;
Signature · 1 line
1.8.3.1
PATCH 1/1 net/gve: Fix TX/RX queue setup and stop
In reply to Tathagat PriyadarshiThe PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop.
--- drivers/net/gve/gve_ethdev.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-)
drivers/net/gve/gve_ethdev.c +23 -6
@@ -288,11 +288,16 @@ struct gve_queue_page_list *PMD_DRV_LOG (ERR ,"Failed to create %u tx queues." , num_queues);return ret; } -for (i =0 ; i < num_queues; i++) -if (gve_tx_queue_start (dev, i) !=0 ) { +for (i =0 ; i < num_queues; i++) { +if (gve_is_gqi (priv)) + ret =gve_tx_queue_start (dev, i); +else + ret =gve_tx_queue_start_dqo (dev, i); +if (ret !=0 ) {PMD_DRV_LOG (ERR ,"Fail to start Tx queue %d" , i); goto err_tx; } + } num_queues = dev->data->nb_rx_queues; priv->rxqs = (struct gve_rx_queue **)dev->data->rx_queues;
@@ -315,9 +320,15 @@ struct gve_queue_page_list *return 0 ; err_rx: -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_rx_queues (dev); +else +gve_stop_rx_queues_dqo (dev); err_tx: -gve_stop_tx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_tx_queues (dev); +else +gve_stop_tx_queues_dqo (dev);return ret; }
@@ -362,10 +373,16 @@ struct gve_queue_page_list *static int gve_dev_stop (struct rte_eth_dev *dev) { +struct gve_priv *priv = dev->data->dev_private; dev->data->dev_link.link_status =RTE_ETH_LINK_DOWN ; -gve_stop_tx_queues (dev); -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) { +gve_stop_tx_queues (dev); +gve_stop_rx_queues (dev); + }else { +gve_stop_tx_queues_dqo (dev); +gve_stop_rx_queues_dqo (dev); + } dev->data->dev_started =0 ;
Signature · 1 line
1.8.3.1
Re: [PATCH] net/gve: Fix TX/RX queue setup and stop
Quoted 7 lines · Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop.
Signed-off-by Tathagat Priyadarshi <[email protected]>
Is this v3 ?
And I can see Joshua's ack, but I didn't see it explicitly, did you work together in background for this?
Re: [PATCH] net/gve: Fix TX/RX queue setup and stop
Hi Ferruh,
It’s my mistake, there was a coding error in the first email and i did send out v2, but it somehow didn't go through and i kept getting failure emails, So i fixed and repushed it only to find out later that v2 was also updated. So i had to defer the previous PR.
I have added Acked by Joshua, since the diff was originally shared with him and he was okay with it.
Regards,
TP
Quoted 15 lines · Ferruh Yigit
Quoted 7 lines · Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop.
Signed-off-by Tathagat Priyadarshi <[email protected]>Is this v3 ?
And I can see Joshua's ack, but I didn't see it explicitly, did you work together in background for this?
Re: [PATCH] net/gve: Fix TX/RX queue setup and stop
Quoted 7 lines · Tathagat Priyadarshi
Hi Ferruh,
It’s my mistake, there was a coding error in the first email and i did send out v2, but it somehow didn't go through and i kept getting failure emails, So i fixed and repushed it only to find out later that v2 was also updated. So i had to defer the previous PR.
So, this patch and v2 are same, if so lets continue with v2 one, as it has proper versioning. Can you update patchwork accordingly?
btw, not really matters but PR is "Pull Request" and this is a terminology mostly related to github based development. In mail list based development we call it patch, or "patch series"/patchset (if multiple patches are together).
Quoted 3 lines
I have added Acked by Joshua, since the diff was originally shared with him and he was okay with it.
Better to have this publicly, and explicitly so it is recorded.
@Joshua, if you are OK with patch, can you please ack/review?
Quoted 24 lines
Regards,
TPOn Thu, 25 Jul 2024 at 18:08, Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:
On 7/24/2024 2:35 PM, Tathagat Priyadarshi wrote:
> The PR aims to update the TX/RQ queue setup/stop routines that are > unique to DQO, so that they may be called for instances that use the > DQO RDA format during dev start/stop.
>
> Signed-off-by: Tathagat Priyadarshi <[email protected] <mailto:[email protected]>>
> Acked-by: Joshua Washington <[email protected] <mailto:[email protected]>>
>Is this v3 ?
And I can see Joshua's ack, but I didn't see it explicitly, did you work together in background for this?
PATCH v2 1/1 net/gve: Fix TX/RX queue setup and stop
In reply to Tathagat PriyadarshiThe PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop
--- drivers/net/gve/gve_ethdev.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-)
drivers/net/gve/gve_ethdev.c +23 -6
@@ -288,11 +288,16 @@ struct gve_queue_page_list *PMD_DRV_LOG (ERR ,"Failed to create %u tx queues." , num_queues);return ret; } -for (i =0 ; i < num_queues; i++) -if (gve_tx_queue_start (dev, i) !=0 ) { +for (i =0 ; i < num_queues; i++) { +if (gve_is_gqi (priv)) + ret =gve_tx_queue_start (dev, i); +else + ret =gve_tx_queue_start_dqo (dev, i); +if (ret !=0 ) {PMD_DRV_LOG (ERR ,"Fail to start Tx queue %d" , i); goto err_tx; } + } num_queues = dev->data->nb_rx_queues; priv->rxqs = (struct gve_rx_queue **)dev->data->rx_queues;
@@ -315,9 +320,15 @@ struct gve_queue_page_list *return 0 ; err_rx: -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_rx_queues (dev); +else +gve_stop_rx_queues_dqo (dev); err_tx: -gve_stop_tx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_tx_queues (dev); +else +gve_stop_tx_queues_dqo (dev);return ret; }
@@ -362,10 +373,16 @@ struct gve_queue_page_list *static int gve_dev_stop (struct rte_eth_dev *dev) { +struct gve_priv *priv = dev->data->dev_private; dev->data->dev_link.link_status =RTE_ETH_LINK_DOWN ; -gve_stop_tx_queues (dev); -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) { +gve_stop_tx_queues (dev); +gve_stop_rx_queues (dev); + }else { +gve_stop_tx_queues_dqo (dev); +gve_stop_rx_queues_dqo (dev); + } dev->data->dev_started =0 ;
Signature · 1 line
1.8.3.1
Re: [PATCH v2] net/gve: Fix TX/RX queue setup and stop
Hi @Ferruh Yigit <[email protected]>
I have updated v2
https://patches.dpdk.org/project/dpdk/patch/[email protected]/
and sent it in reply to the previous message id (
https://patches.dpdk.org/project/dpdk/patch/[email protected]/)
, let me know if this is fine.
Quoted 74 lines · Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop
Signed-off-by Tathagat Priyadarshi <[email protected]>--- drivers/net/gve/gve_ethdev.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-)drivers/net/gve/gve_ethdev.c +7
-2@@ -288,11 +288,16 @@ struct gve_queue_page_list *PMD_DRV_LOG (ERR ,"Failed to create %u tx queues." , num_queues);return ret; } -for (i =0 ; i < num_queues; i++) -if (gve_tx_queue_start (dev, i) !=0 ) { +for (i =0 ; i < num_queues; i++) { +if (gve_is_gqi (priv)) + ret =gve_tx_queue_start (dev, i); +else + ret =gve_tx_queue_start_dqo (dev, i); +if (ret !=0 ) {PMD_DRV_LOG (ERR ,"Fail to start Tx queue %d" , i); goto err_tx; } + } num_queues = dev->data->nb_rx_queues;priv->rxqs = (struct gve_rx_queue **)dev->data->rx_queues;drivers/net/gve/gve_ethdev.c +16
-5@@ -315,9 +320,15 @@ struct gve_queue_page_list *return 0 ; err_rx: -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_rx_queues (dev); +else +gve_stop_rx_queues_dqo (dev); err_tx: -gve_stop_tx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_tx_queues (dev); +else +gve_stop_tx_queues_dqo (dev);return ret; }@@ -362,10 +373,16 @@ struct gve_queue_page_list *static int gve_dev_stop (struct rte_eth_dev *dev) { +struct gve_priv *priv = dev->data->dev_private; dev->data->dev_link.link_status =RTE_ETH_LINK_DOWN ; -gve_stop_tx_queues (dev); -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) { +gve_stop_tx_queues (dev); +gve_stop_rx_queues (dev); + }else { +gve_stop_tx_queues_dqo (dev); +gve_stop_rx_queues_dqo (dev); + } dev->data->dev_started =0 ; --1.8.3.1
Re: [PATCH v2] net/gve: Fix TX/RX queue setup and stop
Quoted 13 lines · Tathagat Priyadarshi
Hi @Ferruh Yigit <mailto:[email protected]>
I have updated v2 https://patches.dpdk.org/project/dpdk/
patch/[email protected]/
<https://patches.dpdk.org/project/dpdk/patch/1721914264-2394611-1-git-
[email protected]/>
and sent it in reply to the previous message id (https://
patches.dpdk.org/project/dpdk/patch/1721828129-2393364-1-git-send-email- [email protected]/ <https://patches.dpdk.org/project/dpdk/
patch/[email protected]/Quoted 1 line
) , let me know if this is fine.
Looks good, thanks.
I will wait for Joshua's ack.
Joshua Washington
Acked-byRe: [PATCH v2] net/gve: Fix TX/RX queue setup and stop
Re: [PATCH v2] net/gve: Fix TX/RX queue setup and stop
In reply to Ferruh YigitQuoted 11 lines · Ferruh Yigit
Quoted 10 lines · Tathagat Priyadarshi
Hi @Ferruh Yigit <mailto:[email protected]>
I have updated v2 https://patches.dpdk.org/project/dpdk/
patch/[email protected]/
<https://patches.dpdk.org/project/dpdk/patch/1721914264-2394611-1-git-
[email protected]/>
and sent it in reply to the previous message id (https://
patches.dpdk.org/project/dpdk/patch/1721828129-2393364-1-git-send-email- [email protected]/ <https://patches.dpdk.org/project/dpdk/
patch/[email protected]/
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
) , let me know if this is fine.
Looks good, thanks.
I will wait for Joshua's ack.
Hi Tathagat, Joshua,
Can you please provide the fixes tag?
PATCH v2 1/1 net/gve: Fix TX/RX queue setup and stop
In reply to Tathagat PriyadarshiThe PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop
--- drivers/net/gve/gve_ethdev.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-)
drivers/net/gve/gve_ethdev.c +23 -6
@@ -288,11 +288,16 @@ struct gve_queue_page_list *PMD_DRV_LOG (ERR ,"Failed to create %u tx queues." , num_queues);return ret; } -for (i =0 ; i < num_queues; i++) -if (gve_tx_queue_start (dev, i) !=0 ) { +for (i =0 ; i < num_queues; i++) { +if (gve_is_gqi (priv)) + ret =gve_tx_queue_start (dev, i); +else + ret =gve_tx_queue_start_dqo (dev, i); +if (ret !=0 ) {PMD_DRV_LOG (ERR ,"Fail to start Tx queue %d" , i); goto err_tx; } + } num_queues = dev->data->nb_rx_queues; priv->rxqs = (struct gve_rx_queue **)dev->data->rx_queues;
@@ -315,9 +320,15 @@ struct gve_queue_page_list *return 0 ; err_rx: -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_rx_queues (dev); +else +gve_stop_rx_queues_dqo (dev); err_tx: -gve_stop_tx_queues (dev); +if (gve_is_gqi (priv)) +gve_stop_tx_queues (dev); +else +gve_stop_tx_queues_dqo (dev);return ret; }
@@ -362,10 +373,16 @@ struct gve_queue_page_list *static int gve_dev_stop (struct rte_eth_dev *dev) { +struct gve_priv *priv = dev->data->dev_private; dev->data->dev_link.link_status =RTE_ETH_LINK_DOWN ; -gve_stop_tx_queues (dev); -gve_stop_rx_queues (dev); +if (gve_is_gqi (priv)) { +gve_stop_tx_queues (dev); +gve_stop_rx_queues (dev); + }else { +gve_stop_tx_queues_dqo (dev); +gve_stop_rx_queues_dqo (dev); + } dev->data->dev_started =0 ;
Signature · 1 line
1.8.3.1
Re: [PATCH v2] net/gve: Fix TX/RX queue setup and stop
Quoted 9 lines · Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop
Fixes b044845 ("net/gve: support queue start/stop")Signed-off-by Tathagat Priyadarshi <[email protected]>
Moving Joshua's ack from other thread:
Applied to dpdk-next-net/main, thanks.
Please note, although I applied the fix to the next-net, probably it won't able to make the v23.07 release, as we are already post -rc4 phase. In that case patch will be merged to main repo for next release.
And a few other operational notes:
- I have updated patch title and commit log slightly, please check the updates. For next contribution, please run the './devtools/check-git-log.sh' tool
- Sending a new version of the patch, with same version tag is confusing, also it will be confusing when tracing back from commit to the mail list / patchwork later. So please increase version tag when a new version sent.
Thanks,
ferruh